ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hw/net/fsl_etsec/miim: Reuse MII constants 

Instead of defining redundant constants and using magic numbers reuse the
existing MII constants.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
cc: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-ID: <20241103133412.73536-16-shentey@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Bernhard Beschow 2024-11-03 14:34:01 +01:00 committed by Philippe Mathieu-Daudé
parent ab22a14dc0
commit 65a12bb572
1 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
hw/net/fsl_etsec/miim.c
View File

@ -29,13 +29,6 @@
/* #define DEBUG_MIIM */ /* #define DEBUG_MIIM */
#define MIIM_CONTROL 0
#define MIIM_STATUS 1
#define MIIM_PHY_ID_1 2
#define MIIM_PHY_ID_2 3
#define MIIM_T2_STATUS 10
#define MIIM_EXT_STATUS 15
static void miim_read_cycle(eTSEC *etsec) static void miim_read_cycle(eTSEC *etsec)
{ {
uint8_t phy; uint8_t phy;
@ -47,14 +40,14 @@ static void miim_read_cycle(eTSEC *etsec)
addr = etsec->regs[MIIMADD].value & 0x1F; addr = etsec->regs[MIIMADD].value & 0x1F;
switch (addr) { switch (addr) {
case MIIM_CONTROL: case MII_BMCR:
value = etsec->phy_control; value = etsec->phy_control;
break; break;
case MIIM_STATUS: case MII_BMSR:
value = etsec->phy_status; value = etsec->phy_status;
break; break;
case MIIM_T2_STATUS: case MII_STAT1000:
value = 0x1800; /* Local and remote receivers OK */ value = MII_STAT1000_LOK | MII_STAT1000_ROK;
break; break;
default: default:
value = 0x0; value = 0x0;
@ -84,8 +77,8 @@ static void miim_write_cycle(eTSEC *etsec)
#endif #endif
switch (addr) { switch (addr) {
case MIIM_CONTROL: case MII_BMCR:
etsec->phy_control = value & ~(0x8100); etsec->phy_control = value & ~(MII_BMCR_RESET | MII_BMCR_FD);
break; break;
default: default:
break; break;