ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ppc/pegasos2: Improve readability of VIA south bridge creation 

Slightly improve readability of creating the south btidge by cnamging
type of a local variable to avoid some casts within function arguments
which makes some lines shorter and easier to read.
Also remove an unneded line break.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230117214545.5E191746369@zero.eik.bme.hu>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
This commit is contained in:
BALATON Zoltan 2023-01-17 22:36:42 +01:00 committed by Daniel Henrique Barboza
parent 8763196c2c
commit 65133e33eb
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
hw/ppc/pegasos2.c
View File

@ -102,7 +102,8 @@ static void pegasos2_init(MachineState *machine)
CPUPPCState *env; CPUPPCState *env;
MemoryRegion *rom = g_new(MemoryRegion, 1); MemoryRegion *rom = g_new(MemoryRegion, 1);
PCIBus *pci_bus; PCIBus *pci_bus;
PCIDevice *dev, *via; Object *via;
PCIDevice *dev;
I2CBus *i2c_bus; I2CBus *i2c_bus;
const char *fwname = machine->firmware ?: PROM_FILENAME; const char *fwname = machine->firmware ?: PROM_FILENAME;
char *filename; char *filename;
@ -159,19 +160,18 @@ static void pegasos2_init(MachineState *machine)
pci_bus = mv64361_get_pci_bus(pm->mv, 1); pci_bus = mv64361_get_pci_bus(pm->mv, 1);
/* VIA VT8231 South Bridge (multifunction PCI device) */ /* VIA VT8231 South Bridge (multifunction PCI device) */
via = pci_create_simple_multifunction(pci_bus, PCI_DEVFN(12, 0), true, via = OBJECT(pci_create_simple_multifunction(pci_bus, PCI_DEVFN(12, 0),
TYPE_VT8231_ISA); true, TYPE_VT8231_ISA));
object_property_add_alias(OBJECT(machine), "rtc-time", object_property_add_alias(OBJECT(machine), "rtc-time",
object_resolve_path_component(OBJECT(via), object_resolve_path_component(via, "rtc"),
"rtc"),
"date"); "date");
qdev_connect_gpio_out(DEVICE(via), 0, qdev_connect_gpio_out(DEVICE(via), 0,
qdev_get_gpio_in_named(pm->mv, "gpp", 31)); qdev_get_gpio_in_named(pm->mv, "gpp", 31));
dev = PCI_DEVICE(object_resolve_path_component(OBJECT(via), "ide")); dev = PCI_DEVICE(object_resolve_path_component(via, "ide"));
pci_ide_create_devs(dev); pci_ide_create_devs(dev);
dev = PCI_DEVICE(object_resolve_path_component(OBJECT(via), "pm")); dev = PCI_DEVICE(object_resolve_path_component(via, "pm"));
i2c_bus = I2C_BUS(qdev_get_child_bus(DEVICE(dev), "i2c")); i2c_bus = I2C_BUS(qdev_get_child_bus(DEVICE(dev), "i2c"));
spd_data = spd_data_generate(DDR, machine->ram_size); spd_data = spd_data_generate(DDR, machine->ram_size);
smbus_eeprom_init_one(i2c_bus, 0x57, spd_data); smbus_eeprom_init_one(i2c_bus, 0x57, spd_data);