ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hw/ppc/pnv: fix checkpatch.pl coding style warnings 

There were few trailing comments after `/*` instead in
new line and line more than 80 character, these fixes are
trivial and doesn't change any logic in code.

Signed-off-by: Balamuruhan S <bala24@linux.ibm.com>
Message-Id: <20190911142925.19197-5-bala24@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Balamuruhan S 2019-09-11 19:59:25 +05:30 committed by David Gibson
parent 226c9d15df
commit 59b7c1c283
1 changed files with 32 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
hw/ppc/pnv.c
View File

@ -187,7 +187,8 @@ static void pnv_dt_core(PnvChip *chip, PnvCore *pc, void *fdt)
_FDT((fdt_setprop_cell(fdt, offset, "timebase-frequency", tbfreq))); _FDT((fdt_setprop_cell(fdt, offset, "timebase-frequency", tbfreq)));
_FDT((fdt_setprop_cell(fdt, offset, "clock-frequency", cpufreq))); _FDT((fdt_setprop_cell(fdt, offset, "clock-frequency", cpufreq)));
_FDT((fdt_setprop_cell(fdt, offset, "ibm,slb-size", cpu->hash64_opts->slb_size))); _FDT((fdt_setprop_cell(fdt, offset, "ibm,slb-size",
cpu->hash64_opts->slb_size)));
_FDT((fdt_setprop_string(fdt, offset, "status", "okay"))); _FDT((fdt_setprop_string(fdt, offset, "status", "okay")));
_FDT((fdt_setprop(fdt, offset, "64-bit", NULL, 0))); _FDT((fdt_setprop(fdt, offset, "64-bit", NULL, 0)));
@ -200,19 +201,23 @@ static void pnv_dt_core(PnvChip *chip, PnvCore *pc, void *fdt)
segs, sizeof(segs)))); segs, sizeof(segs))));
} }
/* Advertise VMX/VSX (vector extensions) if available /*
* Advertise VMX/VSX (vector extensions) if available
* 0 / no property == no vector extensions * 0 / no property == no vector extensions
* 1 == VMX / Altivec available * 1 == VMX / Altivec available
* 2 == VSX available */ * 2 == VSX available
*/
if (env->insns_flags & PPC_ALTIVEC) { if (env->insns_flags & PPC_ALTIVEC) {
uint32_t vmx = (env->insns_flags2 & PPC2_VSX) ? 2 : 1; uint32_t vmx = (env->insns_flags2 & PPC2_VSX) ? 2 : 1;
_FDT((fdt_setprop_cell(fdt, offset, "ibm,vmx", vmx))); _FDT((fdt_setprop_cell(fdt, offset, "ibm,vmx", vmx)));
} }
/* Advertise DFP (Decimal Floating Point) if available /*
* Advertise DFP (Decimal Floating Point) if available
* 0 / no property == no DFP * 0 / no property == no DFP
* 1 == DFP available */ * 1 == DFP available
*/
if (env->insns_flags2 & PPC2_DFP) { if (env->insns_flags2 & PPC2_DFP) {
_FDT((fdt_setprop_cell(fdt, offset, "ibm,dfp", 1))); _FDT((fdt_setprop_cell(fdt, offset, "ibm,dfp", 1)));
} }
@ -424,7 +429,8 @@ static int pnv_dt_isa_device(DeviceState *dev, void *opaque)
return 0; return 0;
} }
/* The default LPC bus of a multichip system is on chip 0. It's /*
* The default LPC bus of a multichip system is on chip 0. It's
* recognized by the firmware (skiboot) using a "primary" property. * recognized by the firmware (skiboot) using a "primary" property.
*/ */
static void pnv_dt_isa(PnvMachineState *pnv, void *fdt) static void pnv_dt_isa(PnvMachineState *pnv, void *fdt)
@ -442,8 +448,10 @@ static void pnv_dt_isa(PnvMachineState *pnv, void *fdt)
assert(phandle > 0); assert(phandle > 0);
_FDT((fdt_setprop_cell(fdt, isa_offset, "phandle", phandle))); _FDT((fdt_setprop_cell(fdt, isa_offset, "phandle", phandle)));
/* ISA devices are not necessarily parented to the ISA bus so we /*
* can not use object_child_foreach() */ * ISA devices are not necessarily parented to the ISA bus so we
* can not use object_child_foreach()
*/
qbus_walk_children(BUS(pnv->isa_bus), pnv_dt_isa_device, NULL, NULL, NULL, qbus_walk_children(BUS(pnv->isa_bus), pnv_dt_isa_device, NULL, NULL, NULL,
&args); &args);
} }
@ -545,7 +553,8 @@ static void pnv_reset(MachineState *machine)
qemu_devices_reset(); qemu_devices_reset();
/* OpenPOWER systems have a BMC, which can be defined on the /*
* OpenPOWER systems have a BMC, which can be defined on the
* command line with: * command line with:
* *
* -device ipmi-bmc-sim,id=bmc0 * -device ipmi-bmc-sim,id=bmc0
@ -705,7 +714,8 @@ static void pnv_init(MachineState *machine)
pnv->chips[i] = PNV_CHIP(chip); pnv->chips[i] = PNV_CHIP(chip);
/* TODO: put all the memory in one node on chip 0 until we find a /*
* TODO: put all the memory in one node on chip 0 until we find a
* way to specify different ranges for each chip * way to specify different ranges for each chip
*/ */
if (i == 0) { if (i == 0) {
@ -732,8 +742,10 @@ static void pnv_init(MachineState *machine)
/* Create an RTC ISA device too */ /* Create an RTC ISA device too */
mc146818_rtc_init(pnv->isa_bus, 2000, NULL); mc146818_rtc_init(pnv->isa_bus, 2000, NULL);
/* OpenPOWER systems use a IPMI SEL Event message to notify the /*
* host to powerdown */ * OpenPOWER systems use a IPMI SEL Event message to notify the
* host to powerdown
*/
pnv->powerdown_notifier.notify = pnv_powerdown_notify; pnv->powerdown_notifier.notify = pnv_powerdown_notify;
qemu_register_powerdown_notifier(&pnv->powerdown_notifier); qemu_register_powerdown_notifier(&pnv->powerdown_notifier);
} }
@ -803,7 +815,8 @@ static void pnv_chip_power9_intc_create(PnvChip *chip, PowerPCCPU *cpu,
pnv_cpu->intc = obj; pnv_cpu->intc = obj;
} }
/* Allowed core identifiers on a POWER8 Processor Chip : /*
* Allowed core identifiers on a POWER8 Processor Chip :
* *
* <EX0 reserved> * <EX0 reserved>
* EX1 - Venice only * EX1 - Venice only
@ -923,8 +936,10 @@ static void pnv_chip_power8_realize(DeviceState *dev, Error **errp)
(uint64_t) PNV_XSCOM_BASE(chip), (uint64_t) PNV_XSCOM_BASE(chip),
PNV_XSCOM_LPC_BASE); PNV_XSCOM_LPC_BASE);
/* Interrupt Management Area. This is the memory region holding /*
* all the Interrupt Control Presenter (ICP) registers */ * Interrupt Management Area. This is the memory region holding
* all the Interrupt Control Presenter (ICP) registers
*/
pnv_chip_icp_realize(chip8, &local_err); pnv_chip_icp_realize(chip8, &local_err);
if (local_err) { if (local_err) {
error_propagate(errp, local_err); error_propagate(errp, local_err);
@ -1404,8 +1419,8 @@ static void pnv_machine_class_init(ObjectClass *oc, void *data)
mc->init = pnv_init; mc->init = pnv_init;
mc->reset = pnv_reset; mc->reset = pnv_reset;
mc->max_cpus = MAX_CPUS; mc->max_cpus = MAX_CPUS;
mc->block_default_type = IF_IDE; /* Pnv provides a AHCI device for /* Pnv provides a AHCI device for storage */
* storage */ mc->block_default_type = IF_IDE;
mc->no_parallel = 1; mc->no_parallel = 1;
mc->default_boot_order = NULL; mc->default_boot_order = NULL;
/* /*