ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libcacard/vscclient: fix leakage of socket on error paths 

Spotted by Coverity.

Signed-off-by: Alon Levy <alevy@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Alon Levy 2013-06-04 16:23:37 -04:00 committed by Michael Tokarev
parent e098b45386
commit 581fe784c3
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libcacard/vscclient.c
View File

@ -618,18 +618,22 @@ connect_to_qemu(
if (ret != 0) { if (ret != 0) {
/* Error */ /* Error */
fprintf(stderr, "getaddrinfo failed\n"); fprintf(stderr, "getaddrinfo failed\n");
return -1; goto cleanup_socket;
} }
if (connect(sock, server->ai_addr, server->ai_addrlen) < 0) { if (connect(sock, server->ai_addr, server->ai_addrlen) < 0) {
/* Error */ /* Error */
fprintf(stderr, "Could not connect\n"); fprintf(stderr, "Could not connect\n");
return -1; goto cleanup_socket;
} }
if (verbose) { if (verbose) {
printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader)); printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader));
} }
return sock; return sock;
cleanup_socket:
closesocket(sock);
return -1;
} }
int int
@ -759,5 +763,6 @@ main(
g_io_channel_unref(channel_socket); g_io_channel_unref(channel_socket);
g_byte_array_unref(socket_to_send); g_byte_array_unref(socket_to_send);
closesocket(sock);
return 0; return 0;
} }