mirror of https://github.com/xemu-project/xemu.git
object: fix potential leak in getters
If the property is not of the requested type, the getters will leak a QObject. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20170607163635.17635-3-marcandre.lureau@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
parent
a2740ad584
commit
560f19f162
|
@ -1122,7 +1122,7 @@ char *object_property_get_str(Object *obj, const char *name,
|
|||
retval = g_strdup(qstring_get_str(qstring));
|
||||
}
|
||||
|
||||
QDECREF(qstring);
|
||||
qobject_decref(ret);
|
||||
return retval;
|
||||
}
|
||||
|
||||
|
@ -1183,7 +1183,7 @@ bool object_property_get_bool(Object *obj, const char *name,
|
|||
retval = qbool_get_bool(qbool);
|
||||
}
|
||||
|
||||
QDECREF(qbool);
|
||||
qobject_decref(ret);
|
||||
return retval;
|
||||
}
|
||||
|
||||
|
@ -1214,7 +1214,7 @@ int64_t object_property_get_int(Object *obj, const char *name,
|
|||
retval = qint_get_int(qint);
|
||||
}
|
||||
|
||||
QDECREF(qint);
|
||||
qobject_decref(ret);
|
||||
return retval;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue