ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vnc: fix unfinalized tlscreds for VncDisplay 

In vnc_display_open(), if tls-creds is enabled, do object_ref(object
ref 1->2) for tls-creds. While in vnc_display_close(), object_unparent
sets object ref to 1(2->1) and  unparent the object for root.
Problem:
1. the object can not be found from the objects_root, while the object
is not finalized.
2. the qemu_opts of tls-creds(id: creds0) is not deleted, so new tls
object with the same id(creds0) can not be delete & add.

Signed-off-by: Zihao Chang <changzihao1@huawei.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20210111131911.805-1-changzihao1@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Zihao Chang 2021-01-11 21:19:11 +08:00 committed by Gerd Hoffmann
parent cab82424f6
commit 521534df57
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/vnc.c
View File

@ -3234,7 +3234,7 @@ static void vnc_display_close(VncDisplay *vd)
vd->auth = VNC_AUTH_INVALID; vd->auth = VNC_AUTH_INVALID;
vd->subauth = VNC_AUTH_INVALID; vd->subauth = VNC_AUTH_INVALID;
if (vd->tlscreds) { if (vd->tlscreds) {
object_unparent(OBJECT(vd->tlscreds)); object_unref(OBJECT(vd->tlscreds));
vd->tlscreds = NULL; vd->tlscreds = NULL;
} }
if (vd->tlsauthz) { if (vd->tlsauthz) {