ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests/qtest: bios-tables-test: Adapt the case for win32 

Single quotes in the arguments (oem_id='CRASH ') are not removed in
the Windows environment before it is passed to the QEMU executable.
The space in the argument causes the "-acpitable" option parser to
think that all of its parameters are done, hence it complains:

  '-acpitable' requires one of 'data' or 'file'

Change to use double quotes which works fine on all platforms.

Also /dev/null does not work on win32, and nul should be used.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20220925113032.1949844-39-bmeng.cn@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Bin Meng 2022-09-25 19:30:16 +08:00 committed by Thomas Huth
parent be181f87eb
commit 4b83dd0efd
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/qtest/bios-tables-test.c
View File

@ -1615,6 +1615,12 @@ static void test_acpi_virt_viot(void)
free_test_data(&data); free_test_data(&data);
} }
#ifndef _WIN32
# define DEV_NULL "/dev/null"
#else
# define DEV_NULL "nul"
#endif
static void test_acpi_q35_slic(void) static void test_acpi_q35_slic(void)
{ {
test_data data = { test_data data = {
@ -1622,9 +1628,9 @@ static void test_acpi_q35_slic(void)
.variant = ".slic", .variant = ".slic",
}; };
test_acpi_one("-acpitable sig=SLIC,oem_id='CRASH ',oem_table_id='ME'," test_acpi_one("-acpitable sig=SLIC,oem_id=\"CRASH \",oem_table_id=ME,"
"oem_rev=00002210,asl_compiler_id='qemu'," "oem_rev=00002210,asl_compiler_id=qemu,"
"asl_compiler_rev=00000000,data=/dev/null", "asl_compiler_rev=00000000,data=" DEV_NULL,
&data); &data);
free_test_data(&data); free_test_data(&data);
} }