ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Monitor: Return before exiting with 'quit' 

This is a new version of the (now reverted) following commit:

0e8d2b5575

The 'quit' Monitor command (implemented by do_quit()) calls
exit() directly, this is problematic under QMP because QEMU
exits before having a chance to send the ok response.

Clients don't know if QEMU exited because of a problem or
because the 'quit' command has been executed.

This commit fixes that by making do_quit() use
qemu_system_shutdown_request(), so that we exit gracefully.

Thanks to Paolo Bonzini <pbonzini@redhat.com> for suggesting
this solution.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This commit is contained in:
Luiz Capitulino 2010-05-11 18:08:20 -03:00
parent a691d41a11
commit 39b59d2606
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
monitor.c
View File

@ -1020,7 +1020,10 @@ static void do_info_cpu_stats(Monitor *mon)
*/ */
static int do_quit(Monitor *mon, const QDict *qdict, QObject **ret_data) static int do_quit(Monitor *mon, const QDict *qdict, QObject **ret_data)
{ {
exit(0); monitor_suspend(mon);
no_shutdown = 0;
qemu_system_shutdown_request();
return 0; return 0;
} }