ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vhost-vdpa: correctly return err in vhost_vdpa_set_backend_cap() 

We should return error code instead of zero, otherwise there's no way
for the caller to detect the failure.

Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20210903091031.47303-3-jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Jason Wang 2021-09-03 17:10:12 +08:00 committed by Michael S. Tsirkin
parent 12021b53a4
commit 2a83e97ee8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/virtio/vhost-vdpa.c
View File

@ -443,13 +443,13 @@ static int vhost_vdpa_set_backend_cap(struct vhost_dev *dev)
int r; int r;
if (vhost_vdpa_call(dev, VHOST_GET_BACKEND_FEATURES, &features)) { if (vhost_vdpa_call(dev, VHOST_GET_BACKEND_FEATURES, &features)) {
return 0; return -EFAULT;
} }
features &= f; features &= f;
r = vhost_vdpa_call(dev, VHOST_SET_BACKEND_FEATURES, &features); r = vhost_vdpa_call(dev, VHOST_SET_BACKEND_FEATURES, &features);
if (r) { if (r) {
return 0; return -EFAULT;
} }
dev->backend_cap = features; dev->backend_cap = features;