ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

contrib/elf2dmp: Fix error reporting style in download.c 

include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240307-elf2dmp-v4-6-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Akihiko Odaki 2024-03-07 19:20:49 +09:00 committed by Peter Maydell
parent a15f974949
commit 1b806c36bc
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
contrib/elf2dmp/download.c
View File

@ -9,14 +9,14 @@
#include <curl/curl.h>
#include "download.h"
int download_url(const char *name, const char *url)
bool download_url(const char *name, const char *url)
{
int err = 1;
bool success = false;
FILE *file;
CURL *curl = curl_easy_init();
if (!curl) {
return 1;
return false;
}
file = fopen(name, "wb");
@ -33,11 +33,11 @@ int download_url(const char *name, const char *url)
unlink(name);
fclose(file);
} else {
err = fclose(file);
success = !fclose(file);
}
out_curl:
curl_easy_cleanup(curl);
return err;
return success;
}

2
contrib/elf2dmp/download.h
View File

@ -8,6 +8,6 @@
#ifndef DOWNLOAD_H
#define DOWNLOAD_H
int download_url(const char *name, const char *url);
bool download_url(const char *name, const char *url);
#endif /* DOWNLOAD_H */

2
contrib/elf2dmp/main.c
View File

@ -591,7 +591,7 @@ int main(int argc, char *argv[])
sprintf(pdb_url, "%s%s/%s/%s", SYM_URL_BASE, PDB_NAME, pdb_hash, PDB_NAME);
printf("PDB URL is %s\n", pdb_url);
if (download_url(PDB_NAME, pdb_url)) {
if (!download_url(PDB_NAME, pdb_url)) {
eprintf("Failed to download PDB file\n");
goto out_ps;
}