ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

qemu-nbd: handle dup2() error when qemu-nbd finished setup process 

Fail on error, we are in trouble.

Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Eric Blake <eblake@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-ID: <20230717145544.194786-6-den@openvz.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
[eblake: avoid intermediate variable]
Signed-off-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Denis V. Lunev 2023-07-17 16:55:44 +02:00 committed by Eric Blake
parent e0892ced05
commit 173776f74d
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
qemu-nbd.c
View File

@ -323,7 +323,11 @@ static void *nbd_client_thread(void *arg)
opts->device, srcpath); opts->device, srcpath);
} else { } else {
/* Close stderr so that the qemu-nbd process exits. */ /* Close stderr so that the qemu-nbd process exits. */
dup2(STDOUT_FILENO, STDERR_FILENO); if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
error_report("Could not set stderr to /dev/null: %s",
strerror(errno));
exit(EXIT_FAILURE);
}
} }
if (nbd_client(fd) < 0) { if (nbd_client(fd) < 0) {
@ -1171,7 +1175,11 @@ int main(int argc, char **argv)
} }
if (fork_process) { if (fork_process) {
dup2(STDOUT_FILENO, STDERR_FILENO); if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
error_report("Could not set stderr to /dev/null: %s",
strerror(errno));
exit(EXIT_FAILURE);
}
} }
state = RUNNING; state = RUNNING;