ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests: Use error_free_or_abort() where appropriate 

Done with this Coccinelle semantic patch:

    @@
    expression E;
    @@
    -    g_assert(E);
    -    error_free(E);
    +    error_free_or_abort(&E);

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1487362554-5688-1-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Markus Armbruster 2017-02-17 21:15:54 +01:00
parent d84f714eaf
commit 157db293eb
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test-qemu-opts.c
View File

@ -93,8 +93,7 @@ static void test_find_unknown_opts(void)
/* should not return anything, we don't have an "unknown" option */ /* should not return anything, we don't have an "unknown" option */
list = qemu_find_opts_err("unknown", &err); list = qemu_find_opts_err("unknown", &err);
g_assert(list == NULL); g_assert(list == NULL);
g_assert(err); error_free_or_abort(&err);
error_free(err);
} }
static void test_qemu_find_opts(void) static void test_qemu_find_opts(void)

6
tests/test-qobject-output-visitor.c
View File

@ -145,8 +145,7 @@ static void test_visitor_out_enum_errors(TestOutputVisitorData *data,
for (i = 0; i < ARRAY_SIZE(bad_values) ; i++) { for (i = 0; i < ARRAY_SIZE(bad_values) ; i++) {
err = NULL; err = NULL;
visit_type_EnumOne(data->ov, "unused", &bad_values[i], &err); visit_type_EnumOne(data->ov, "unused", &bad_values[i], &err);
g_assert(err); error_free_or_abort(&err);
error_free(err);
visitor_reset(data); visitor_reset(data);
} }
} }
@ -244,8 +243,7 @@ static void test_visitor_out_struct_errors(TestOutputVisitorData *data,
u.has_enum1 = true; u.has_enum1 = true;
u.enum1 = bad_values[i]; u.enum1 = bad_values[i];
visit_type_UserDefOne(data->ov, "unused", &pu, &err); visit_type_UserDefOne(data->ov, "unused", &pu, &err);
g_assert(err); error_free_or_abort(&err);
error_free(err);
visitor_reset(data); visitor_reset(data);
} }
} }