ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

opts: remove redundant check for NULL parameter 

No callers of get_opt_value() pass in a NULL for the "value" parameter,
so the check is redundant.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20180514171913.17664-4-berrange@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Tested-by: Roman Kagan <rkagan@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2018-05-14 18:19:13 +01:00 committed by Paolo Bonzini
parent f8da93a0ff
commit 0c2f6e7ee9
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
util/qemu-option.c
View File

@ -75,20 +75,16 @@ const char *get_opt_value(const char *p, char **value)
size_t capacity = 0, length; size_t capacity = 0, length;
const char *offset; const char *offset;
if (value) { *value = NULL;
*value = NULL;
}
while (1) { while (1) {
offset = qemu_strchrnul(p, ','); offset = qemu_strchrnul(p, ',');
length = offset - p; length = offset - p;
if (*offset != '\0' && *(offset + 1) == ',') { if (*offset != '\0' && *(offset + 1) == ',') {
length++; length++;
} }
if (value) { *value = g_renew(char, *value, capacity + length + 1);
*value = g_renew(char, *value, capacity + length + 1); strncpy(*value + capacity, p, length);
strncpy(*value + capacity, p, length); (*value)[capacity + length] = '\0';
(*value)[capacity + length] = '\0';
}
capacity += length; capacity += length;
if (*offset == '\0' || if (*offset == '\0' ||
*(offset + 1) != ',') { *(offset + 1) != ',') {