ShuriZma
/
xemu
mirror of https://github.com/xemu-project/xemu.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hw/display/artist: Delay some variables initialization 

We want to have an early exit path. Delay some initializations
before the variables are used.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Sven Schnelle <svens@stackframe.org>
Message-Id: <20200214001303.12873-4-f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2020-02-14 01:13:00 +01:00 committed by Richard Henderson
parent 6c69f9c48e
commit 0814343ce2
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hw/display/artist.c
View File

@ -558,7 +558,7 @@ static void draw_line(ARTISTState *s, int x1, int y1, int x2, int y2,
bool update_start, int skip_pix, int max_pix) bool update_start, int skip_pix, int max_pix)
{ {
struct vram_buffer *buf; struct vram_buffer *buf;
uint8_t color = artist_get_color(s); uint8_t color;
int dx, dy, t, e, x, y, incy, diago, horiz; int dx, dy, t, e, x, y, incy, diago, horiz;
bool c1; bool c1;
uint8_t *p; uint8_t *p;
@ -569,10 +569,6 @@ static void draw_line(ARTISTState *s, int x1, int y1, int x2, int y2,
s->vram_start = (x2 << 16) | y2; s->vram_start = (x2 << 16) | y2;
} }
buf = &s->vram_buffer[ARTIST_BUFFER_AP];
c1 = false;
if (x2 > x1) { if (x2 > x1) {
dx = x2 - x1; dx = x2 - x1;
} else { } else {
@ -583,6 +579,8 @@ static void draw_line(ARTISTState *s, int x1, int y1, int x2, int y2,
} else { } else {
dy = y1 - y2; dy = y1 - y2;
} }
c1 = false;
if (dy > dx) { if (dy > dx) {
t = y2; t = y2;
y2 = x2; y2 = x2;
@ -620,6 +618,8 @@ static void draw_line(ARTISTState *s, int x1, int y1, int x2, int y2,
} }
x = x1; x = x1;
y = y1; y = y1;
color = artist_get_color(s);
buf = &s->vram_buffer[ARTIST_BUFFER_AP];
do { do {
if (c1) { if (c1) {