mirror of https://github.com/xemu-project/xemu.git
rust: clean up define_property macro
Use the "struct update" syntax to initialize most of the fields to zero, and simplify the handmade type-checking of $name. Reviewed-by: Junjie Mao <junjie.mao@hotmail.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
parent
e90d470733
commit
03a573b960
|
@ -29,44 +29,27 @@ macro_rules! device_class_init {
|
|||
macro_rules! define_property {
|
||||
($name:expr, $state:ty, $field:expr, $prop:expr, $type:expr, default = $defval:expr$(,)*) => {
|
||||
$crate::bindings::Property {
|
||||
name: {
|
||||
#[used]
|
||||
static _TEMP: &::core::ffi::CStr = $name;
|
||||
_TEMP.as_ptr()
|
||||
},
|
||||
// use associated function syntax for type checking
|
||||
name: ::core::ffi::CStr::as_ptr($name),
|
||||
info: $prop,
|
||||
offset: ::core::mem::offset_of!($state, $field)
|
||||
.try_into()
|
||||
.expect("Could not fit offset value to type"),
|
||||
bitnr: 0,
|
||||
bitmask: 0,
|
||||
set_default: true,
|
||||
defval: $crate::bindings::Property__bindgen_ty_1 { u: $defval.into() },
|
||||
arrayoffset: 0,
|
||||
arrayinfo: ::core::ptr::null(),
|
||||
arrayfieldsize: 0,
|
||||
link_type: ::core::ptr::null(),
|
||||
defval: $crate::bindings::Property__bindgen_ty_1 { u: $defval as u64 },
|
||||
..unsafe { ::core::mem::MaybeUninit::<$crate::bindings::Property>::zeroed().assume_init() }
|
||||
}
|
||||
};
|
||||
($name:expr, $state:ty, $field:expr, $prop:expr, $type:expr$(,)*) => {
|
||||
$crate::bindings::Property {
|
||||
name: {
|
||||
#[used]
|
||||
static _TEMP: &::core::ffi::CStr = $name;
|
||||
_TEMP.as_ptr()
|
||||
},
|
||||
// use associated function syntax for type checking
|
||||
name: ::core::ffi::CStr::as_ptr($name),
|
||||
info: $prop,
|
||||
offset: ::core::mem::offset_of!($state, $field)
|
||||
.try_into()
|
||||
.expect("Could not fit offset value to type"),
|
||||
bitnr: 0,
|
||||
bitmask: 0,
|
||||
set_default: false,
|
||||
defval: $crate::bindings::Property__bindgen_ty_1 { i: 0 },
|
||||
arrayoffset: 0,
|
||||
arrayinfo: ::core::ptr::null(),
|
||||
arrayfieldsize: 0,
|
||||
link_type: ::core::ptr::null(),
|
||||
..unsafe { ::core::mem::MaybeUninit::<$crate::bindings::Property>::zeroed().assume_init() }
|
||||
}
|
||||
};
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue