From 7a194fb224459d4daa60e6672c6f815f7661a292 Mon Sep 17 00:00:00 2001 From: Rafael Kitover Date: Fri, 8 Jun 2018 04:14:34 -0400 Subject: [PATCH] do not pause games when menus are pulled down Previously I disabled this for mac because of bugs in keyboard handling, but it turns out most people don't like the game pausing on menu pulldown anyway, so now I disable it for all platforms. TODO: the game still pauses for modal dialogs. --- src/wx/wxvbam.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/wx/wxvbam.cpp b/src/wx/wxvbam.cpp index b3df41df..d7c4d934 100644 --- a/src/wx/wxvbam.cpp +++ b/src/wx/wxvbam.cpp @@ -596,8 +596,13 @@ EVT_DROP_FILES(MainFrame::OnDropFile) // pause game if menu pops up // -// this causes problems with keyboard game keys on mac, disable for now -#ifndef __WXMAC__ +// This is a feature most people don't like, and it causes problems with +// keyboard game keys on mac, so we will disable it for now. +// +// On Winodws, there will still be a pause because of how the windows event +// model works, that needs to be investigated. +// +#if 0 EVT_MENU_OPEN(MainFrame::MenuPopped) EVT_MENU_CLOSE(MainFrame::MenuPopped) EVT_MENU_HIGHLIGHT_ALL(MainFrame::MenuPopped)