From 75eeef139cdd234b5a7a96ae95900aa3a86aff0c Mon Sep 17 00:00:00 2001 From: skidau Date: Fri, 3 Apr 2015 22:19:46 +0000 Subject: [PATCH] xBRZ 1.3 filter update by chrono, zenju https://sourceforge.net/projects/xbrz/ --- src/filters/xBRZ/config.h | 2 +- src/filters/xBRZ/xbrz.cpp | 802 +++++++++++++++++-------------------- src/filters/xBRZ/xbrz.h | 20 +- src/filters/xbrzfilter.cpp | 46 +-- 4 files changed, 402 insertions(+), 468 deletions(-) diff --git a/src/filters/xBRZ/config.h b/src/filters/xBRZ/config.h index 21cb3242..687bb7fb 100644 --- a/src/filters/xBRZ/config.h +++ b/src/filters/xBRZ/config.h @@ -1,6 +1,6 @@ // **************************************************************************** // * This file is part of the HqMAME project. It is distributed under * -// * GNU General Public License: http://www.gnu.org/licenses/gpl.html * +// * GNU General Public License: http://www.gnu.org/licenses/gpl-3.0 * // * Copyright (C) Zenju (zenju AT gmx DOT de) - All Rights Reserved * // * * // * Additionally and as a special exception, the author gives permission * diff --git a/src/filters/xBRZ/xbrz.cpp b/src/filters/xBRZ/xbrz.cpp index 24e8052e..db96694a 100644 --- a/src/filters/xBRZ/xbrz.cpp +++ b/src/filters/xBRZ/xbrz.cpp @@ -1,6 +1,6 @@ // **************************************************************************** // * This file is part of the HqMAME project. It is distributed under * -// * GNU General Public License: http://www.gnu.org/licenses/gpl.html * +// * GNU General Public License: http://www.gnu.org/licenses/gpl-3.0 * // * Copyright (C) Zenju (zenju AT gmx DOT de) - All Rights Reserved * // * * // * Additionally and as a special exception, the author gives permission * @@ -17,29 +17,69 @@ #include #include // abs, pow, sqrt #include +#include namespace { +#ifdef _MSC_VER + #define FORCE_INLINE __forceinline +#elif defined __GNUC__ + #define FORCE_INLINE __attribute__((always_inline)) inline +#else + #define FORCE_INLINE inline +#endif + + template inline unsigned char getByte(uint32_t val) { return static_cast((val >> (8 * N)) & 0xff); } -inline unsigned char getRed (uint32_t val) { return getByte<2>(val); } -inline unsigned char getGreen(uint32_t val) { return getByte<1>(val); } -inline unsigned char getBlue (uint32_t val) { return getByte<0>(val); } +inline unsigned char getAlpha(uint32_t pix) { return getByte<3>(pix); } +inline unsigned char getRed (uint32_t pix) { return getByte<2>(pix); } +inline unsigned char getGreen(uint32_t pix) { return getByte<1>(pix); } +inline unsigned char getBlue (uint32_t pix) { return getByte<0>(pix); } -const uint32_t redMask = 0xff0000; -const uint32_t greenMask = 0x00ff00; -const uint32_t blueMask = 0x0000ff; +inline uint32_t makePixel( unsigned char r, unsigned char g, unsigned char b) { return (r << 16) | (g << 8) | b; } +inline uint32_t makePixel(unsigned char a, unsigned char r, unsigned char g, unsigned char b) { return (a << 24) | (r << 16) | (g << 8) | b; } -template inline -void alphaBlend(uint32_t& dst, uint32_t col) //blend color over destination with opacity N / M + +template +FORCE_INLINE +unsigned char calcBlend(unsigned char colFront, unsigned char colBack) { - // static_assert(N < 256, "possible overflow of (col & redMask) * N"); - // static_assert(M < 256, "possible overflow of (col & redMask ) * N + (dst & redMask ) * (M - N)"); - // static_assert(0 < N && N < M, ""); - dst = (redMask & ((col & redMask ) * N + (dst & redMask ) * (M - N)) / M) | //this works because 8 upper bits are free - (greenMask & ((col & greenMask) * N + (dst & greenMask) * (M - N)) / M) | - (blueMask & ((col & blueMask ) * N + (dst & blueMask ) * (M - N)) / M); + return (colFront * M + colBack * (N - M)) / N; +} + +template inline +uint32_t alphaGradRGB(uint32_t pixFront, uint32_t pixBack) //blend front color with opacity M / N over opaque background: http://en.wikipedia.org/wiki/Alpha_compositing#Alpha_blending +{ + //~ static_assert(0 < M && M < N && N <= 1000, ""); + + return makePixel(calcBlend(getRed (pixFront), getRed (pixBack)), + calcBlend(getGreen(pixFront), getGreen(pixBack)), + calcBlend(getBlue (pixFront), getBlue (pixBack))); +} + +FORCE_INLINE +unsigned char calcColor(unsigned char colFront, unsigned char colBack, const unsigned int weightFront, const unsigned int weightBack, const unsigned int weightSum) +{ + return static_cast((colFront * weightFront + colBack * weightBack) / weightSum); +} + +template inline +uint32_t alphaGradARGB(uint32_t pixFront, uint32_t pixBack) //find intermediate color between two colors with alpha channels (=> NO alpha blending!!!) +{ + //~ static_assert(0 < M && M < N && N <= 1000, ""); + + const unsigned int weightFront = getAlpha(pixFront) * M; + const unsigned int weightBack = getAlpha(pixBack) * (N - M); + const unsigned int weightSum = weightFront + weightBack; + if (weightSum == 0) + return 0; + + return makePixel(static_cast(weightSum / N), + calcColor(getRed (pixFront), getRed (pixBack), weightFront, weightBack, weightSum), + calcColor(getGreen(pixFront), getGreen(pixBack), weightFront, weightBack, weightSum), + calcColor(getBlue (pixFront), getBlue (pixBack), weightFront, weightBack, weightSum)); } @@ -55,15 +95,6 @@ void alphaBlend(uint32_t& dst, uint32_t col) //blend color over destination with // -inline -uint32_t alphaBlend2(uint32_t pix1, uint32_t pix2, double alpha) -{ - return (redMask & static_cast((pix1 & redMask ) * alpha + (pix2 & redMask ) * (1 - alpha))) | - (greenMask & static_cast((pix1 & greenMask) * alpha + (pix2 & greenMask) * (1 - alpha))) | - (blueMask & static_cast((pix1 & blueMask ) * alpha + (pix2 & blueMask ) * (1 - alpha))); -} - - uint32_t* byteAdvance( uint32_t* ptr, int bytes) { return reinterpret_cast< uint32_t*>(reinterpret_cast< char*>(ptr) + bytes); } const uint32_t* byteAdvance(const uint32_t* ptr, int bytes) { return reinterpret_cast(reinterpret_cast(ptr) + bytes); } @@ -84,15 +115,6 @@ inline void fillBlock(uint32_t* trg, int pitch, uint32_t col, int n) { fillBlock(trg, pitch, col, n, n); } -#ifdef _MSC_VER -#define FORCE_INLINE __forceinline -#elif defined __GNUC__ -#define FORCE_INLINE __attribute__((always_inline)) inline -#else -#define FORCE_INLINE inline -#endif - - enum RotationDegree //clock-wise { ROT_0, @@ -146,199 +168,6 @@ template inline T square(T value) { return value * value; } -/* -inline -void rgbtoLuv(uint32_t c, double& L, double& u, double& v) -{ - //http://www.easyrgb.com/index.php?X=MATH&H=02#text2 - double r = getRed (c) / 255.0; - double g = getGreen(c) / 255.0; - double b = getBlue (c) / 255.0; - - if ( r > 0.04045 ) - r = std::pow(( ( r + 0.055 ) / 1.055 ) , 2.4); - else - r /= 12.92; - if ( g > 0.04045 ) - g = std::pow(( ( g + 0.055 ) / 1.055 ) , 2.4); - else - g /= 12.92; - if ( b > 0.04045 ) - b = std::pow(( ( b + 0.055 ) / 1.055 ) , 2.4); - else - b /= 12.92; - - r *= 100; - g *= 100; - b *= 100; - - double x = 0.4124564 * r + 0.3575761 * g + 0.1804375 * b; - double y = 0.2126729 * r + 0.7151522 * g + 0.0721750 * b; - double z = 0.0193339 * r + 0.1191920 * g + 0.9503041 * b; - //--------------------- - double var_U = 4 * x / ( x + 15 * y + 3 * z ); - double var_V = 9 * y / ( x + 15 * y + 3 * z ); - double var_Y = y / 100; - - if ( var_Y > 0.008856 ) var_Y = std::pow(var_Y , 1.0/3 ); - else var_Y = 7.787 * var_Y + 16.0 / 116; - - const double ref_X = 95.047; //Observer= 2°, Illuminant= D65 - const double ref_Y = 100.000; - const double ref_Z = 108.883; - - const double ref_U = ( 4 * ref_X ) / ( ref_X + ( 15 * ref_Y ) + ( 3 * ref_Z ) ); - const double ref_V = ( 9 * ref_Y ) / ( ref_X + ( 15 * ref_Y ) + ( 3 * ref_Z ) ); - - L = ( 116 * var_Y ) - 16; - u = 13 * L * ( var_U - ref_U ); - v = 13 * L * ( var_V - ref_V ); -} -*/ - -inline -void rgbtoLab(uint32_t c, unsigned char& L, signed char& A, signed char& B) -{ - //code: http://www.easyrgb.com/index.php?X=MATH - //test: http://www.workwithcolor.com/color-converter-01.htm - //------RGB to XYZ------ - double r = getRed (c) / 255.0; - double g = getGreen(c) / 255.0; - double b = getBlue (c) / 255.0; - - r = r > 0.04045 ? std::pow(( r + 0.055 ) / 1.055, 2.4) : r / 12.92; - r = g > 0.04045 ? std::pow(( g + 0.055 ) / 1.055, 2.4) : g / 12.92; - r = b > 0.04045 ? std::pow(( b + 0.055 ) / 1.055, 2.4) : b / 12.92; - - r *= 100; - g *= 100; - b *= 100; - - double x = 0.4124564 * r + 0.3575761 * g + 0.1804375 * b; - double y = 0.2126729 * r + 0.7151522 * g + 0.0721750 * b; - double z = 0.0193339 * r + 0.1191920 * g + 0.9503041 * b; - //------XYZ to Lab------ - const double refX = 95.047; // - const double refY = 100.000; //Observer= 2°, Illuminant= D65 - const double refZ = 108.883; // - double var_X = x / refX; - double var_Y = y / refY; - double var_Z = z / refZ; - - var_X = var_X > 0.008856 ? std::pow(var_X, 1.0 / 3) : 7.787 * var_X + 4.0 / 29; - var_Y = var_Y > 0.008856 ? std::pow(var_Y, 1.0 / 3) : 7.787 * var_Y + 4.0 / 29; - var_Z = var_Z > 0.008856 ? std::pow(var_Z, 1.0 / 3) : 7.787 * var_Z + 4.0 / 29; - - L = static_cast(116 * var_Y - 16); - A = static_cast< signed char>(500 * (var_X - var_Y)); - B = static_cast< signed char>(200 * (var_Y - var_Z)); -}; - - -inline -double distLAB(uint32_t pix1, uint32_t pix2) -{ - unsigned char L1 = 0; //[0, 100] - signed char a1 = 0; //[-128, 127] - signed char b1 = 0; //[-128, 127] - rgbtoLab(pix1, L1, a1, b1); - - unsigned char L2 = 0; - signed char a2 = 0; - signed char b2 = 0; - rgbtoLab(pix2, L2, a2, b2); - - //----------------------------- - //http://www.easyrgb.com/index.php?X=DELT - - //Delta E/CIE76 - return std::sqrt(square(1.0 * L1 - L2) + - square(1.0 * a1 - a2) + - square(1.0 * b1 - b2)); -} - - -/* -inline -void rgbtoHsl(uint32_t c, double& h, double& s, double& l) -{ - //http://www.easyrgb.com/index.php?X=MATH&H=18#text18 - const int r = getRed (c); - const int g = getGreen(c); - const int b = getBlue (c); - - const int varMin = numeric::min(r, g, b); - const int varMax = numeric::max(r, g, b); - const int delMax = varMax - varMin; - - l = (varMax + varMin) / 2.0 / 255.0; - - if (delMax == 0) //gray, no chroma... - { - h = 0; - s = 0; - } - else - { - s = l < 0.5 ? - delMax / (1.0 * varMax + varMin) : - delMax / (2.0 * 255 - varMax - varMin); - - double delR = ((varMax - r) / 6.0 + delMax / 2.0) / delMax; - double delG = ((varMax - g) / 6.0 + delMax / 2.0) / delMax; - double delB = ((varMax - b) / 6.0 + delMax / 2.0) / delMax; - - if (r == varMax) - h = delB - delG; - else if (g == varMax) - h = 1 / 3.0 + delR - delB; - else if (b == varMax) - h = 2 / 3.0 + delG - delR; - - if (h < 0) - h += 1; - if (h > 1) - h -= 1; - } -} - -inline -double distHSL(uint32_t pix1, uint32_t pix2, double lightningWeight) -{ - double h1 = 0; - double s1 = 0; - double l1 = 0; - rgbtoHsl(pix1, h1, s1, l1); - double h2 = 0; - double s2 = 0; - double l2 = 0; - rgbtoHsl(pix2, h2, s2, l2); - - //HSL is in cylindric coordinatates where L represents height, S radius, H angle, - //however we interpret the cylinder as a bi-conic solid with top/bottom radius 0, middle radius 1 - assert(0 <= h1 && h1 <= 1); - assert(0 <= h2 && h2 <= 1); - - double r1 = l1 < 0.5 ? - l1 * 2 : - 2 - l1 * 2; - - double x1 = r1 * s1 * std::cos(h1 * 2 * numeric::pi); - double y1 = r1 * s1 * std::sin(h1 * 2 * numeric::pi); - double z1 = l1; - - double r2 = l2 < 0.5 ? - l2 * 2 : - 2 - l2 * 2; - - double x2 = r2 * s2 * std::cos(h2 * 2 * numeric::pi); - double y2 = r2 * s2 * std::sin(h2 * 2 * numeric::pi); - double z2 = l2; - - return 255 * std::sqrt(square(x1 - x2) + square(y1 - y2) + square(lightningWeight * (z1 - z2))); -} -*/ - inline double distRGB(uint32_t pix1, uint32_t pix2) @@ -352,19 +181,6 @@ double distRGB(uint32_t pix1, uint32_t pix2) } -inline -double distNonLinearRGB(uint32_t pix1, uint32_t pix2) -{ - //non-linear rgb: http://www.compuphase.com/cmetric.htm - const double r_diff = static_cast(getRed (pix1)) - getRed (pix2); - const double g_diff = static_cast(getGreen(pix1)) - getGreen(pix2); - const double b_diff = static_cast(getBlue (pix1)) - getBlue (pix2); - - const double r_avg = (static_cast(getRed(pix1)) + getRed(pix2)) / 2; - return std::sqrt((2 + r_avg / 255) * square(r_diff) + 4 * square(g_diff) + (2 + (255 - r_avg) / 255) * square(b_diff)); -} - - inline double distYCbCr(uint32_t pix1, uint32_t pix2, double lumaWeight) { @@ -374,8 +190,10 @@ double distYCbCr(uint32_t pix1, uint32_t pix2, double lumaWeight) const int g_diff = static_cast(getGreen(pix1)) - getGreen(pix2); // const int b_diff = static_cast(getBlue (pix1)) - getBlue (pix2); //substraction for int is noticeable faster than for double! - const double k_b = 0.0722; //ITU-R BT.709 conversion - const double k_r = 0.2126; // + //const double k_b = 0.0722; //ITU-R BT.709 conversion + //const double k_r = 0.2126; // + const double k_b = 0.0593; //ITU-R BT.2020 conversion + const double k_r = 0.2627; // const double k_g = 1 - k_b - k_r; const double scale_b = 0.5 / (1 - k_b); @@ -386,65 +204,55 @@ double distYCbCr(uint32_t pix1, uint32_t pix2, double lumaWeight) const double c_r = scale_r * (r_diff - y); //we skip division by 255 to have similar range like other distance functions - return std::sqrt(square(lumaWeight * y) + square(c_b) + square(c_r)); + return std::sqrt(square(lumaWeight * y) + square(c_b) + square(c_r)); } -inline -double distYUV(uint32_t pix1, uint32_t pix2, double luminanceWeight) +struct DistYCbCrBuffer //30% perf boost compared to distYCbCr()! { - //perf: it's not worthwhile to buffer the YUV-conversion, the direct code is faster by ~ 6% - //since RGB -> YUV conversion is essentially a matrix multiplication, we can calculate the RGB diff before the conversion (distributive property) - const double r_diff = static_cast(getRed (pix1)) - getRed (pix2); - const double g_diff = static_cast(getGreen(pix1)) - getGreen(pix2); - const double b_diff = static_cast(getBlue (pix1)) - getBlue (pix2); +public: + DistYCbCrBuffer() : buffer(256 * 256 * 256) + { + for (uint32_t i = 0; i < 256 * 256 * 256; ++i) //startup time: 114 ms on Intel Core i5 (four cores) + { + const int r_diff = getByte<2>(i) * 2 - 255; + const int g_diff = getByte<1>(i) * 2 - 255; + const int b_diff = getByte<0>(i) * 2 - 255; - //http://en.wikipedia.org/wiki/YUV#Conversion_to.2Ffrom_RGB - const double w_b = 0.114; - const double w_r = 0.299; - const double w_g = 1 - w_r - w_b; + const double k_b = 0.0593; //ITU-R BT.2020 conversion + const double k_r = 0.2627; // + const double k_g = 1 - k_b - k_r; - const double u_max = 0.436; - const double v_max = 0.615; + const double scale_b = 0.5 / (1 - k_b); + const double scale_r = 0.5 / (1 - k_r); - const double scale_u = u_max / (1 - w_b); - const double scale_v = v_max / (1 - w_r); + const double y = k_r * r_diff + k_g * g_diff + k_b * b_diff; //[!], analog YCbCr! + const double c_b = scale_b * (b_diff - y); + const double c_r = scale_r * (r_diff - y); - double y = w_r * r_diff + w_g * g_diff + w_b * b_diff;//value range: 255 * [-1, 1] - double u = scale_u * (b_diff - y); //value range: 255 * 2 * u_max * [-1, 1] - double v = scale_v * (r_diff - y); //value range: 255 * 2 * v_max * [-1, 1] + buffer[i] = static_cast(std::sqrt(square(y) + square(c_b) + square(c_r))); + } + } -#ifndef NDEBUG - const double eps = 0.5; -#endif - assert(std::abs(y) <= 255 + eps); - assert(std::abs(u) <= 255 * 2 * u_max + eps); - assert(std::abs(v) <= 255 * 2 * v_max + eps); + double dist(uint32_t pix1, uint32_t pix2) const + { + //if (pix1 == pix2) -> 8% perf degradation! + // return 0; + //if (pix1 > pix2) + // std::swap(pix1, pix2); -> 30% perf degradation!!! - return std::sqrt(square(luminanceWeight * y) + square(u) + square(v)); -} + const int r_diff = static_cast(getRed (pix1)) - getRed (pix2); + const int g_diff = static_cast(getGreen(pix1)) - getGreen(pix2); + const int b_diff = static_cast(getBlue (pix1)) - getBlue (pix2); + return buffer[(((r_diff + 255) / 2) << 16) | //slightly reduce precision (division by 2) to squeeze value into single byte + (((g_diff + 255) / 2) << 8) | + (( b_diff + 255) / 2)]; + } -inline -double colorDist(uint32_t pix1, uint32_t pix2, double luminanceWeight) -{ - if (pix1 == pix2) //about 8% perf boost - return 0; - - //return distHSL(pix1, pix2, luminanceWeight); - //return distRGB(pix1, pix2); - //return distLAB(pix1, pix2); - //return distNonLinearRGB(pix1, pix2); - //return distYUV(pix1, pix2, luminanceWeight); - - return distYCbCr(pix1, pix2, luminanceWeight); -} - -inline -bool equalColor(uint32_t col1, uint32_t col2, double luminanceWeight, double equalColorTolerance) -{ - return colorDist(col1, col2, luminanceWeight) < equalColorTolerance; -} +private: + std::vector buffer; //consumes 64 MB memory; using double is 2% faster, but takes 128 MB +} distYCbCrBuffer; enum BlendType @@ -472,16 +280,18 @@ struct Kernel_4x4 //kernel for preprocessing step /**/m, n, o, p; }; +template FORCE_INLINE -double dist(uint32_t col1, uint32_t col2, const xbrz::ScalerCfg& cfg) +double dist(uint32_t pix1, uint32_t pix2, const xbrz::ScalerCfg& cfg) { - return colorDist(col1, col2, cfg.luminanceWeight_); + return ColorDistance::dist(pix1, pix2, cfg.luminanceWeight_); } +template FORCE_INLINE -bool eq(uint32_t col1, uint32_t col2, const xbrz::ScalerCfg& cfg) +bool eq(uint32_t pix1, uint32_t pix2, const xbrz::ScalerCfg& cfg) { - return equalColor(col1, col2, cfg.luminanceWeight_, cfg.equalColorTolerance_); + return ColorDistance::dist(pix1, pix2, cfg.luminanceWeight_) < cfg.equalColorTolerance_; } /* @@ -489,13 +299,14 @@ input kernel area naming convention: ----------------- | A | B | C | D | ----|---|---|---| -| E | F | G | H | //evalute the four corners between F, G, J, K +| E | F | G | H | //evaluate the four corners between F, G, J, K ----|---|---|---| //input pixel is at position F | I | J | K | L | ----|---|---|---| | M | N | O | P | ----------------- */ +template FORCE_INLINE //detect blend direction BlendResult preProcessCorners(const Kernel_4x4& ker, const xbrz::ScalerCfg& cfg) //result: F, G, J, K corners of "GradientType" { @@ -508,8 +319,8 @@ BlendResult preProcessCorners(const Kernel_4x4& ker, const xbrz::ScalerCfg& cfg) return result; const int weight = 4; - double jg = dist(ker.i, ker.f, cfg) + dist(ker.f, ker.c, cfg) + dist(ker.n, ker.k, cfg) + dist(ker.k, ker.h, cfg) + weight * dist(ker.j, ker.g, cfg); - double fk = dist(ker.e, ker.j, cfg) + dist(ker.j, ker.o, cfg) + dist(ker.b, ker.g, cfg) + dist(ker.g, ker.l, cfg) + weight * dist(ker.f, ker.k, cfg); + double jg = dist(ker.i, ker.f, cfg) + dist(ker.f, ker.c, cfg) + dist(ker.n, ker.k, cfg) + dist(ker.k, ker.h, cfg) + weight * dist(ker.j, ker.g, cfg); + double fk = dist(ker.e, ker.j, cfg) + dist(ker.j, ker.o, cfg) + dist(ker.b, ker.g, cfg) + dist(ker.g, ker.l, cfg) + weight * dist(ker.f, ker.k, cfg); if (jg < fk) //test sample: 70% of values max(jg, fk) / min(jg, fk) are between 1.1 and 3.7 with median being 1.8 { @@ -587,9 +398,11 @@ template <> inline unsigned char rotateBlendInfo(unsigned char b) { ret #ifndef NDEBUG -int debugPixelX = -1; -int debugPixelY = 84; -bool breakIntoDebugger = false; + int debugPixelX = -1; + int debugPixelY = 12; +#ifdef _MSC_VER + __declspec(thread) bool breakIntoDebugger = false; +#endif #endif @@ -603,9 +416,9 @@ input kernel area naming convention: | G | H | I | ------------- */ -template +template FORCE_INLINE //perf: quite worth it! -void scalePixel(const Kernel_3x3& ker, +void blendPixel(const Kernel_3x3& ker, uint32_t* target, int trgWidth, unsigned char blendInfo, //result of preprocessing all four corners of pixel "e" const xbrz::ScalerCfg& cfg) @@ -633,20 +446,20 @@ void scalePixel(const Kernel_3x3& ker, { bool doLineBlend = (getBottomR(blend) >= BLEND_DOMINANT) || !( //make sure there is no second blending in an adjacent rotation for this pixel: handles insular pixels, mario eyes - (getTopR(blend) != BLEND_NONE && !eq(e, g, cfg)) || //but support double-blending for 90° corners - (getBottomL(blend) != BLEND_NONE && !eq(e, c, cfg)) || + (getTopR(blend) != BLEND_NONE && !eq(e, g, cfg)) || //but support double-blending for 90° corners + (getBottomL(blend) != BLEND_NONE && !eq(e, c, cfg)) || //no full blending for L-shapes; blend corner only (handles "mario mushroom eyes") - (eq(g, h, cfg) && eq(h , i, cfg) && eq(i, f, cfg) && eq(f, c, cfg) && !eq(e, i, cfg)) + (!eq(e, i, cfg) && eq(g, h, cfg) && eq(h , i, cfg) && eq(i, f, cfg) && eq(f, c, cfg)) ); - const uint32_t px = dist(e, f, cfg) <= dist(e, h, cfg) ? f : h; //choose most similar color + const uint32_t px = dist(e, f, cfg) <= dist(e, h, cfg) ? f : h; //choose most similar color OutputMatrix out(target, trgWidth); if (doLineBlend) { - const double fg = dist(f, g, cfg); //test sample: 70% of values max(fg, hc) / min(fg, hc) are between 1.1 and 3.7 with median being 1.9 - const double hc = dist(h, c, cfg); // + const double fg = dist(f, g, cfg); //test sample: 70% of values max(fg, hc) / min(fg, hc) are between 1.1 and 3.7 with median being 1.9 + const double hc = dist(h, c, cfg); // const bool haveShallowLine = cfg.steepDirectionThreshold * fg <= hc && e != g && d != g; const bool haveSteepLine = cfg.steepDirectionThreshold * hc <= fg && e != c && b != c; @@ -681,7 +494,8 @@ void scalePixel(const Kernel_3x3& ker, #undef i } -template //scaler policy: see "Scaler2x" reference implementation + +template //scaler policy: see "Scaler2x" reference implementation void scaleImage(const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, uint32_t* trg, int trgWidth, const xbrz::ScalerCfg& cfg, int yFirst, int yLast) { yFirst = std::max(yFirst, 0); @@ -691,12 +505,12 @@ void scaleImage(const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, //"use" space at the end of the image as temporary buffer for "on the fly preprocessing": we even could use larger area of //"sizeof(uint32_t) * srcWidth * (yLast - yFirst)" bytes without risk of accidental overwriting before accessing - const int bufferSize = srcPitch; + const int bufferSize = srcWidth; unsigned char* preProcBuffer = reinterpret_cast(trg + yLast * Scaler::scale * trgWidth) - bufferSize; std::fill(preProcBuffer, preProcBuffer + bufferSize, 0); //~ static_assert(BLEND_NONE == 0, ""); - //initialize preprocessing buffer for first row: detect upper left and right corner blending + //initialize preprocessing buffer for first row of current stripe: detect upper left and right corner blending //this cannot be optimized for adjacent processing stripes; we must not allow for a memory race condition! if (yFirst > 0) { @@ -713,7 +527,7 @@ void scaleImage(const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, const int x_p1 = std::min(x + 1, srcWidth - 1); const int x_p2 = std::min(x + 2, srcWidth - 1); - Kernel_4x4 ker = {}; //perf: initialization is negligable + Kernel_4x4 ker = {}; //perf: initialization is negligible ker.a = s_m1[x_m1]; //read sequentially from memory as far as possible ker.b = s_m1[x]; ker.c = s_m1[x_p1]; @@ -734,7 +548,7 @@ void scaleImage(const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, ker.o = s_p2[x_p1]; ker.p = s_p2[x_p2]; - const BlendResult res = preProcessCorners(ker, cfg); + const BlendResult res = preProcessCorners(ker, cfg); /* preprocessing blend result: --------- @@ -745,7 +559,7 @@ void scaleImage(const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, */ setTopR(preProcBuffer[x], res.blend_j); - if (x + 1 < srcWidth) + if (x + 1 < bufferSize) setTopL(preProcBuffer[x + 1], res.blend_k); } } @@ -765,38 +579,41 @@ void scaleImage(const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, for (int x = 0; x < srcWidth; ++x, out += Scaler::scale) { #ifndef NDEBUG +#ifdef _MSC_VER breakIntoDebugger = debugPixelX == x && debugPixelY == y; +#endif #endif //all those bounds checks have only insignificant impact on performance! const int x_m1 = std::max(x - 1, 0); //perf: prefer array indexing to additional pointers! const int x_p1 = std::min(x + 1, srcWidth - 1); const int x_p2 = std::min(x + 2, srcWidth - 1); + Kernel_4x4 ker4 = {}; //perf: initialization is negligible + + ker4.a = s_m1[x_m1]; //read sequentially from memory as far as possible + ker4.b = s_m1[x]; + ker4.c = s_m1[x_p1]; + ker4.d = s_m1[x_p2]; + + ker4.e = s_0[x_m1]; + ker4.f = s_0[x]; + ker4.g = s_0[x_p1]; + ker4.h = s_0[x_p2]; + + ker4.i = s_p1[x_m1]; + ker4.j = s_p1[x]; + ker4.k = s_p1[x_p1]; + ker4.l = s_p1[x_p2]; + + ker4.m = s_p2[x_m1]; + ker4.n = s_p2[x]; + ker4.o = s_p2[x_p1]; + ker4.p = s_p2[x_p2]; + //evaluate the four corners on bottom-right of current pixel unsigned char blend_xy = 0; //for current (x, y) position { - Kernel_4x4 ker = {}; //perf: initialization is negligable - ker.a = s_m1[x_m1]; //read sequentially from memory as far as possible - ker.b = s_m1[x]; - ker.c = s_m1[x_p1]; - ker.d = s_m1[x_p2]; - - ker.e = s_0[x_m1]; - ker.f = s_0[x]; - ker.g = s_0[x_p1]; - ker.h = s_0[x_p2]; - - ker.i = s_p1[x_m1]; - ker.j = s_p1[x]; - ker.k = s_p1[x_p1]; - ker.l = s_p1[x_p2]; - - ker.m = s_p2[x_m1]; - ker.n = s_p2[x]; - ker.o = s_p2[x_p1]; - ker.p = s_p2[x_p2]; - - const BlendResult res = preProcessCorners(ker, cfg); + const BlendResult res = preProcessCorners(ker4, cfg); /* preprocessing blend result: --------- @@ -814,146 +631,162 @@ void scaleImage(const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, blend_xy1 = 0; setTopL(blend_xy1, res.blend_k); //set 1st known corner for (x + 1, y + 1) and buffer for use on next column - if (x + 1 < srcWidth) //set 3rd known corner for (x + 1, y) + if (x + 1 < bufferSize) //set 3rd known corner for (x + 1, y) setBottomL(preProcBuffer[x + 1], res.blend_g); } //fill block of size scale * scale with the given color - fillBlock(out, trgWidth * sizeof(uint32_t), s_0[x], Scaler::scale); //place *after* preprocessing step, to not overwrite the results while processing the the last pixel! + fillBlock(out, trgWidth * sizeof(uint32_t), ker4.f, Scaler::scale); //place *after* preprocessing step, to not overwrite the results while processing the the last pixel! //blend four corners of current pixel - if (blendingNeeded(blend_xy)) //good 20% perf-improvement + if (blendingNeeded(blend_xy)) //good 5% perf-improvement { - Kernel_3x3 ker = {}; //perf: initialization is negligable + Kernel_3x3 ker3 = {}; //perf: initialization is negligible - ker.a = s_m1[x_m1]; //read sequentially from memory as far as possible - ker.b = s_m1[x]; - ker.c = s_m1[x_p1]; + ker3.a = ker4.a; + ker3.b = ker4.b; + ker3.c = ker4.c; - ker.d = s_0[x_m1]; - ker.e = s_0[x]; - ker.f = s_0[x_p1]; + ker3.d = ker4.e; + ker3.e = ker4.f; + ker3.f = ker4.g; - ker.g = s_p1[x_m1]; - ker.h = s_p1[x]; - ker.i = s_p1[x_p1]; + ker3.g = ker4.i; + ker3.h = ker4.j; + ker3.i = ker4.k; - scalePixel(ker, out, trgWidth, blend_xy, cfg); - scalePixel(ker, out, trgWidth, blend_xy, cfg); - scalePixel(ker, out, trgWidth, blend_xy, cfg); - scalePixel(ker, out, trgWidth, blend_xy, cfg); + blendPixel(ker3, out, trgWidth, blend_xy, cfg); + blendPixel(ker3, out, trgWidth, blend_xy, cfg); + blendPixel(ker3, out, trgWidth, blend_xy, cfg); + blendPixel(ker3, out, trgWidth, blend_xy, cfg); } } } } +//------------------------------------------------------------------------------------ -struct Scaler2x +template +struct Scaler2x : public ColorGradient { static const int scale = 2; + template //bring template function into scope for GCC + static void alphaGrad(uint32_t& pixBack, uint32_t pixFront) { ColorGradient::template alphaGrad(pixBack, pixFront); } + + template static void blendLineShallow(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref(), col); - alphaBlend<3, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); + alphaGrad<3, 4>(out.template ref(), col); } template static void blendLineSteep(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref<0, scale - 1>(), col); - alphaBlend<3, 4>(out.template ref<1, scale - 1>(), col); + alphaGrad<1, 4>(out.template ref<0, scale - 1>(), col); + alphaGrad<3, 4>(out.template ref<1, scale - 1>(), col); } template static void blendLineSteepAndShallow(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref<1, 0>(), col); - alphaBlend<1, 4>(out.template ref<0, 1>(), col); - alphaBlend<5, 6>(out.template ref<1, 1>(), col); //[!] fixes 7/8 used in xBR + alphaGrad<1, 4>(out.template ref<1, 0>(), col); + alphaGrad<1, 4>(out.template ref<0, 1>(), col); + alphaGrad<5, 6>(out.template ref<1, 1>(), col); //[!] fixes 7/8 used in xBR } template static void blendLineDiagonal(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 2>(out.template ref<1, 1>(), col); + alphaGrad<1, 2>(out.template ref<1, 1>(), col); } template static void blendCorner(uint32_t col, OutputMatrix& out) { //model a round corner - alphaBlend<21, 100>(out.template ref<1, 1>(), col); //exact: 1 - pi/4 = 0.2146018366 + alphaGrad<21, 100>(out.template ref<1, 1>(), col); //exact: 1 - pi/4 = 0.2146018366 } }; -struct Scaler3x +template +struct Scaler3x : public ColorGradient { static const int scale = 3; + template //bring template function into scope for GCC + static void alphaGrad(uint32_t& pixBack, uint32_t pixFront) { ColorGradient::template alphaGrad(pixBack, pixFront); } + + template static void blendLineShallow(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref(), col); - alphaBlend<1, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); - alphaBlend<3, 4>(out.template ref(), col); + alphaGrad<3, 4>(out.template ref(), col); out.template ref() = col; } template static void blendLineSteep(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref<0, scale - 1>(), col); - alphaBlend<1, 4>(out.template ref<2, scale - 2>(), col); + alphaGrad<1, 4>(out.template ref<0, scale - 1>(), col); + alphaGrad<1, 4>(out.template ref<2, scale - 2>(), col); - alphaBlend<3, 4>(out.template ref<1, scale - 1>(), col); + alphaGrad<3, 4>(out.template ref<1, scale - 1>(), col); out.template ref<2, scale - 1>() = col; } template static void blendLineSteepAndShallow(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref<2, 0>(), col); - alphaBlend<1, 4>(out.template ref<0, 2>(), col); - alphaBlend<3, 4>(out.template ref<2, 1>(), col); - alphaBlend<3, 4>(out.template ref<1, 2>(), col); + alphaGrad<1, 4>(out.template ref<2, 0>(), col); + alphaGrad<1, 4>(out.template ref<0, 2>(), col); + alphaGrad<3, 4>(out.template ref<2, 1>(), col); + alphaGrad<3, 4>(out.template ref<1, 2>(), col); out.template ref<2, 2>() = col; } template static void blendLineDiagonal(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 8>(out.template ref<1, 2>(), col); - alphaBlend<1, 8>(out.template ref<2, 1>(), col); - alphaBlend<7, 8>(out.template ref<2, 2>(), col); + alphaGrad<1, 8>(out.template ref<1, 2>(), col); + alphaGrad<1, 8>(out.template ref<2, 1>(), col); + alphaGrad<7, 8>(out.template ref<2, 2>(), col); } template static void blendCorner(uint32_t col, OutputMatrix& out) { //model a round corner - alphaBlend<45, 100>(out.template ref<2, 2>(), col); //exact: 0.4545939598 - //alphaBlend<14, 1000>(out.template ref<2, 1>(), col); //0.01413008627 -> negligable - //alphaBlend<14, 1000>(out.template ref<1, 2>(), col); //0.01413008627 + alphaGrad<45, 100>(out.template ref<2, 2>(), col); //exact: 0.4545939598 + //alphaGrad<7, 256>(out.template ref<2, 1>(), col); //0.02826017254 -> negligible + avoid conflicts with other rotations for this odd scale + //alphaGrad<7, 256>(out.template ref<1, 2>(), col); //0.02826017254 } }; -struct Scaler4x +template +struct Scaler4x : public ColorGradient { static const int scale = 4; + template //bring template function into scope for GCC + static void alphaGrad(uint32_t& pixBack, uint32_t pixFront) { ColorGradient::template alphaGrad(pixBack, pixFront); } + + template static void blendLineShallow(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref(), col); - alphaBlend<1, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); - alphaBlend<3, 4>(out.template ref(), col); - alphaBlend<3, 4>(out.template ref(), col); + alphaGrad<3, 4>(out.template ref(), col); + alphaGrad<3, 4>(out.template ref(), col); out.template ref() = col; out.template ref() = col; @@ -962,11 +795,11 @@ struct Scaler4x template static void blendLineSteep(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref<0, scale - 1>(), col); - alphaBlend<1, 4>(out.template ref<2, scale - 2>(), col); + alphaGrad<1, 4>(out.template ref<0, scale - 1>(), col); + alphaGrad<1, 4>(out.template ref<2, scale - 2>(), col); - alphaBlend<3, 4>(out.template ref<1, scale - 1>(), col); - alphaBlend<3, 4>(out.template ref<3, scale - 2>(), col); + alphaGrad<3, 4>(out.template ref<1, scale - 1>(), col); + alphaGrad<3, 4>(out.template ref<3, scale - 2>(), col); out.template ref<2, scale - 1>() = col; out.template ref<3, scale - 1>() = col; @@ -975,19 +808,21 @@ struct Scaler4x template static void blendLineSteepAndShallow(uint32_t col, OutputMatrix& out) { - alphaBlend<3, 4>(out.template ref<3, 1>(), col); - alphaBlend<3, 4>(out.template ref<1, 3>(), col); - alphaBlend<1, 4>(out.template ref<3, 0>(), col); - alphaBlend<1, 4>(out.template ref<0, 3>(), col); - alphaBlend<1, 3>(out.template ref<2, 2>(), col); //[!] fixes 1/4 used in xBR - out.template ref<3, 3>() = out.template ref<3, 2>() = out.template ref<2, 3>() = col; + alphaGrad<3, 4>(out.template ref<3, 1>(), col); + alphaGrad<3, 4>(out.template ref<1, 3>(), col); + alphaGrad<1, 4>(out.template ref<3, 0>(), col); + alphaGrad<1, 4>(out.template ref<0, 3>(), col); + alphaGrad<1, 3>(out.template ref<2, 2>(), col); //[!] fixes 1/4 used in xBR + out.template ref<3, 3>() = col; + out.template ref<3, 2>() = col; + out.template ref<2, 3>() = col; } template static void blendLineDiagonal(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 2>(out.template ref(), col); - alphaBlend<1, 2>(out.template ref(), col); + alphaGrad<1, 2>(out.template ref(), col); + alphaGrad<1, 2>(out.template ref(), col); out.template ref() = col; } @@ -995,26 +830,31 @@ struct Scaler4x static void blendCorner(uint32_t col, OutputMatrix& out) { //model a round corner - alphaBlend<68, 100>(out.template ref<3, 3>(), col); //exact: 0.6848532563 - alphaBlend< 9, 100>(out.template ref<3, 2>(), col); //0.08677704501 - alphaBlend< 9, 100>(out.template ref<2, 3>(), col); //0.08677704501 + alphaGrad<68, 100>(out.template ref<3, 3>(), col); //exact: 0.6848532563 + alphaGrad< 9, 100>(out.template ref<3, 2>(), col); //0.08677704501 + alphaGrad< 9, 100>(out.template ref<2, 3>(), col); //0.08677704501 } }; -struct Scaler5x +template +struct Scaler5x : public ColorGradient { static const int scale = 5; + template //bring template function into scope for GCC + static void alphaGrad(uint32_t& pixBack, uint32_t pixFront) { ColorGradient::template alphaGrad(pixBack, pixFront); } + + template static void blendLineShallow(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref(), col); - alphaBlend<1, 4>(out.template ref(), col); - alphaBlend<1, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); - alphaBlend<3, 4>(out.template ref(), col); - alphaBlend<3, 4>(out.template ref(), col); + alphaGrad<3, 4>(out.template ref(), col); + alphaGrad<3, 4>(out.template ref(), col); out.template ref() = col; out.template ref() = col; @@ -1025,12 +865,12 @@ struct Scaler5x template static void blendLineSteep(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref<0, scale - 1>(), col); - alphaBlend<1, 4>(out.template ref<2, scale - 2>(), col); - alphaBlend<1, 4>(out.template ref<4, scale - 3>(), col); + alphaGrad<1, 4>(out.template ref<0, scale - 1>(), col); + alphaGrad<1, 4>(out.template ref<2, scale - 2>(), col); + alphaGrad<1, 4>(out.template ref<4, scale - 3>(), col); - alphaBlend<3, 4>(out.template ref<1, scale - 1>(), col); - alphaBlend<3, 4>(out.template ref<3, scale - 2>(), col); + alphaGrad<3, 4>(out.template ref<1, scale - 1>(), col); + alphaGrad<3, 4>(out.template ref<3, scale - 2>(), col); out.template ref<2, scale - 1>() = col; out.template ref<3, scale - 1>() = col; @@ -1041,13 +881,13 @@ struct Scaler5x template static void blendLineSteepAndShallow(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 4>(out.template ref<0, scale - 1>(), col); - alphaBlend<1, 4>(out.template ref<2, scale - 2>(), col); - alphaBlend<3, 4>(out.template ref<1, scale - 1>(), col); + alphaGrad<1, 4>(out.template ref<0, scale - 1>(), col); + alphaGrad<1, 4>(out.template ref<2, scale - 2>(), col); + alphaGrad<3, 4>(out.template ref<1, scale - 1>(), col); - alphaBlend<1, 4>(out.template ref(), col); - alphaBlend<1, 4>(out.template ref(), col); - alphaBlend<3, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); + alphaGrad<1, 4>(out.template ref(), col); + alphaGrad<3, 4>(out.template ref(), col); out.template ref<2, scale - 1>() = col; out.template ref<3, scale - 1>() = col; @@ -1057,18 +897,18 @@ struct Scaler5x out.template ref<4, scale - 1>() = col; - alphaBlend<2, 3>(out.template ref<3, 3>(), col); + alphaGrad<2, 3>(out.template ref<3, 3>(), col); } template static void blendLineDiagonal(uint32_t col, OutputMatrix& out) { - alphaBlend<1, 8>(out.template ref(), col); - alphaBlend<1, 8>(out.template ref(), col); - alphaBlend<1, 8>(out.template ref(), col); + alphaGrad<1, 8>(out.template ref(), col); + alphaGrad<1, 8>(out.template ref(), col); + alphaGrad<1, 8>(out.template ref(), col); - alphaBlend<7, 8>(out.template ref<4, 3>(), col); - alphaBlend<7, 8>(out.template ref<3, 4>(), col); + alphaGrad<7, 8>(out.template ref<4, 3>(), col); + alphaGrad<7, 8>(out.template ref<3, 4>(), col); out.template ref<4, 4>() = col; } @@ -1077,16 +917,74 @@ struct Scaler5x static void blendCorner(uint32_t col, OutputMatrix& out) { //model a round corner - alphaBlend<86, 100>(out.template ref<4, 4>(), col); //exact: 0.8631434088 - alphaBlend<23, 100>(out.template ref<4, 3>(), col); //0.2306749731 - alphaBlend<23, 100>(out.template ref<3, 4>(), col); //0.2306749731 - //alphaBlend<8, 1000>(out.template ref<4, 2>(), col); //0.008384061834 -> negligable - //alphaBlend<8, 1000>(out.template ref<2, 4>(), col); //0.008384061834 + alphaGrad<86, 100>(out.template ref<4, 4>(), col); //exact: 0.8631434088 + alphaGrad<23, 100>(out.template ref<4, 3>(), col); //0.2306749731 + alphaGrad<23, 100>(out.template ref<3, 4>(), col); //0.2306749731 + //alphaGrad<1, 64>(out.template ref<4, 2>(), col); //0.01676812367 -> negligible + avoid conflicts with other rotations for this odd scale + //alphaGrad<1, 64>(out.template ref<2, 4>(), col); //0.01676812367 + } +}; + +//------------------------------------------------------------------------------------ + +struct ColorDistanceRGB +{ + static double dist(uint32_t pix1, uint32_t pix2, double luminanceWeight) + { + return distYCbCrBuffer.dist(pix1, pix2); + + //if (pix1 == pix2) //about 4% perf boost + // return 0; + //return distYCbCr(pix1, pix2, luminanceWeight); + } +}; + +struct ColorDistanceARGB +{ + static double dist(uint32_t pix1, uint32_t pix2, double luminanceWeight) + { + const double a1 = getAlpha(pix1) / 255.0 ; + const double a2 = getAlpha(pix2) / 255.0 ; + /* + Requirements for a color distance handling alpha channel: with a1, a2 in [0, 1] + + 1. if a1 = a2, distance should be: a1 * distYCbCr() + 2. if a1 = 0, distance should be: a2 * distYCbCr(black, white) = a2 * 255 + 3. if a1 = 1, distance should be: 255 * (1 - a2) + a2 * distYCbCr() + */ + + //return std::min(a1, a2) * distYCbCrBuffer.dist(pix1, pix2) + 255 * abs(a1 - a2); + //=> following code is 15% faster: + const double d = distYCbCrBuffer.dist(pix1, pix2); + if (a1 < a2) + return a1 * d + 255 * (a2 - a1); + else + return a2 * d + 255 * (a1 - a2); + } +}; + + +struct ColorGradientRGB +{ + template + static void alphaGrad(uint32_t& pixBack, uint32_t pixFront) + { + pixBack = alphaGradRGB(pixFront, pixBack); + } +}; + +struct ColorGradientARGB +{ + template + static void alphaGrad(uint32_t& pixBack, uint32_t pixFront) + { + pixBack = alphaGradARGB(pixFront, pixBack); } }; } -void xbrz::scale(size_t factor, const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, uint32_t* trg, int trgPitch, const xbrz::ScalerCfg& cfg, int yFirst, int yLast) + +void xbrz::scale(size_t factor, const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, uint32_t* trg, int trgPitch, ColorFormat colFmt, const xbrz::ScalerCfg& cfg, int yFirst, int yLast) { if (srcPitch % static_cast(sizeof(uint32_t)) != 0 || trgPitch % static_cast(sizeof(uint32_t)) != 0 || @@ -1100,24 +998,52 @@ void xbrz::scale(size_t factor, const uint32_t* src, int srcWidth, int srcHeight int trgWidth = trgPitch / static_cast(sizeof(uint32_t)); int srcPPitch = srcPitch / static_cast(sizeof(uint32_t)); - switch (factor) + switch (colFmt) { - case 2: - return scaleImage(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); - case 3: - return scaleImage(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); - case 4: - return scaleImage(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); - case 5: - return scaleImage(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); + case ARGB: + switch (factor) + { + case 2: + return scaleImage, ColorDistanceARGB>(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); + case 3: + return scaleImage, ColorDistanceARGB>(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); + case 4: + return scaleImage, ColorDistanceARGB>(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); + case 5: + return scaleImage, ColorDistanceARGB>(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); + } + break; + + case RGB: + switch (factor) + { + case 2: + return scaleImage, ColorDistanceRGB>(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); + case 3: + return scaleImage, ColorDistanceRGB>(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); + case 4: + return scaleImage, ColorDistanceRGB>(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); + case 5: + return scaleImage, ColorDistanceRGB>(src, srcWidth, srcHeight, srcPPitch, trg, trgWidth, cfg, yFirst, yLast); + } + break; } assert(false); } -bool xbrz::equalColorTest(uint32_t col1, uint32_t col2, double luminanceWeight, double equalColorTolerance) +bool xbrz::equalColorTest(uint32_t col1, uint32_t col2, ColorFormat colFmt, double luminanceWeight, double equalColorTolerance) { - return equalColor(col1, col2, luminanceWeight, equalColorTolerance); + switch (colFmt) + { + case ARGB: + return ColorDistanceARGB::dist(col1, col2, luminanceWeight) < equalColorTolerance; + + case RGB: + return ColorDistanceRGB::dist(col1, col2, luminanceWeight) < equalColorTolerance; + } + assert(false); + return false; } diff --git a/src/filters/xBRZ/xbrz.h b/src/filters/xBRZ/xbrz.h index aad5f099..2e6d0735 100644 --- a/src/filters/xBRZ/xbrz.h +++ b/src/filters/xBRZ/xbrz.h @@ -1,6 +1,6 @@ // **************************************************************************** // * This file is part of the HqMAME project. It is distributed under * -// * GNU General Public License: http://www.gnu.org/licenses/gpl.html * +// * GNU General Public License: http://www.gnu.org/licenses/gpl-3.0 * // * Copyright (C) Zenju (zenju AT gmx DOT de) - All Rights Reserved * // * * // * Additionally and as a special exception, the author gives permission * @@ -30,26 +30,34 @@ namespace xbrz using a modified approach of xBR: http://board.byuu.org/viewtopic.php?f=10&t=2248 - new rule set preserving small image features +- highly optimized for performance +- support alpha channel - support multithreading -- support 64 bit architectures +- support 64-bit architectures - support processing image slices */ +enum ColorFormat //from high bits -> low bits, 8 bit per channel +{ + ARGB, //including alpha channel, BGRA byte order on little-endian machines + RGB, //8 bit for each red, green, blue, upper 8 bits unused +}; + /* -> map source (srcWidth * srcHeight) to target (scale * width x scale * height) image, optionally processing a half-open slice of rows [yFirst, yLast) only --> color format: ARGB (BGRA byte order), alpha channel unused -> support for source/target pitch in bytes! -> if your emulator changes only a few image slices during each cycle (e.g. DOSBox) then there's no need to run xBRZ on the complete image: Just make sure you enlarge the source image slice by 2 rows on top and 2 on bottom (this is the additional range the xBRZ algorithm is using during analysis) - Caveat: If there are multiple changed slices, make sure they do not overlap after adding these additional rows in order to avoid a memory race condition + Caveat: If there are multiple changed slices, make sure they do not overlap after adding these additional rows in order to avoid a memory race condition in the target image data if you are using multiple threads for processing each enlarged slice! THREAD-SAFETY: - parts of the same image may be scaled by multiple threads as long as the [yFirst, yLast) ranges do not overlap! - - there is a minor inefficiency for the first row of a slice, so avoid processing single rows only + - there is a minor inefficiency for the first row of a slice, so avoid processing single rows only; suggestion: process 6 rows at least */ void scale(size_t factor, //valid range: 2 - 5 const uint32_t* src, int srcWidth, int srcHeight, int srcPitch, uint32_t* trg, int trgPitch, + ColorFormat colFmt, const ScalerCfg& cfg = ScalerCfg(), int yFirst = 0, int yLast = std::numeric_limits::max()); //slice of source image @@ -66,7 +74,7 @@ void nearestNeighborScale(const uint32_t* src, int srcWidth, int srcHeight, int SliceType st, int yFirst, int yLast); //parameter tuning -bool equalColorTest(uint32_t col1, uint32_t col2, double luminanceWeight, double equalColorTolerance); +bool equalColorTest(uint32_t col1, uint32_t col2, ColorFormat colFmt, double luminanceWeight, double equalColorTolerance); diff --git a/src/filters/xbrzfilter.cpp b/src/filters/xbrzfilter.cpp index 03f8d132..63d4cfa5 100644 --- a/src/filters/xbrzfilter.cpp +++ b/src/filters/xbrzfilter.cpp @@ -1,23 +1,23 @@ -#include "../System.h" - -#include "xBRZ/xbrz.h" - -void xbrz2x32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */, u8 *dstPtr, u32 dstPitch, int width, int height) -{ - xbrz::scale(2, (const uint32_t *)srcPtr, width, height, srcPitch, (uint32_t *)dstPtr, dstPitch); -} - -void xbrz3x32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */, u8 *dstPtr, u32 dstPitch, int width, int height) -{ - xbrz::scale(3, (const uint32_t *)srcPtr, width, height, srcPitch, (uint32_t *)dstPtr, dstPitch); -} - -void xbrz4x32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */, u8 *dstPtr, u32 dstPitch, int width, int height) -{ - xbrz::scale(4, (const uint32_t *)srcPtr, width, height, srcPitch, (uint32_t *)dstPtr, dstPitch); -} - -void xbrz5x32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */, u8 *dstPtr, u32 dstPitch, int width, int height) -{ - xbrz::scale(5, (const uint32_t *)srcPtr, width, height, srcPitch, (uint32_t *)dstPtr, dstPitch); -} +#include "../System.h" + +#include "xBRZ/xbrz.h" + +void xbrz2x32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */, u8 *dstPtr, u32 dstPitch, int width, int height) +{ + xbrz::scale(2, (const uint32_t *)srcPtr, width, height, srcPitch, (uint32_t *)dstPtr, dstPitch, xbrz::RGB); +} + +void xbrz3x32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */, u8 *dstPtr, u32 dstPitch, int width, int height) +{ + xbrz::scale(3, (const uint32_t *)srcPtr, width, height, srcPitch, (uint32_t *)dstPtr, dstPitch, xbrz::RGB); +} + +void xbrz4x32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */, u8 *dstPtr, u32 dstPitch, int width, int height) +{ + xbrz::scale(4, (const uint32_t *)srcPtr, width, height, srcPitch, (uint32_t *)dstPtr, dstPitch, xbrz::RGB); +} + +void xbrz5x32(u8 *srcPtr, u32 srcPitch, u8 * /* deltaPtr */, u8 *dstPtr, u32 dstPitch, int width, int height) +{ + xbrz::scale(5, (const uint32_t *)srcPtr, width, height, srcPitch, (uint32_t *)dstPtr, dstPitch, xbrz::RGB); +}