ShuriZma
/
visualboyadvance-m
mirror of https://github.com/visualboyadvance-m/visualboyadvance-m.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MSVC opt /fp:fast /Oi, intrinsic sqrt() w/ XBRZ. 

For MSVC, add the optimization flags:

/fp:fast /Oi

, to favor speed for floating point operations and use intrinsic
operations where possible.

For release builds also add:

/O2

. Use sqrt() instead of std::sqrt() in XBRZ for MSVC x64 just in case to
make sure it uses the intrinsic version.

Test build is reported to run much faster.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>
This commit is contained in:
Rafael Kitover 2022-01-16 15:55:02 +00:00
parent 2eb45cd967
commit 73223445d6
No known key found for this signature in database
GPG Key ID: 08AB596679D86240
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CMakeLists.txt
View File

@ -744,12 +744,12 @@ elseif(MSVC)
string(REGEX REPLACE "/[Ww][^ ]+" "" CMAKE_C_FLAGS ${CMAKE_C_FLAGS}) string(REGEX REPLACE "/[Ww][^ ]+" "" CMAKE_C_FLAGS ${CMAKE_C_FLAGS})
string(REGEX REPLACE "/[Ww][^ ]+" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) string(REGEX REPLACE "/[Ww][^ ]+" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
add_compile_options(/std:c++17 -D__STDC_LIMIT_MACROS) add_compile_options(/std:c++17 -D__STDC_LIMIT_MACROS /fp:fast /Oi)
if(CMAKE_BUILD_TYPE STREQUAL Debug) if(CMAKE_BUILD_TYPE STREQUAL Debug)
add_compile_options(/W4) add_compile_options(/W4)
else() else()
add_compile_options(/w) add_compile_options(/w /O2)
if(ENABLE_LTO) if(ENABLE_LTO)
add_compile_options(/GL) add_compile_options(/GL)

6
src/filters/xBRZ/xbrz.cpp
View File

@ -76,8 +76,10 @@ inline double fastSqrt(double n)
fld n fld n
fsqrt fsqrt
} }
#else // defined(_MSC_VER) && defined(_M_X64) OR other platforms #elif defined(_MSC_VER)
// VisualStudio x86_64 does not allow inline ASM // On MSVC x64 use intrinsic with /Oi and /fp:fast
return sqrt(n);
#else // Other platforms.
return std::sqrt(n); return std::sqrt(n);
#endif #endif
} }