From 4104a3d17975c401e3fe828549944522aa629e41 Mon Sep 17 00:00:00 2001 From: Rafael Kitover Date: Sat, 6 Apr 2024 23:45:14 +0000 Subject: [PATCH] build: fix codesigning Windows bins with signtool Pass `/fd certHash /td certHash` to signtool as they are required arguments. signtool comes with Visual Studio and now works and we don't need to require osslsigncode anymore. Signed-off-by: Rafael Kitover --- src/wx/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wx/CMakeLists.txt b/src/wx/CMakeLists.txt index 2360138f..4b961c36 100644 --- a/src/wx/CMakeLists.txt +++ b/src/wx/CMakeLists.txt @@ -775,7 +775,7 @@ if(UPSTREAM_RELEASE AND WIN32) TARGET visualboyadvance-m POST_BUILD COMMAND ${CMAKE_COMMAND} -E copy visualboyadvance-m.exe visualboyadvance-m-unsigned.exe - COMMAND ${SIGNTOOL_PROGRAM} sign /f ${cert} /p "vbam3!13" /tr http://timestamp.digicert.com /du https://github.com/visualboyadvance-m/visualboyadvance-m /a visualboyadvance-m.exe + COMMAND ${SIGNTOOL_PROGRAM} sign /f ${cert} /fd certHash /td certHash /p "vbam3!13" /tr http://timestamp.digicert.com /du https://github.com/visualboyadvance-m/visualboyadvance-m /a visualboyadvance-m.exe WORKING_DIRECTORY ${CMAKE_BINARY_DIR} ) endif()