From 2ad204619bf28489bb1c91d5c0cf18c4e5885685 Mon Sep 17 00:00:00 2001
From: Rafael Kitover <rkitover@gmail.com>
Date: Fri, 1 Sep 2017 21:51:24 -0700
Subject: [PATCH] compile/run test to detect Wx ABI version #142

In 4e665ae I hardcoded -fabi-version=2 for g++ flags, and @ArtiiP
pointed out that this is wrong, because Wx may be compiled with other
ABI versions.

Add cmake check_cxx_source_runs() tests to determine the correct ABI
version flag to use with Wx.
---
 CMakeLists.txt        |  4 ----
 src/wx/CMakeLists.txt | 51 ++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 50 insertions(+), 5 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 97500641..6603297d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -367,10 +367,6 @@ IF(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID STREQUAL Clang)
 
     SET(MY_CXX_FLAGS -std=gnu++11 -fpermissive -fexceptions)
 
-    IF(CMAKE_COMPILER_IS_GNUCXX)
-        SET(MY_CXX_FLAGS ${MY_CXX_FLAGS} -fabi-version=2)
-    ENDIF()
-
     FOREACH(ARG ${MY_CXX_FLAGS})
         SET(MY_CXX_FLAGS_STR "${MY_CXX_FLAGS_STR} ${ARG}")
     ENDFOREACH()
diff --git a/src/wx/CMakeLists.txt b/src/wx/CMakeLists.txt
index 552d27f9..e13ad026 100644
--- a/src/wx/CMakeLists.txt
+++ b/src/wx/CMakeLists.txt
@@ -107,7 +107,56 @@ IF(NOT WX_HAS_OPENGL)
     FIND_PACKAGE(wxWidgets REQUIRED)
 ENDIF()
 
-# end of wx OpenGL check
+IF(CMAKE_COMPILER_IS_GNUCXX)
+    INCLUDE(CheckCXXSourceRuns)
+
+    UNSET(WX_ABI_MATCHES)
+    SET(WX_ABI_VERSION 1)
+
+    SET(CURRENT_DEFS ${CMAKE_REQUIRED_DEFINITIONS})
+    SET(CURRENT_LIBS ${CMAKE_REQUIRED_LIBRARIES})
+
+    # currently goes up to 11 with gcc7, but we give it some room
+    WHILE(NOT WX_ABI_VERSION GREATER 15)
+        SET(CMAKE_REQUIRED_DEFINITIONS ${CURRENT_DEFS} "-fabi-version=${WX_ABI_VERSION}")
+        SET(CMAKE_REQUIRED_LIBRARIES   ${CURRENT_LIBS} "-fabi-version=${WX_ABI_VERSION}")
+
+        SET(WX_ABI_VAR "WX_ABI_VERSION_${WX_ABI_VERSION}")
+
+        CHECK_CXX_SOURCE_RUNS("
+#include <cstdlib>
+#include <wx/wx.h>
+
+class MyApp : public wxAppConsole {
+public:
+    virtual bool OnInit();
+};
+
+bool MyApp::OnInit() {
+    exit(0);
+}
+
+wxIMPLEMENT_APP(MyApp);
+" ${WX_ABI_VAR})
+
+        IF(${${WX_ABI_VAR}})
+            BREAK()
+        ENDIF()
+
+        MATH(EXPR WX_ABI_VERSION "${WX_ABI_VERSION} + 1")
+    ENDWHILE()
+
+    SET(CMAKE_REQUIRED_DEFINITIONS ${CURRENT_DEFS})
+    SET(CMAKE_REQUIRED_LIBRARIES   ${CURRENT_LIBS})
+
+    IF(${${WX_ABI_VAR}})
+        # add C++ flags
+        STRING(REGEX REPLACE "<FLAGS>" "<FLAGS> -fabi-version=${WX_ABI_VERSION} " CMAKE_CXX_COMPILE_OBJECT ${CMAKE_CXX_COMPILE_OBJECT})
+        SET(CMAKE_CXX_LINK_EXECUTABLE "${CMAKE_CXX_LINK_EXECUTABLE} -fabi-version=${WX_ABI_VERSION}")
+    ENDIF()
+ENDIF()
+
+# end of wx compile checks
 
 FOREACH(CXX_COMPILE_FLAG ${wxWidgets_CXX_FLAGS})
     ADD_COMPILE_OPTIONS(${CXX_COMPILE_FLAG})