ShuriZma
/
visualboyadvance-m
mirror of https://github.com/visualboyadvance-m/visualboyadvance-m.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clean up GB MBC30 check. 

Based on feedback from @negativeExponent.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>
This commit is contained in:
Rafael Kitover 2020-09-04 17:33:25 +00:00
parent 2727f683f1
commit 11693d8381
No known key found for this signature in database
GPG Key ID: 08AB596679D86240
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/gb/gbMemory.cpp
View File

@ -362,13 +362,8 @@ void mapperMBC3ROM(uint16_t address, uint8_t value)
gbDataMBC3.mapperRAMEnable = ((value & 0x0a) == 0x0a ? 1 : 0); gbDataMBC3.mapperRAMEnable = ((value & 0x0a) == 0x0a ? 1 : 0);
break; break;
case 0x2000: { // ROM bank select case 0x2000: { // ROM bank select
// 4MiB, MBC30 if (gbRomSize != 0x00400000)
bool mbc30 = gbRomSize == 0x00400000; value = value & 0x7f; // Assume 2MiB, unless MBC30.
if (mbc30)
value = value & 0xff; // 4MiB
else
value = value & 0x7f; // 2MiB
if (value == 0) if (value == 0)
value = 1; value = 1;