ShuriZma
/
suyu
mirror of https://git.suyu.dev/suyu/suyu
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Clamp string reads to buffer size

This commit is contained in:
Chloe Marcec 2021-01-23 18:24:57 +11:00
parent dc18a1261c
commit df42100320
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/hle/service/lm/lm.cpp
View File

@ -162,9 +162,11 @@ private:
if (length == 0) { if (length == 0) {
return std::nullopt; return std::nullopt;
} }
std::string output(length, '\0'); const auto length_to_read = std::min(length, data.size() - offset);
std::memcpy(output.data(), data.data() + offset, length);
offset += length; std::string output(length_to_read, '\0');
std::memcpy(output.data(), data.data() + offset, length_to_read);
offset += length_to_read;
return output; return output;
} }