mirror of https://git.suyu.dev/suyu/suyu
core/debugger: Define defaulted virtual destructors
Resolves an MSVC warning where a virtual destructor is not defined in the base class with virtual functions.
This commit is contained in:
parent
de2f2e5140
commit
69511aed3d
|
@ -50,7 +50,7 @@ public:
|
||||||
InitializeServer(port);
|
InitializeServer(port);
|
||||||
}
|
}
|
||||||
|
|
||||||
~DebuggerImpl() {
|
~DebuggerImpl() override {
|
||||||
ShutdownServer();
|
ShutdownServer();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -24,6 +24,8 @@ enum class DebuggerAction {
|
||||||
|
|
||||||
class DebuggerBackend {
|
class DebuggerBackend {
|
||||||
public:
|
public:
|
||||||
|
virtual ~DebuggerBackend() = default;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Can be invoked from a callback to synchronously wait for more data.
|
* Can be invoked from a callback to synchronously wait for more data.
|
||||||
* Will return as soon as least one byte is received. Reads up to 4096 bytes.
|
* Will return as soon as least one byte is received. Reads up to 4096 bytes.
|
||||||
|
@ -51,6 +53,8 @@ class DebuggerFrontend {
|
||||||
public:
|
public:
|
||||||
explicit DebuggerFrontend(DebuggerBackend& backend_) : backend{backend_} {}
|
explicit DebuggerFrontend(DebuggerBackend& backend_) : backend{backend_} {}
|
||||||
|
|
||||||
|
virtual ~DebuggerFrontend() = default;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Called after the client has successfully connected to the port.
|
* Called after the client has successfully connected to the port.
|
||||||
*/
|
*/
|
||||||
|
|
|
@ -19,7 +19,7 @@ class System;
|
||||||
class GDBStub : public DebuggerFrontend {
|
class GDBStub : public DebuggerFrontend {
|
||||||
public:
|
public:
|
||||||
explicit GDBStub(DebuggerBackend& backend, Core::System& system);
|
explicit GDBStub(DebuggerBackend& backend, Core::System& system);
|
||||||
~GDBStub();
|
~GDBStub() override;
|
||||||
|
|
||||||
void Connected() override;
|
void Connected() override;
|
||||||
void Stopped(Kernel::KThread* thread) override;
|
void Stopped(Kernel::KThread* thread) override;
|
||||||
|
|
Loading…
Reference in New Issue