ShuriZma
/
stella
mirror of https://github.com/stella-emu/stella.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

removed magic number in WhatsNewDialog

This commit is contained in:
thrust26 2020-07-29 10:57:44 +02:00
parent 6887722448
commit fae33a71b5
2 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/gui/WhatsNewDialog.cxx
View File

@ -19,6 +19,8 @@
#include "WhatsNewDialog.hxx" #include "WhatsNewDialog.hxx"
constexpr int MAX_CHARS = 64; // maximum number of chars per line
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
WhatsNewDialog::WhatsNewDialog(OSystem& osystem, DialogContainer& parent, const GUI::Font& font, WhatsNewDialog::WhatsNewDialog(OSystem& osystem, DialogContainer& parent, const GUI::Font& font,
int max_w, int max_h) int max_w, int max_h)
@ -35,7 +37,7 @@ WhatsNewDialog::WhatsNewDialog(OSystem& osystem, DialogContainer& parent, const
// Set preliminary dimensions // Set preliminary dimensions
setSize(64 * fontWidth + HBORDER * 2, max_h, setSize(MAX_CHARS * fontWidth + HBORDER * 2, max_h,
max_w, max_h); max_w, max_h);
add(ypos, "added autofire"); add(ypos, "added autofire");
@ -50,7 +52,7 @@ WhatsNewDialog::WhatsNewDialog(OSystem& osystem, DialogContainer& parent, const
add(ypos, "fixed bug when taking fullscreen snapshots; the dimensions were sometimes cut"); add(ypos, "fixed bug when taking fullscreen snapshots; the dimensions were sometimes cut");
// Set needed dimensions // Set needed dimensions
setSize(64 * fontWidth + HBORDER * 2, setSize(MAX_CHARS * fontWidth + HBORDER * 2,
ypos + VGAP + buttonHeight + VBORDER, ypos + VGAP + buttonHeight + VBORDER,
max_w, max_h); max_w, max_h);
@ -74,9 +76,9 @@ void WhatsNewDialog::add(int& ypos, const string& text)
string txt = DOT + " " + text; string txt = DOT + " " + text;
// automatically wrap too long texts // automatically wrap too long texts
while(txt.length() > 64) while(txt.length() > MAX_CHARS)
{ {
int i = 64; int i = MAX_CHARS;
while(--i && txt[i] != ' '); while(--i && txt[i] != ' ');
new StaticTextWidget(this, _font, HBORDER, ypos, txt.substr(0, i)); new StaticTextWidget(this, _font, HBORDER, ypos, txt.substr(0, i));

7
src/gui/WhatsNewDialog.hxx
View File

@ -22,13 +22,6 @@
class WhatsNewDialog : public Dialog class WhatsNewDialog : public Dialog
{ {
public:
// These must be accessible from dialogs created by this class
enum {
kLoadROMCmd = 'STRT', // load currently selected ROM
kRomDirChosenCmd = 'romc' // rom dir chosen
};
public: public:
WhatsNewDialog(OSystem& osystem, DialogContainer& parent, const GUI::Font& font, WhatsNewDialog(OSystem& osystem, DialogContainer& parent, const GUI::Font& font,
int max_w, int max_h); int max_w, int max_h);