ShuriZma
/
stella
mirror of https://github.com/stella-emu/stella.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

improved detection of unchanged ystart and height

This commit is contained in:
thrust26 2018-09-14 19:25:51 +02:00
parent 02b0c13aca
commit f0889a26dd
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/gui/GameInfoDialog.cxx
View File

@ -531,6 +531,11 @@ void GameInfoDialog::saveConfig()
myGameProperties.set(Controller_MouseAxis, mcontrol); myGameProperties.set(Controller_MouseAxis, mcontrol);
// Display properties // Display properties
const string& ystart = myGameProperties.get(Display_YStart);
uInt32 oldYStart = atoi(ystart.c_str());
const string& height = myGameProperties.get(Display_Height);
uInt32 oldHeight = atoi(height.c_str());
myGameProperties.set(Display_Format, myFormat->getSelectedTag().toString()); myGameProperties.set(Display_Format, myFormat->getSelectedTag().toString());
myGameProperties.set(Display_YStart, myYStart->getValueLabel() == "Auto" ? "0" : myGameProperties.set(Display_YStart, myYStart->getValueLabel() == "Auto" ? "0" :
myYStart->getValueLabel()); myYStart->getValueLabel());
@ -557,15 +562,17 @@ void GameInfoDialog::saveConfig()
instance().console().switches().setRightDifficultyA(myRightDiffGroup->getSelected() == 0); instance().console().switches().setRightDifficultyA(myRightDiffGroup->getSelected() == 0);
// update 'Display' tab settings immediately // update 'Display' tab settings immediately
bool reset = false;
instance().console().setFormat(myFormat->getSelected()); instance().console().setFormat(myFormat->getSelected());
if(uInt32(myYStart->getValue()) != instance().console().tia().ystart())
// only call tia().reset() when values have changed
bool reset = false;
if(uInt32((myYStart->getValue()) != 0 || oldYStart != 0) &&
uInt32(myYStart->getValue()) != instance().console().tia().ystart())
{ {
instance().console().updateYStart(myYStart->getValue()); instance().console().updateYStart(myYStart->getValue());
reset = true; reset = true;
} }
if(uInt32((myHeight->getValue()) != TIAConstants::minViewableHeight - 1 || oldHeight != 0) &&
if(/*uInt32(myHeight->getValue()) != TIAConstants::minViewableHeight - 1 &&*/
uInt32(myHeight->getValue()) != instance().console().tia().height()) uInt32(myHeight->getValue()) != instance().console().tia().height())
{ {
instance().console().tia().setHeight(myHeight->getValue()); instance().console().tia().setHeight(myHeight->getValue());