More fixes from cppcheck.

This commit is contained in:
Stephen Anthony 2018-08-29 08:55:07 -02:30
parent 6093bf8375
commit dc4fc5c8d2
4 changed files with 4 additions and 4 deletions

View File

@ -84,7 +84,7 @@ class LinkedObjectPool
iter it = myCurrent; iter it = myCurrent;
uInt32 idx = 1; uInt32 idx = 1;
while(it-- != myList.begin()) idx++; while(it-- != myList.begin()) ++idx;
return idx; return idx;
} }

View File

@ -33,7 +33,7 @@ class SettingsMACOSX : public Settings
/** /**
Create a new UNIX settings object Create a new UNIX settings object
*/ */
SettingsMACOSX(OSystem& osystem); explicit SettingsMACOSX(OSystem& osystem);
virtual ~SettingsMACOSX() = default; virtual ~SettingsMACOSX() = default;
public: public:

View File

@ -55,7 +55,7 @@ class FilesystemNodeWINDOWS : public AbstractFSNode
* *
* @param path String with the path the new node should point to. * @param path String with the path the new node should point to.
*/ */
FilesystemNodeWINDOWS(const string& path); explicit FilesystemNodeWINDOWS(const string& path);
bool exists() const override; bool exists() const override;
const string& getName() const override { return _displayName; } const string& getName() const override { return _displayName; }

View File

@ -28,7 +28,7 @@ class SettingsWINDOWS : public Settings
/** /**
Create a new UNIX settings object Create a new UNIX settings object
*/ */
SettingsWINDOWS(OSystem& osystem); explicit SettingsWINDOWS(OSystem& osystem);
virtual ~SettingsWINDOWS() = default; virtual ~SettingsWINDOWS() = default;
private: private: