Revert "Fix for suggestion from clang-tidy."

This reverts commit 9bd2f3e4f6.

src/common/bspf.hxx

@@ -244,7 +244,7 @@ namespace BSPF
   // starting from 'startpos' in the first string
   static size_t findIgnoreCase(string_view s1, string_view s2, size_t startpos = 0)
   {
-    const auto* pos = std::search(s1.cbegin()+startpos, s1.cend(),
+    auto pos = std::search(s1.cbegin()+startpos, s1.cend(),
       s2.cbegin(), s2.cend(), [](char ch1, char ch2) {
         return toupper(uInt8(ch1)) == toupper(uInt8(ch2));
       });