this should be working

This commit is contained in:
thrust26 2017-10-07 18:25:56 +02:00
parent f862e1c97d
commit c6593e6c58
6 changed files with 202 additions and 141 deletions

View File

@ -368,7 +368,7 @@ bool Debugger::breakPoint(uInt16 bp)
return breakPoints().isSet(bp);
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
/*// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
void Debugger::toggleReadTrap(uInt16 t)
{
readTraps().initialize();
@ -387,7 +387,7 @@ void Debugger::toggleTrap(uInt16 t)
{
toggleReadTrap(t);
toggleWriteTrap(t);
}
}*/
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
void Debugger::addReadTrap(uInt16 t)
@ -409,6 +409,26 @@ void Debugger::addTrap(uInt16 t)
addWriteTrap(t);
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
void Debugger::removeReadTrap(uInt16 t)
{
readTraps().initialize();
readTraps().remove(t);
}
void Debugger::removeWriteTrap(uInt16 t)
{
writeTraps().initialize();
writeTraps().remove(t);
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
void Debugger::removeTrap(uInt16 t)
{
removeReadTrap(t);
removeWriteTrap(t);
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
bool Debugger::readTrap(uInt16 t)
{

View File

@ -258,19 +258,17 @@ class Debugger : public DialogContainer
void toggleBreakPoint(uInt16 bp);
bool breakPoint(uInt16 bp);
void toggleReadTrap(uInt16 t);
/*void toggleReadTrap(uInt16 t);
void toggleWriteTrap(uInt16 t);
void toggleTrap(uInt16 t);
void toggleTrap(uInt16 t);*/
void addReadTrap(uInt16 t);
void addWriteTrap(uInt16 t);
void addTrap(uInt16 t);
void removeReadTrap(uInt16 t);
void removeWriteTrap(uInt16 t);
void removeTrap(uInt16 t);
bool readTrap(uInt16 t);
bool writeTrap(uInt16 t);
/*void toggleReadTrapIf(uInt16 t);
void toggleWriteTrapIf(uInt16 t);
void toggleTrapIf(uInt16 t);
bool readTrapIf(uInt16 t);
bool writeTrapIf(uInt16 t);*/
void clearAllTraps();
// Set a bunch of RAM locations at once

View File

@ -542,7 +542,7 @@ string DebuggerParser::eval()
return buf.str();
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
/*// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
string DebuggerParser::trapStatus(uInt32 addr, bool& enabled)
{
string result;
@ -568,7 +568,7 @@ string DebuggerParser::trapStatus(uInt32 addr, bool& enabled)
}
return result;
}
}*/
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
bool DebuggerParser::saveScriptFile(string file)
@ -591,7 +591,7 @@ bool DebuggerParser::saveScriptFile(string file)
for(uInt32 i = 0; i < 0x10000; ++i)
{
bool r = debugger.readTrap(i); // TODO trapif
bool r = debugger.readTrap(i);
bool w = debugger.writeTrap(i);
if(r && w)
@ -744,10 +744,8 @@ void DebuggerParser::executeClearconfig()
// "cleartraps"
void DebuggerParser::executeCleartraps()
{
myTraps.clear();
myTrapIfs.clear(); // TODO trapif
debugger.clearAllTraps();
//debugger.cpuDebug().m6502().clearCondTraps();
debugger.cpuDebug().m6502().clearCondTraps();
commandResult << "all traps cleared";
}
@ -864,11 +862,20 @@ void DebuggerParser::executeDelfunction()
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// "deltrapif"
void DebuggerParser::executeDeltrapif()
// "deltrap"
void DebuggerParser::executeDeltrap()
{
//debugger.cpuDebug().m6502().delCondTrap(args[0]);
// TODO trapif
int index = args[0];
if(debugger.cpuDebug().m6502().delCondTrap(index))
{
for(uInt32 addr = myTraps[index]->begin; addr <= myTraps[index]->end; ++addr)
executeTrapRW(addr, myTraps[index]->read, myTraps[index]->write, false);
Vec::removeAt(myTraps, index);
commandResult << "removed trap " << Base::toString(index);
}
else
commandResult << "no such trap";
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
@ -1099,7 +1106,7 @@ void DebuggerParser::executeListbreaks()
commandResult << "\nbreakifs:\n";
for(uInt32 i = 0; i < conds.size(); i++)
{
commandResult << i << ": " << conds[i];
commandResult << Base::toString(i) << ": " << conds[i];
if(i != (conds.size() - 1)) commandResult << endl;
}
}
@ -1137,42 +1144,20 @@ void DebuggerParser::executeListfunctions()
// "listtraps"
void DebuggerParser::executeListtraps()
{
if(myTraps.size() > 0)
StringList names = debugger.cpuDebug().m6502().getCondTrapNames();
if (names.size() > 0)
{
commandResult << "traps:\n";
bool enabled = true;
uInt32 i = 0;
for(const auto& trap: myTraps)
for(uInt32 i = 0; i < names.size(); i++)
{
commandResult << trapStatus(trap, enabled) << " + mirrors";
if(i != (myTraps.size() - 1)) commandResult << endl;
i++;
commandResult << Base::toString(i) << ": " << names[i];
commandResult << "|" << Base::toString(myTraps[i]->begin) << Base::toString(myTraps[i]->end);
if(i != (names.size() - 1)) commandResult << endl;
}
}
// TODO trapif
/*if(myTrapIfs.size() > 0)
{
StringList conds = debugger.cpuDebug().m6502().getCondTrapNames();
commandResult << "trapifs:\n";
if(myTrapIfs.size() != conds.size())
{
// should never happen
commandResult << "ERROR! trapif condition size != address ranges size";
return;
}
bool enabled = true;
uInt32 i = 0;
for(const auto& trap : myTrapIfs)
{
commandResult << i << ": " << conds[i] << ", ";
//commandResult << trapStatus(trap.address, enabled, true) << " + mirrors";
if(i != (myTrapIfs.size() - 1)) commandResult << endl;
i++;
}
}*/
if(myTraps.size() == 0 && myTrapIfs.size() == 0)
else
commandResult << "no traps set";
}
@ -1521,99 +1506,154 @@ void DebuggerParser::executeTrace()
// "trap"
void DebuggerParser::executeTrap()
{
executeTraps(true, true);
executeTraps(true, true, "trap");
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// "trapif"
void DebuggerParser::executeTrapif()
{
executeTraps(true, true, true, "trapif");
executeTraps(true, true, "trapif", true);
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// "trapread"
void DebuggerParser::executeTrapread()
{
executeTraps(true, false);
executeTraps(true, false, "trapread");
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// "trapreadif"
void DebuggerParser::executeTrapreadif()
{
executeTraps(true, false, true, "trapreadif");
executeTraps(true, false, "trapreadif", true);
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// "trapwrite"
void DebuggerParser::executeTrapwrite()
{
executeTraps(false, true);
executeTraps(false, true, "trapwrite");
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// "trapwriteif"
void DebuggerParser::executeTrapwriteif()
{
executeTraps(false, true, true, "trapwriteif");
executeTraps(false, true, "trapwriteif", true);
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// Wrapper function for trap(if)s
void DebuggerParser::executeTraps(bool read, bool write, bool cond, string command)
void DebuggerParser::executeTraps(bool read, bool write, string command, bool hasCond)
{
int ofs = cond ? 1 : 0;
if(argCount > ofs + 2)
if(hasCond)
{
commandResult << (cond ? red("Command takes two or three arguments") : red("Command takes one or two arguments")) << endl;
return;
if(argCount < 1 || argCount > 3)
{
commandResult << red("Command takes one to three arguments") << endl;
return;
}
}
else
{
if(argCount > 2)
{
commandResult << red("Command takes one or two arguments") << endl;
return;
}
}
int ofs = hasCond ? 1 : 0;
uInt32 beg = args[ofs];
uInt32 end = argCount == ofs + 2 ? args[ofs + 1] : beg;
if(cond)
{
// create: (condition) && (_lastread >= f000 && _lastread <= f100)
// add address range condition(s) to provided condition
stringstream buf;
buf << "(" << argStrings[0] << ")&&(";
if(read)
buf << "_lastread>=" << Base::toString(beg) << "&&_lastread<=" << Base::toString(end);
if (read && write)
buf << "||";
if (write)
buf << "_lastwrite>=" << Base::toString(beg) << "&&_lastwrite<=" << Base::toString(end);
buf << ")";
string condition = buf.str();
//int res = YaccParser::parse(argStrings[0].c_str());
int res = YaccParser::parse(condition.c_str());
if(res == 0)
{
uInt32 ret = debugger.cpuDebug().m6502().addCondTrap(
YaccParser::getResult(), condition);
commandResult << "Added " << command << " " << Base::toString(ret);
}
else
commandResult << red("invalid expression");
}
if(beg > 0xFFFF || end > 0xFFFF)
{
commandResult << red("One or more addresses are invalid") << endl;
return;
}
// parenthesize provided and address range condition(s) (begin)
stringstream parserBuf, displayBuf;
if(hasCond)
{
parserBuf << "(" << argStrings[0] << ")&&(";
displayBuf << argStrings[0] << " ";
}
// build nice display string
if(read && write)
{
displayBuf << "read|write";
}
else if(read)
{
displayBuf << "read";
}
else if(write)
{
displayBuf << "write";
}
if(beg != end)
displayBuf << " " << Base::toString(beg) << " " << Base::toString(end);
else
displayBuf << " " << Base::toString(beg);
displayBuf << " + mirrors";
// TODO: mirrors
//beg = getBaseMirror(beg);
//end = getBaseMirror(eng);
// add address range condition(s) to provided condition
if(read)
{
if(beg != end)
parserBuf << "_lastread>=" << Base::toString(beg) << "&&_lastread<=" << Base::toString(end);
else
parserBuf << "_lastread==" << Base::toString(beg);
}
if(read && write)
parserBuf << "||";
if(write)
{
if(beg != end)
parserBuf << "_lastwrite>=" << Base::toString(beg) << "&&_lastwrite<=" << Base::toString(end);
else
parserBuf << "_lastwrite==" << Base::toString(beg);
}
// parenthesize provided condition (end)
if(hasCond)
parserBuf << ")";
// TODO: duplicates
bool add = true;
string parserCondition = parserBuf.str();
string displayCondition = displayBuf.str();
int res = YaccParser::parse(parserCondition.c_str());
if(res == 0)
{
uInt32 ret = debugger.cpuDebug().m6502().addCondTrap(
YaccParser::getResult(), displayCondition);
commandResult << "Added " << command << " " << Base::toString(ret);
}
else
{
commandResult << red("invalid expression");
return;
}
myTraps.emplace_back(new Trap{ read, write, beg, end });
for(uInt32 addr = beg; addr <= end; ++addr)
executeTrapRW(addr, read, write, cond);
executeTrapRW(addr, read, write, add);
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
// wrapper function for trap/trapread/trapwrite commands
void DebuggerParser::executeTrapRW(uInt32 addr, bool read, bool write, bool cond)
void DebuggerParser::executeTrapRW(uInt32 addr, bool read, bool write, bool add)
{
switch(debugger.cartDebug().addressType(addr))
{
@ -1624,9 +1664,9 @@ void DebuggerParser::executeTrapRW(uInt32 addr, bool read, bool write, bool cond
if((i & 0x1080) == 0x0000)
{
if(read && (i & 0x000F) == addr)
debugger.toggleReadTrap(i);
add ? debugger.addReadTrap(i) : debugger.removeReadTrap(i);
if(write && (i & 0x003F) == addr)
debugger.toggleWriteTrap(i);
debugger.addWriteTrap(i);
}
}
break;
@ -1638,9 +1678,9 @@ void DebuggerParser::executeTrapRW(uInt32 addr, bool read, bool write, bool cond
if((i & 0x1080) == 0x0080 && (i & 0x0200) != 0x0000 && (i & 0x02FF) == addr)
{
if(read)
debugger.toggleReadTrap(i);
debugger.addReadTrap(i);
if(write)
debugger.toggleWriteTrap(i);
debugger.addReadTrap(i);
}
}
break;
@ -1652,9 +1692,9 @@ void DebuggerParser::executeTrapRW(uInt32 addr, bool read, bool write, bool cond
if((i & 0x1080) == 0x0080 && (i & 0x0200) == 0x0000 && (i & 0x00FF) == addr)
{
if(read)
debugger.toggleReadTrap(i);
debugger.addReadTrap(i);
if(write)
debugger.toggleWriteTrap(i);
debugger.addReadTrap(i);
}
}
break;
@ -1668,9 +1708,9 @@ void DebuggerParser::executeTrapRW(uInt32 addr, bool read, bool write, bool cond
if((i % 0x2000 >= 0x1000) && (i & 0x0FFF) == (addr & 0x0FFF))
{
if(read)
debugger.toggleReadTrap(i);
debugger.addReadTrap(i);
if(write)
debugger.toggleWriteTrap(i);
debugger.addReadTrap(i);
}
}
}
@ -1678,11 +1718,11 @@ void DebuggerParser::executeTrapRW(uInt32 addr, bool read, bool write, bool cond
}
}
bool trapEnabled = false;
/*bool trapEnabled = false;
const string& result = trapStatus(addr, trapEnabled);
if(trapEnabled) cond ? myTrapIfs.push_back(addr) : myTraps.insert(addr);
else cond ? myTrapIfs.size() : myTraps.erase(addr); // TODO trapif
else cond ? myTrapIfs.size() : myTraps.erase(addr); // TODO trapif*/
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
@ -1964,13 +2004,13 @@ DebuggerParser::Command DebuggerParser::commands[kNumCommands] = {
},
{
"deltrapif",
"Delete conditional trapif <xx>",
"Example: deltrapif 0",
"deltrap",
"Delete trap <xx>",
"Example: deltrap 0",
true,
false,
{ kARG_WORD, kARG_END_ARGS },
std::mem_fn(&DebuggerParser::executeDeltrapif)
std::mem_fn(&DebuggerParser::executeDeltrap)
},
{

View File

@ -100,6 +100,13 @@ class DebuggerParser
parameters parms[10];
std::function<void (DebuggerParser*)> executor;
};
struct Trap
{
bool read;
bool write;
uInt32 begin;
uInt32 end;
};
// Reference to our debugger object
Debugger& debugger;
@ -117,10 +124,12 @@ class DebuggerParser
StringList myWatches;
// Keep track of traps (read and/or write)
std::set<uInt32> myTraps;
vector<unique_ptr<Trap>> myTraps;
/*std::set<uInt32> myTraps;
std::vector<uInt32> myTrapIfs;
string trapStatus(uInt32 addr, bool& enabled);
string trapStatus(uInt32 addr, bool& enabled);*/
// List of available command methods
void executeA();
@ -140,9 +149,9 @@ class DebuggerParser
void executeData();
void executeDebugColors();
void executeDefine();
void executeDelbreakif();
void executeDeltrapif();
void executeDelbreakif();
void executeDelfunction();
void executeDeltrap();
void executeDelwatch();
void executeDisasm();
void executeDump();
@ -191,8 +200,8 @@ class DebuggerParser
void executeTrapreadif();
void executeTrapwrite();
void executeTrapwriteif();
void executeTraps(bool read, bool write, bool cond = false, string command = "");
void executeTrapRW(uInt32 addr, bool read, bool write, bool cond = false); // not exposed by debugger
void executeTraps(bool read, bool write, string command, bool cond = false);
void executeTrapRW(uInt32 addr, bool read, bool write, bool add = true); // not exposed by debugger
void executeType();
void executeUHex();
void executeUndef();

View File

@ -120,28 +120,24 @@ inline uInt8 M6502::peek(uInt16 address, uInt8 flags)
}
////////////////////////////////////////////////
mySystem->incrementCycles(SYSTEM_CYCLES_PER_CPU);
uInt8 result = mySystem->peek(address, flags);
myLastPeekAddress = address;
#ifdef DEBUGGER_SUPPORT
if(myReadTraps.isInitialized() && myReadTraps.isSet(address))
{
myJustHitTrapFlag = true;
myHitTrapInfo.message = "RTrap: ";
myHitTrapInfo.address = address;
}
/*if(myReadTrapIfs.isInitialized() && myReadTrapIfs.isSet(address))
{
//TODO: myLastPeekBaseAddress = baseAddress(myLastPeekAddress); // mirror handling
int cond = evalCondTraps();
if(cond > -1)
{
myJustHitTrapFlag = true;
myHitTrapInfo.message = "RTrapIf (" + myTrapCondNames[cond] + "): ";
myHitTrapInfo.message = "RTrap: ";
//myHitTrapInfo.message = "RTrapIf (" + myTrapCondNames[cond] + "): ";
myHitTrapInfo.address = address;
}
}*/
}
#endif // DEBUGGER_SUPPORT
uInt8 result = mySystem->peek(address, flags);
myLastPeekAddress = address;
return result;
}
@ -156,30 +152,24 @@ inline void M6502::poke(uInt16 address, uInt8 value, uInt8 flags)
myLastAddress = address;
}
////////////////////////////////////////////////
mySystem->incrementCycles(SYSTEM_CYCLES_PER_CPU);
mySystem->incrementCycles(SYSTEM_CYCLES_PER_CPU);
mySystem->poke(address, value, flags);
myLastPokeAddress = address;
#ifdef DEBUGGER_SUPPORT
if(myWriteTraps.isInitialized() && myWriteTraps.isSet(address))
{
myJustHitTrapFlag = true;
myHitTrapInfo.message = "WTrap: ";
myHitTrapInfo.address = address;
}
/*if(myWriteTrapIfs.isInitialized() && myWriteTrapIfs.isSet(address))
{
//TODO: myLastPokeBaseAddress = baseAddress(myLastPokeAddress); // mirror handling
int cond = evalCondTraps();
if(cond > -1)
{
myJustHitTrapFlag = true;
myHitTrapInfo.message = "WTrapIf (" + myTrapCondNames[cond] + "): ";
myHitTrapInfo.message = "WTrap: ";
//myHitTrapInfo.message = "WTrapIf (" + myTrapCondNames[cond] + "): ";
myHitTrapInfo.address = address;
}
}*/
#endif // DEBUGGER_SUPPORT
mySystem->poke(address, value, flags);
myLastPokeAddress = address;
}
#endif // DEBUGGER_SUPPORT
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
@ -437,13 +427,15 @@ uInt32 M6502::addCondBreak(Expression* e, const string& name)
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
void M6502::delCondBreak(uInt32 brk)
bool M6502::delCondBreak(uInt32 brk)
{
if(brk < myBreakConds.size())
{
Vec::removeAt(myBreakConds, brk);
Vec::removeAt(myBreakCondNames, brk);
return true;
}
return false;
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
@ -468,13 +460,15 @@ uInt32 M6502::addCondTrap(Expression* e, const string& name)
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
void M6502::delCondTrap(uInt32 brk)
bool M6502::delCondTrap(uInt32 brk)
{
if(brk < myTrapConds.size())
{
Vec::removeAt(myTrapConds, brk);
Vec::removeAt(myTrapCondNames, brk);
return true;
}
return false;
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

View File

@ -231,13 +231,13 @@ class M6502 : public Serializable
// methods for 'breakif' handling
uInt32 addCondBreak(Expression* e, const string& name);
void delCondBreak(uInt32 brk);
bool delCondBreak(uInt32 brk);
void clearCondBreaks();
const StringList& getCondBreakNames() const;
// methods for 'trapif' handling
uInt32 addCondTrap(Expression* e, const string& name);
void delCondTrap(uInt32 brk);
bool delCondTrap(uInt32 brk);
void clearCondTraps();
const StringList& getCondTrapNames() const;
#endif // DEBUGGER_SUPPORT