From af526c02881a345a65c2e07a56598edd2f4c95ef Mon Sep 17 00:00:00 2001 From: Stephen Anthony Date: Sun, 8 Jan 2023 21:52:24 -0330 Subject: [PATCH] Small optimization; don't unnecessarily clear buffers. --- src/emucore/MD5.cxx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/emucore/MD5.cxx b/src/emucore/MD5.cxx index b0831b19e..4a0df33a0 100644 --- a/src/emucore/MD5.cxx +++ b/src/emucore/MD5.cxx @@ -168,8 +168,8 @@ void MD5::transform(const uInt8* const block) state[2] += c; state[3] += d; - // Zeroize sensitive information. - x.fill(0); + // Zeroize sensitive information (not required for Stella) + // x.fill(0); } // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -237,9 +237,9 @@ void MD5::finalize() // Store state in digest encode(digest.data(), state.data(), 16); - // Zeroize sensitive information - buffer.fill(0); - count.fill(0); + // Zeroize sensitive information (not required for Stella) + // buffer.fill(0); + // count.fill(0); finalized = true; }