Minor cleanup of d'tor in various classes, removing d'tors with no

implementation, and using virtual d'tor only when absolutely necessary.


git-svn-id: svn://svn.code.sf.net/p/stella/code/trunk@3000 8b62c5a3-ac7e-4cc8-8f21-d9a121418aba

src/cheat/CheatCodeDialog.hxx

@@ -38,7 +38,7 @@ class CheatCodeDialog : public Dialog
   public:
     CheatCodeDialog(OSystem* osystem, DialogContainer* parent,
                    const GUI::Font& font);
-    ~CheatCodeDialog();
+    virtual ~CheatCodeDialog();
 
   protected:
     virtual void handleCommand(CommandSender* sender, int cmd, int data, int id);

src/cheat/CheatManager.hxx

@@ -43,7 +43,7 @@ class CheatManager
 {
   public:
     CheatManager(OSystem* osystem);
-    virtual ~CheatManager();
+    ~CheatManager();
 
     /**
       Adds the specified cheat to an internal list.

src/common/MouseControl.cxx

@@ -167,11 +167,6 @@ MouseControl::MouseControl(Console& console, const string& mode)
 #endif
 }
 
-// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-MouseControl::~MouseControl()
-{
-}
-
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 const string& MouseControl::next()
 {

src/common/MouseControl.hxx

@@ -60,12 +60,6 @@ class MouseControl
     */
     MouseControl(Console& console, const string& mode);
 
-    /**
-      Destructor
-    */
-    virtual ~MouseControl();
-
-  public:
     /**
       Cycle through each available mouse control mode
 

src/common/PNGLibrary.hxx

@@ -41,7 +41,7 @@ class PNGLibrary
 {
   public:
     PNGLibrary(const FrameBuffer& fb);
-    virtual ~PNGLibrary();
+    ~PNGLibrary();
 
     /**
       Read a PNG image from the specified file into a FBSurface structure,

src/common/ZipHandler.hxx

@@ -69,7 +69,7 @@ class ZipHandler
 {
   public:
     ZipHandler();
-    virtual ~ZipHandler();
+    ~ZipHandler();
 
     // Open ZIP file for processing
     void open(const string& filename);

src/common/tv_filters/NTSCFilter.cxx

@@ -30,11 +30,6 @@ NTSCFilter::NTSCFilter()
 {
 }
 
-// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-NTSCFilter::~NTSCFilter()
-{
-}
-
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 void NTSCFilter::setTIAPalette(const TIASurface& tiaSurface, const uInt32* palette)
 {

src/common/tv_filters/NTSCFilter.hxx

@@ -42,7 +42,6 @@ class NTSCFilter
 {
   public:
     NTSCFilter();
-    virtual ~NTSCFilter();
 
   public:
     // Set one of the available preset adjustments (Composite, S-Video, RGB, etc)

src/emucore/MT24LC256.hxx

@@ -47,7 +47,7 @@ class MT24LC256
     /**
       Destructor
     */
-    virtual ~MT24LC256();
+    ~MT24LC256();
 
   public:
     /** Read boolean data from the SDA line */

src/emucore/Props.cxx

@@ -36,11 +36,6 @@ Properties::Properties(const Properties& properties)
   copy(properties);
 }
 
-// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-Properties::~Properties()
-{
-}
-
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 const string& Properties::get(PropertyType key) const
 {

src/emucore/Props.hxx

@@ -76,11 +76,6 @@ class Properties
     */
     Properties(const Properties& properties);
 
-    /**
-      Destructor
-    */
-    virtual ~Properties();
-
   public:
     /**
       Get the value assigned to the specified key.  If the key does

src/emucore/PropsSet.hxx

@@ -50,7 +50,7 @@ class PropertiesSet
     /**
       Destructor
     */
-    virtual ~PropertiesSet();
+    ~PropertiesSet();
 
   public:
     /** 

src/emucore/Serializer.cxx

@@ -69,7 +69,7 @@ Serializer::Serializer(const string& filename, bool readonly)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-Serializer::Serializer(void)
+Serializer::Serializer()
   : myStream(NULL),
     myUseFilestream(false)
 {
@@ -86,7 +86,7 @@ Serializer::Serializer(void)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-Serializer::~Serializer(void)
+Serializer::~Serializer()
 {
   if(myStream != NULL)
   {
@@ -99,13 +99,13 @@ Serializer::~Serializer(void)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-bool Serializer::isValid(void)
+bool Serializer::isValid()
 {
   return myStream != NULL;
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-void Serializer::reset(void)
+void Serializer::reset()
 {
   myStream->clear();
   myStream->seekg(ios_base::beg);
@@ -113,7 +113,7 @@ void Serializer::reset(void)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-uInt8 Serializer::getByte(void)
+uInt8 Serializer::getByte()
 {
   char buf;
   myStream->read(&buf, 1);
@@ -128,7 +128,7 @@ void Serializer::getByteArray(uInt8* array, uInt32 size)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-uInt16 Serializer::getShort(void)
+uInt16 Serializer::getShort()
 {
   uInt16 val = 0;
   myStream->read((char*)&val, sizeof(uInt16));
@@ -143,7 +143,7 @@ void Serializer::getShortArray(uInt16* array, uInt32 size)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-uInt32 Serializer::getInt(void)
+uInt32 Serializer::getInt()
 {
   uInt32 val = 0;
   myStream->read((char*)&val, sizeof(uInt32));
@@ -158,7 +158,7 @@ void Serializer::getIntArray(uInt32* array, uInt32 size)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-string Serializer::getString(void)
+string Serializer::getString()
 {
   int len = getInt();
   string str;
@@ -169,7 +169,7 @@ string Serializer::getString(void)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-bool Serializer::getBool(void)
+bool Serializer::getBool()
 {
   return getByte() == TruePattern;
 }

src/emucore/Serializer.hxx

@@ -54,31 +54,31 @@ class Serializer
       was correctly initialized.
     */
     Serializer(const string& filename, bool readonly = false);
-    Serializer(void);
+    Serializer();
 
     /**
       Destructor
     */
-    virtual ~Serializer(void);
+    ~Serializer();
 
   public:
     /**
       Answers whether the serializer is currently initialized for reading
       and writing.
     */
-    bool isValid(void);
+    bool isValid();
 
     /**
       Resets the read/write location to the beginning of the stream.
     */
-    void reset(void);
+    void reset();
 
     /**
       Reads a byte value (unsigned 8-bit) from the current input stream.
 
       @result The byte value which has been read from the stream.
     */
-    uInt8 getByte(void);
+    uInt8 getByte();
 
     /**
       Reads a byte array (unsigned 8-bit) from the current input stream.
@@ -94,7 +94,7 @@ class Serializer
 
       @result The short value which has been read from the stream.
     */
-    uInt16 getShort(void);
+    uInt16 getShort();
 
     /**
       Reads a short array (unsigned 16-bit) from the current input stream.
@@ -109,7 +109,7 @@ class Serializer
 
       @result The int value which has been read from the stream.
     */
-    uInt32 getInt(void);
+    uInt32 getInt();
 
     /**
       Reads an integer array (unsigned 32-bit) from the current input stream.
@@ -124,14 +124,14 @@ class Serializer
 
       @result The string which has been read from the stream.
     */
-    string getString(void);
+    string getString();
 
     /**
       Reads a boolean value from the current input stream.
 
       @result The boolean value which has been read from the stream.
     */
-    bool getBool(void);
+    bool getBool();
 
     /**
       Writes an byte value (unsigned 8-bit) to the current output stream.

src/emucore/StateManager.cxx

@@ -42,11 +42,6 @@ StateManager::StateManager(OSystem* osystem)
   reset();
 }
 
-// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-StateManager::~StateManager()
-{
-}
-
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool StateManager::isActive()
 {

src/emucore/StateManager.hxx

@@ -40,11 +40,6 @@ class StateManager
     */
     StateManager(OSystem* osystem);
 
-    /**
-      Destructor
-    */
-    virtual ~StateManager();
-
   public:
     /**
       Answers whether the manager is in record or playback mode

src/emucore/TIASnd.cxx

@@ -30,11 +30,6 @@ TIASound::TIASound(Int32 outputFrequency)
   reset();
 }
 
-// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-TIASound::~TIASound()
-{
-}
-
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 void TIASound::reset()
 {

src/emucore/TIASnd.hxx

@@ -40,11 +40,6 @@ class TIASound
     */
     TIASound(Int32 outputFrequency = 31400);
 
-    /**
-      Destructor
-    */
-    virtual ~TIASound();
-
   public:
     /**
       Reset the sound emulation to its power-on state

src/emucore/TIASurface.cxx

@@ -62,11 +62,6 @@ TIASurface::TIASurface(OSystem& system)
   myBaseTiaSurface = myFB.surface(baseID);
 }
 
-// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-TIASurface::~TIASurface()
-{
-}
-
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 void TIASurface::initialize(const Console& console, const VideoMode& mode)
 {

src/emucore/TIASurface.hxx

@@ -48,11 +48,6 @@ class TIASurface
     */
     TIASurface(OSystem& system);
 
-    /**
-      Destructor
-    */
-    virtual ~TIASurface();
-
     /**
       Set the TIA object, which is needed for actually rendering the TIA image.
     */