Some more nullptr and formatting cleanups.

git-svn-id: svn://svn.code.sf.net/p/stella/code/trunk@3051 8b62c5a3-ac7e-4cc8-8f21-d9a121418aba

src/cheat/BankRomCheat.hxx

@@ -26,7 +26,7 @@ class BankRomCheat : public Cheat
 {
   public:
     BankRomCheat(OSystem& os, const string& name, const string& code);
-    ~BankRomCheat();
+    virtual ~BankRomCheat();
 
     bool enable();
     bool disable();

src/cheat/Cheat.hxx

@@ -53,7 +53,7 @@ class Cheat
     {
       int ret = 0;
 
-      for(unsigned int i=0; i<hex.size(); i++) {
+      for(unsigned int i = 0; i < hex.size(); ++i) {
         char c = hex[i];
 
         ret *= 16;

src/cheat/CheatCodeDialog.cxx

@@ -86,7 +86,7 @@ CheatCodeDialog::CheatCodeDialog(OSystem& osystem, DialogContainer& parent,
   StringList labels;
   labels.push_back("Name: ");
   labels.push_back("Code: ");
-  myCheatInput = new InputTextDialog(this, font, labels);
+  myCheatInput = make_ptr<InputTextDialog>(this, font, labels);
   myCheatInput->setTarget(this);
 
   addToFocusList(wid);
@@ -100,7 +100,6 @@ CheatCodeDialog::CheatCodeDialog(OSystem& osystem, DialogContainer& parent,
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CheatCodeDialog::~CheatCodeDialog()
 {
-  delete myCheatInput;
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

src/cheat/CheatCodeDialog.hxx

@@ -41,7 +41,7 @@ class CheatCodeDialog : public Dialog
     virtual ~CheatCodeDialog();
 
   protected:
-    virtual void handleCommand(CommandSender* sender, int cmd, int data, int id);
+    void handleCommand(CommandSender* sender, int cmd, int data, int id);
     void loadConfig();
     void saveConfig();
 
@@ -53,7 +53,7 @@ class CheatCodeDialog : public Dialog
 
   private:
     CheckListWidget* myCheatList;
-    InputTextDialog* myCheatInput;
+    unique_ptr<InputTextDialog> myCheatInput;
 
     ButtonWidget* myEditButton;
     ButtonWidget* myRemoveButton;

src/cheat/CheatManager.cxx

@@ -52,7 +52,7 @@ Cheat* CheatManager::add(const string& name, const string& code,
 {
   Cheat* cheat = createCheat(name, code);
   if(!cheat)
-    return NULL;
+    return nullptr;
 
   // Delete duplicate entries
   for(unsigned int i = 0; i < myCheatList.size(); i++)
@@ -129,7 +129,7 @@ void CheatManager::addPerFrame(Cheat* cheat, bool enable)
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 void CheatManager::addOneShot(const string& name, const string& code)
 {
-  Cheat* cheat = (Cheat*) createCheat(name, code);
+  Cheat* cheat = createCheat(name, code);
   if(!cheat)
     return;
 
@@ -142,7 +142,7 @@ void CheatManager::addOneShot(const string& name, const string& code)
 Cheat* CheatManager::createCheat(const string& name, const string& code) const
 {
   if(!isValidCode(code))
-    return NULL;
+    return nullptr;
 
   // Create new cheat based on string length
   switch(code.size())
@@ -160,7 +160,7 @@ Cheat* CheatManager::createCheat(const string& name, const string& code) const
       break;
 
     default:
-      return NULL;
+      return nullptr;
   }
 }
 

src/cheat/CheetahCheat.hxx

@@ -26,7 +26,7 @@ class CheetahCheat : public Cheat
 {
   public:
     CheetahCheat(OSystem& os, const string& name, const string& code);
-    ~CheetahCheat();
+    virtual ~CheetahCheat();
 
     bool enable();
     bool disable();

src/debugger/CartDebug.cxx

@@ -38,7 +38,7 @@ using namespace Common;
 CartDebug::CartDebug(Debugger& dbg, Console& console, const OSystem& osystem)
   : DebuggerSystem(dbg, console),
     myOSystem(osystem),
-    myDebugWidget(0),
+    myDebugWidget(nullptr),
     myAddrToLineIsROM(true),
     myRWPortAddress(0),
     myLabelLength(8)   // longest pre-defined label

src/unix/FSNodePOSIX.cxx

@@ -254,7 +254,7 @@ bool FilesystemNodePOSIX::rename(const string& newfile)
 AbstractFSNode* FilesystemNodePOSIX::getParent() const
 {
   if (_path == "/")
-    return 0;
+    return nullptr;
 
   const char *start = _path.c_str();
   const char *end = lastPathComponent(_path);

src/windows/FSNodeWINDOWS.cxx

@@ -300,7 +300,7 @@ bool FilesystemNodeWINDOWS::rename(const string& newfile)
 AbstractFSNode* FilesystemNodeWINDOWS::getParent() const
 {
   if(!_isValid || _isPseudoRoot)
-    return 0;
+    return nullptr;
 
   FilesystemNodeWINDOWS* p = new FilesystemNodeWINDOWS();
   if(_path.size() > 3)