ShuriZma
/
stella
mirror of https://github.com/stella-emu/stella.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'master' of https://github.com/stella-emu/stella

This commit is contained in:
thrust26 2024-08-11 19:48:23 +02:00
parent cdb3ef82ce d6fadd04d2
commit a5757a1562
7 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/emucore/CartELF.cxx
View File

@ -173,7 +173,7 @@ namespace {
{
if (!props) return SystemType::ntsc;
string displayFormat = props->get(PropType::Display_Format);
const string displayFormat = props->get(PropType::Display_Format);
if(displayFormat == "PAL" || displayFormat == "SECAM") return SystemType::pal;
if(displayFormat == "PAL60") return SystemType::pal60;

4
src/emucore/elf/ElfLinker.cxx
View File

@ -166,7 +166,7 @@ ElfLinker::RelocatedSymbol ElfLinker::findRelocatedSymbol(string_view name) cons
if (!myRelocatedSymbols[i])
ElfSymbolResolutionError::raise("symbol could not be relocated");
return myRelocatedSymbols[i].value();
return myRelocatedSymbols[i].value(); // NOLINT: we know the value is valid
}
ElfSymbolResolutionError::raise("symbol not found");
@ -423,7 +423,7 @@ void ElfLinker::copyInitArrays(vector<uInt32>& initArray, const std::unordered_m
void ElfLinker::applyRelocationToSection(const ElfFile::Relocation& relocation, size_t iSection)
{
const auto& targetSection = myElf.getSections()[iSection];
const auto& targetSectionRelocated = myRelocatedSections[iSection].value();
const auto& targetSectionRelocated = myRelocatedSections[iSection].value(); // NOLINT
const auto& symbol = myElf.getSymbols()[relocation.symbol];
const auto& relocatedSymbol = myRelocatedSymbols[relocation.symbol];

6
src/emucore/elf/ElfParser.cxx
View File

@ -144,14 +144,16 @@ uInt8 ElfParser::read8(uInt32 offset) const
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
uInt16 ElfParser::read16(uInt32 offset) const
{
return myBigEndian ? ((read8(offset) << 8) | read8(offset + 1))
return myBigEndian
? ((read8(offset) << 8) | read8(offset + 1))
: ((read8(offset + 1) << 8) | read8(offset));
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
uInt32 ElfParser::read32(uInt32 offset) const
{
return myBigEndian ? ((read8(offset) << 24) | (read8(offset + 1) << 16) |
return myBigEndian
? ((read8(offset) << 24) | (read8(offset + 1) << 16) |
(read8(offset + 2) << 8) | read8(offset + 3))
: ((read8(offset + 3) << 24) | (read8(offset + 2) << 16) |
(read8(offset + 1) << 8) | read8(offset));

1
src/emucore/elf/VcsLib.cxx
View File

@ -176,6 +176,7 @@ void VcsLib::vcsLda2(uInt8 value)
.injectROM(value);
}
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
CortexM0::err_t VcsLib::stackOperation(uInt16& value, uInt8& op, uInt8 opcode)
{
myTransactionQueue