Replace Map::find with Map::contains where appropriate.

src/common/JoyMap.cxx

@@ -98,9 +98,7 @@ Event::Type JoyMap::get(const EventMode mode, const int button,
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool JoyMap::check(const JoyMapping& mapping) const
 {
-  const auto find = myMap.find(mapping);
+  return myMap.contains(mapping);
-
-  return (find != myMap.end());
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

src/common/KeyMap.cxx

@@ -122,9 +122,7 @@ Event::Type KeyMap::get(const EventMode mode, const int key, const int mod) cons
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool KeyMap::check(const Mapping& mapping) const
 {
-  const auto find = myMap.find(convertMod(mapping));
+  return myMap.contains(convertMod(mapping));
-
-  return (find != myMap.end());
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

src/common/PJoystickHandler.cxx

@@ -714,33 +714,33 @@ EventMode PhysicalJoystickHandler::getEventMode(const Event::Type event,
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool PhysicalJoystickHandler::isJoystickEvent(const Event::Type event)
 {
-  return LeftJoystickEvents.find(event) != LeftJoystickEvents.end()
+  return LeftJoystickEvents.contains(event)
-    || QTJoystick3Events.find(event) != QTJoystick3Events.end()
+    || QTJoystick3Events.contains(event)
-    || RightJoystickEvents.find(event) != RightJoystickEvents.end()
+    || RightJoystickEvents.contains(event)
-    || QTJoystick4Events.find(event) != QTJoystick4Events.end();
+    || QTJoystick4Events.contains(event);
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool PhysicalJoystickHandler::isPaddleEvent(const Event::Type event)
 {
-  return LeftPaddlesEvents.find(event) != LeftPaddlesEvents.end()
+  return LeftPaddlesEvents.contains(event)
-    || QTPaddles3Events.find(event) != QTPaddles3Events.end()
+    || QTPaddles3Events.contains(event)
-    || RightPaddlesEvents.find(event) != RightPaddlesEvents.end()
+    || RightPaddlesEvents.contains(event)
-    || QTPaddles4Events.find(event) != QTPaddles4Events.end();
+    || QTPaddles4Events.contains(event);
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool PhysicalJoystickHandler::isKeyboardEvent(const Event::Type event)
 {
-  return LeftKeyboardEvents.find(event) != LeftKeyboardEvents.end()
+  return LeftKeyboardEvents.contains(event)
-    || RightKeyboardEvents.find(event) != RightKeyboardEvents.end();
+    || RightKeyboardEvents.contains(event);
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool PhysicalJoystickHandler::isDrivingEvent(const Event::Type event)
 {
-  return LeftDrivingEvents.find(event) != LeftDrivingEvents.end()
+  return LeftDrivingEvents.contains(event)
-    || RightDrivingEvents.find(event) != RightDrivingEvents.end();
+    || RightDrivingEvents.contains(event);
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

src/common/PKeyboardHandler.cxx

@@ -446,33 +446,33 @@ EventMode PhysicalKeyboardHandler::getEventMode(const Event::Type event,
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool PhysicalKeyboardHandler::isJoystickEvent(const Event::Type event)
 {
-  return LeftJoystickEvents.find(event) != LeftJoystickEvents.end()
+  return LeftJoystickEvents.contains(event)
-    || QTJoystick3Events.find(event) != QTJoystick3Events.end()
+    || QTJoystick3Events.contains(event)
-    || RightJoystickEvents.find(event) != RightJoystickEvents.end()
+    || RightJoystickEvents.contains(event)
-    || QTJoystick4Events.find(event) != QTJoystick4Events.end();
+    || QTJoystick4Events.contains(event);
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool PhysicalKeyboardHandler::isPaddleEvent(const Event::Type event)
 {
-  return LeftPaddlesEvents.find(event) != LeftPaddlesEvents.end()
+  return LeftPaddlesEvents.contains(event)
-    || QTPaddles3Events.find(event) != QTPaddles3Events.end()
+    || QTPaddles3Events.contains(event)
-    || RightPaddlesEvents.find(event) != RightPaddlesEvents.end()
+    || RightPaddlesEvents.contains(event)
-    || QTPaddles4Events.find(event) != QTPaddles4Events.end();
+    || QTPaddles4Events.contains(event);
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool PhysicalKeyboardHandler::isKeyboardEvent(const Event::Type event)
 {
-  return LeftKeyboardEvents.find(event) != LeftKeyboardEvents.end()
+  return LeftKeyboardEvents.contains(event)
-    || RightKeyboardEvents.find(event) != RightKeyboardEvents.end();
+    || RightKeyboardEvents.contains(event);
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool PhysicalKeyboardHandler::isDrivingEvent(const Event::Type event)
 {
-  return LeftDrivingEvents.find(event) != LeftDrivingEvents.end()
+  return LeftDrivingEvents.contains(event)
-    || RightDrivingEvents.find(event) != RightDrivingEvents.end();
+    || RightDrivingEvents.contains(event);
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

src/common/main.cxx

@@ -140,12 +140,11 @@ void parseCommandLine(int ac, const char* const av[],
 void checkForCustomBaseDir(Settings::Options& options)
 {
   // If both of these are activated, the 'base in app dir' takes precedence
-  auto it = options.find("baseinappdir");
+  if(options.contains("baseinappdir"))
-  if(it != options.end())
     OSystem::overrideBaseDirWithApp();
   else
   {
-    it = options.find("basedir");
+    auto it = options.find("basedir");
     if(it != options.end())
       OSystem::overrideBaseDir(it->second.toString());
   }

src/common/repository/sqlite/StellaDb.cxx

@@ -191,8 +191,7 @@ void StellaDb::importOldPropset(const FSNode& node)
 
     if (props.empty())
       break;
-    if ((props.find("Cart.MD5") == props.end()) ||
+    if (!props.contains("Cart.MD5") || props["Cart.MD5"].toString().empty())
-         props["Cart.MD5"].toString().empty())
       continue;
 
     myPropertyRepository->get(props["Cart.MD5"].toString())->save(props);

src/debugger/CartDebug.cxx

@@ -1331,7 +1331,7 @@ string CartDebug::saveDisassembly(string path)
       const bool stackUsed = (mySystem.getAccessFlags(addr|0x100) & (Device::DATA | Device::WRITE));
 
       if (myReserved.ZPRAM[addr - 0x80] &&
-          myUserLabels.find(addr) == myUserLabels.end()) {
+          !myUserLabels.contains(addr)) {
         if (addLine)
           out << "\n";
         out << ALIGN(16) << ourZPMnemonic[addr - 0x80] << "= $"

src/debugger/Debugger.cxx

@@ -800,8 +800,7 @@ bool Debugger::isBuiltinFunction(string_view name)
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool Debugger::delFunction(string_view name)
 {
-  const auto& iter = myFunctions.find(name);
+  if(!myFunctions.contains(name))
-  if(iter == myFunctions.end())
     return false;
 
   // We never want to delete built-in functions
@@ -810,8 +809,7 @@ bool Debugger::delFunction(string_view name)
 
   myFunctions.erase(string{name});
 
-  const auto& def_iter = myFunctionDefs.find(name);
+  if(!myFunctionDefs.contains(name))
-  if(def_iter == myFunctionDefs.end())
     return false;
 
   myFunctionDefs.erase(string{name});

src/gui/FavoritesManager.cxx

@@ -169,7 +169,7 @@ bool FavoritesManager::toggleUser(string_view path)
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 bool FavoritesManager::existsUser(string_view path) const
 {
-  return myUserSet.find(string{path}) != myUserSet.end();  // TODO: fixed in C++20
+  return myUserSet.contains(string{path});
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

src/gui/LauncherDialog.cxx

@@ -427,8 +427,7 @@ const string& LauncherDialog::selectedRomMD5()
     myMD5List.clear();
 
   // Lookup MD5, and if not present, cache it
-  const auto iter = myMD5List.find(currentNode().getPath());
+  if(!myMD5List.contains(currentNode().getPath()))
-  if(iter == myMD5List.end())
     myMD5List[currentNode().getPath()] = OSystem::getROMMD5(currentNode());
 
   return myMD5List[currentNode().getPath()];