ShuriZma
/
stella
mirror of https://github.com/stella-emu/stella.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix gcc warning: use const references instead of pass by value for exceptions.

This commit is contained in:
Stephen Anthony 2020-11-28 22:25:22 -03:30
parent c5f8191b7d
commit 897376d351
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/JoyMap.cxx
View File

@ -240,7 +240,7 @@ int JoyMap::loadMapping(const json& eventMappings, const EventMode mode)
); );
i++; i++;
} catch (json::exception) { } catch (const json::exception&) {
Logger::error("ignoring invalid joystick event"); Logger::error("ignoring invalid joystick event");
} }
} }

2
src/common/KeyMap.cxx
View File

@ -208,7 +208,7 @@ int KeyMap::loadMapping(const json& mappings, const EventMode mode) {
); );
i++; i++;
} catch (json::exception) { } catch (const json::exception&) {
Logger::error("ignoring bad keyboard mapping"); Logger::error("ignoring bad keyboard mapping");
} }
} }

2
src/common/PJoystickHandler.cxx
View File

@ -47,7 +47,7 @@ PhysicalJoystickHandler::PhysicalJoystickHandler(
try { try {
mappings = json::parse(serializedMapping); mappings = json::parse(serializedMapping);
} catch (json::exception) { } catch (const json::exception&) {
Logger::info("converting legacy joystick mappings"); Logger::info("converting legacy joystick mappings");
mappings = convertLegacyMapping(serializedMapping); mappings = convertLegacyMapping(serializedMapping);

4
src/common/PKeyboardHandler.cxx
View File

@ -74,7 +74,7 @@ void PhysicalKeyboardHandler::loadSerializedMappings(const string& serializedMap
try { try {
mapping = json::parse(serializedMapping); mapping = json::parse(serializedMapping);
} catch (json::exception) { } catch (const json::exception&) {
Logger::info("converting legacy keyboard mappings"); Logger::info("converting legacy keyboard mappings");
mapping = KeyMap::convertLegacyMapping(serializedMapping); mapping = KeyMap::convertLegacyMapping(serializedMapping);
@ -82,7 +82,7 @@ void PhysicalKeyboardHandler::loadSerializedMappings(const string& serializedMap
try { try {
myKeyMap.loadMapping(mapping, mode); myKeyMap.loadMapping(mapping, mode);
} catch (json::exception) { } catch (const json::exception&) {
Logger::error("ignoring bad keyboard mappings"); Logger::error("ignoring bad keyboard mappings");
} }
} }

2
src/common/PhysicalJoystick.cxx
View File

@ -87,7 +87,7 @@ bool PhysicalJoystick::setMap(const json& map)
try { try {
joyMap.loadMapping(entry.value(), eventModeFromJsonName(entry.key())); joyMap.loadMapping(entry.value(), eventModeFromJsonName(entry.key()));
} catch (json::exception) { } catch (const json::exception&) {
Logger::error("ignoring invalid json mapping for " + entry.key()); Logger::error("ignoring invalid json mapping for " + entry.key());
} }