ShuriZma
/
stella
mirror of https://github.com/stella-emu/stella.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix crash in cart autodetect; if we can't find a match, use 4K.

This commit is contained in:
Stephen Anthony 2020-05-02 18:15:27 -02:30
parent 6363ebaf0a
commit 8525c605f4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/emucore/CartDetector.cxx
View File

@ -531,8 +531,6 @@ Bankswitch::Type CartDetector::autodetectType(const ByteBuffer& image, size_t si
type = Bankswitch::Type::_3E; type = Bankswitch::Type::_3E;
else if(isProbably3F(image, size)) else if(isProbably3F(image, size))
type = Bankswitch::Type::_3F; type = Bankswitch::Type::_3F;
else
type = Bankswitch::Type::_4K; // Most common bankswitching type
} }
// Variable sized ROM formats are independent of image size and come last // Variable sized ROM formats are independent of image size and come last
@ -541,8 +539,11 @@ Bankswitch::Type CartDetector::autodetectType(const ByteBuffer& image, size_t si
else if(isProbablyMDM(image, size)) else if(isProbablyMDM(image, size))
type = Bankswitch::Type::_MDM; type = Bankswitch::Type::_MDM;
ostringstream ss; // If we get here and autodetection failed, then we force '4K'
if(type == Bankswitch::Type::_AUTO)
type = Bankswitch::Type::_4K; // Most common bankswitching type
ostringstream ss;
ss << "Bankswitching type '" << Bankswitch::typeToDesc(type) << "' detected"; ss << "Bankswitching type '" << Bankswitch::typeToDesc(type) << "' detected";
Logger::debug(ss.str()); Logger::debug(ss.str());