ShuriZma
/
stella
mirror of https://github.com/stella-emu/stella.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Removed 'Emulation.HmoveBlanks' property from the codebase. The TIA 

class was already ignoring it, so there's no need to keep it anywhere
else.  This property was used if one wanted to disable HMOVE blanking
in cases where it should be present.  However, since we're striving for
absolute accuracy in the TIA emulation, it really shouldn't be optional.


git-svn-id: svn://svn.code.sf.net/p/stella/code/trunk@1643 8b62c5a3-ac7e-4cc8-8f21-d9a121418aba
This commit is contained in:
stephena 2009-01-20 16:21:29 +00:00
parent f55a483f29
commit 828dfe4661
8 changed files with 3213 additions and 3238 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6406
stella/src/emucore/DefProps.hxx
View File

File diff suppressed because it is too large Load Diff

3
stella/src/emucore/OSystem.cxx
View File

@ -13,7 +13,7 @@
// See the file "license" for information on usage and redistribution of
// this file, and for a DISCLAIMER OF ALL WARRANTIES.
//
// $Id: OSystem.cxx,v 1.149 2009-01-19 21:19:59 stephena Exp $
// $Id: OSystem.cxx,v 1.150 2009-01-20 16:21:28 stephena Exp $
//============================================================================
#include <cassert>
@ -592,7 +592,6 @@ Console* OSystem::openConsole(const string& romfile, string& md5)
CMDLINE_PROPS_UPDATE("height", Display_Height);
CMDLINE_PROPS_UPDATE("pp", Display_Phosphor);
CMDLINE_PROPS_UPDATE("ppblend", Display_PPBlend);
CMDLINE_PROPS_UPDATE("hmove", Emulation_HmoveBlanks);
Cartridge* cart = Cartridge::create(image, size, props, *mySettings);
if(cart)

9
stella/src/emucore/Props.cxx
View File

@ -13,7 +13,7 @@
// See the file "license" for information on usage and redistribution of
// this file, and for a DISCLAIMER OF ALL WARRANTIES.
//
// $Id: Props.cxx,v 1.23 2009-01-01 18:13:36 stephena Exp $
// $Id: Props.cxx,v 1.24 2009-01-20 16:21:28 stephena Exp $
//============================================================================
#include <cctype>
@ -69,7 +69,6 @@ void Properties::set(PropertyType key, const string& value)
case Controller_SwapPaddles:
case Display_Format:
case Display_Phosphor:
case Emulation_HmoveBlanks:
{
transform(myProperties[key].begin(), myProperties[key].end(),
myProperties[key].begin(), (int(*)(int)) toupper);
@ -298,8 +297,7 @@ const char* Properties::ourDefaultProperties[LastPropType] = {
"34", // Display.YStart
"210", // Display.Height
"NO", // Display.Phosphor
"77", // Display.PPBlend
"YES" // Emulation.HmoveBlanks
"77" // Display.PPBlend
};
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
@ -323,6 +321,5 @@ const char* Properties::ourPropertyNames[LastPropType] = {
"Display.YStart",
"Display.Height",
"Display.Phosphor",
"Display.PPBlend",
"Emulation.HmoveBlanks"
"Display.PPBlend"
};

5
stella/src/emucore/Props.hxx
View File

@ -13,7 +13,7 @@
// See the file "license" for information on usage and redistribution of
// this file, and for a DISCLAIMER OF ALL WARRANTIES.
//
// $Id: Props.hxx,v 1.17 2009-01-01 18:13:36 stephena Exp $
// $Id: Props.hxx,v 1.18 2009-01-20 16:21:28 stephena Exp $
//============================================================================
#ifndef PROPERTIES_HXX
@ -42,7 +42,6 @@ enum PropertyType {
Display_Height,
Display_Phosphor,
Display_PPBlend,
Emulation_HmoveBlanks,
LastPropType
};
@ -55,7 +54,7 @@ enum PropertyType {
if the property key is not found in the original property list.
@author Bradford W. Mott
@version $Id: Props.hxx,v 1.17 2009-01-01 18:13:36 stephena Exp $
@version $Id: Props.hxx,v 1.18 2009-01-20 16:21:28 stephena Exp $
*/
class Properties
{

4
stella/src/emucore/stella.pro
View File

@ -3562,7 +3562,6 @@
"Cartridge.Name" "Climber 5 (01-05-2003) (Dennis Debro)"
"Cartridge.Rarity" "Homebrew"
"Display.YStart" "28"
"Emulation.HmoveBlanks" "NO"
""
"Cartridge.MD5" "31f4692ee2ca07a7ce1f7a6a1dab4ac9"
@ -9409,7 +9408,6 @@
"Cartridge.Name" "Climber 5 (20-03-2003) (Dennis Debro)"
"Cartridge.Rarity" "Homebrew"
"Display.YStart" "28"
"Emulation.HmoveBlanks" "NO"
""
"Cartridge.MD5" "877a5397f3f205bf6750398c98f33de1"
@ -10678,7 +10676,6 @@
"Cartridge.Note" "For Philly Classic 4"
"Cartridge.Rarity" "Homebrew"
"Display.YStart" "28"
"Emulation.HmoveBlanks" "NO"
""
"Cartridge.MD5" "9cbb07f1993a027bc2f87d5205457ec9"
@ -14596,7 +14593,6 @@
"Cartridge.Name" "Climber 5 (30-10-2002) (Dennis Debro) (Prototype)"
"Cartridge.Rarity" "Prototype"
"Display.YStart" "28"
"Emulation.HmoveBlanks" "NO"
""
"Cartridge.MD5" "d7f5bf138cfc7feab7b8ef1534c8b477"

15
stella/src/gui/GameInfoDialog.cxx
View File

@ -13,7 +13,7 @@
// See the file "license" for information on usage and redistribution of
// this file, and for a DISCLAIMER OF ALL WARRANTIES.
//
// $Id: GameInfoDialog.cxx,v 1.65 2009-01-15 18:45:23 stephena Exp $
// $Id: GameInfoDialog.cxx,v 1.66 2009-01-20 16:21:28 stephena Exp $
//
// Based on code from ScummVM - Scumm Interpreter
// Copyright (C) 2002-2004 The ScummVM project
@ -332,16 +332,6 @@ GameInfoDialog::GameInfoDialog(
3*fontWidth, fontHeight, "", kTextAlignLeft);
myPPBlendLabel->setFlags(WIDGET_CLEARBG);
ypos += lineHeight + 5;
new StaticTextWidget(myTab, font, xpos, ypos+1, lwidth, fontHeight,
"Use HMBlanks:", kTextAlignLeft);
items.clear();
items.push_back("Yes", "YES");
items.push_back("No", "NO");
myHmoveBlanks = new PopUpWidget(myTab, font, xpos+lwidth, ypos, pwidth,
lineHeight, items, "", 0, 0);
wid.push_back(myHmoveBlanks);
// Add items for tab 3
addToFocusList(wid, tabID);
@ -439,8 +429,6 @@ void GameInfoDialog::loadView()
myPPBlend->setValue(atoi(blend.c_str()));
myPPBlendLabel->setLabel(blend);
myHmoveBlanks->setSelected(myGameProperties.get(Emulation_HmoveBlanks), "YES");
myTab->loadConfig();
}
@ -477,7 +465,6 @@ void GameInfoDialog::saveConfig()
myGameProperties.set(Display_Height, myHeight->getEditString());
myGameProperties.set(Display_Phosphor, myPhosphor->getSelectedTag());
myGameProperties.set(Display_PPBlend, myPPBlendLabel->getLabel());
myGameProperties.set(Emulation_HmoveBlanks, myHmoveBlanks->getSelectedTag());
// Determine whether to add or remove an entry from the properties set
if(myDefaultsSelected)

3
stella/src/gui/GameInfoDialog.hxx
View File

@ -13,7 +13,7 @@
// See the file "license" for information on usage and redistribution of
// this file, and for a DISCLAIMER OF ALL WARRANTIES.
//
// $Id: GameInfoDialog.hxx,v 1.37 2009-01-04 22:27:44 stephena Exp $
// $Id: GameInfoDialog.hxx,v 1.38 2009-01-20 16:21:28 stephena Exp $
//
// Based on code from ScummVM - Scumm Interpreter
// Copyright (C) 2002-2004 The ScummVM project
@ -85,7 +85,6 @@ class GameInfoDialog : public Dialog, public CommandSender
PopUpWidget* myPhosphor;
SliderWidget* myPPBlend;
StaticTextWidget* myPPBlendLabel;
PopUpWidget* myHmoveBlanks;
enum {
kLeftCChanged = 'LCch',

6
stella/src/tools/create_props.pl
View File

@ -23,8 +23,7 @@ my %proptype = (
"Display.YStart" => 16,
"Display.Height" => 17,
"Display.Phosphor" => 18,
"Display.PPBlend" => 19,
"Emulation.HmoveBlanks" => 20
"Display.PPBlend" => 19
);
my @prop_defaults = (
@ -47,8 +46,7 @@ my @prop_defaults = (
"34",
"210",
"NO",
"77",
"YES"
"77"
);