From 7c88c372ac9c1f141789aadb146a31ad52e1402e Mon Sep 17 00:00:00 2001 From: Stephen Anthony Date: Thu, 14 Feb 2019 18:32:23 -0330 Subject: [PATCH] Fixed negative values shown as positive in debugger (fixes #414). --- Changes.txt | 11 +++++++---- src/common/Base.cxx | 6 +++--- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/Changes.txt b/Changes.txt index 46221134e..27e4bb6f5 100644 --- a/Changes.txt +++ b/Changes.txt @@ -25,13 +25,16 @@ - delayed player 1 swap - stuffed player move - * disabled some developer options for 'Player settings' + * Disabled some developer options for 'Player settings'. - * Removed superfluous controller option 'PADDLES_IDIR' + * Removed superfluous controller option 'PADDLES_IDIR'. - * Fixed not working 7800 pause key + * Fixed not working 7800 pause key. - * Fixed 'Dancing Plate (Unknown) (PAL)' to use joystick + * Fixed display of negative values in debugger; sometimes they were + shown as positive. + + * Fixed 'Dancing Plate (Unknown) (PAL)' to use joystick. -Have fun! diff --git a/src/common/Base.cxx b/src/common/Base.cxx index 91aae5cc8..a6a92649d 100644 --- a/src/common/Base.cxx +++ b/src/common/Base.cxx @@ -46,10 +46,10 @@ string Base::toString(int value, Common::Base::Format outputBase) } case Base::F_10: // base 10: 3 or 5 bytes (depending on value) - if(value < 0x100) - std::snprintf(vToS_buf, 4, "%3d", value & 0xff); + if(value > -0x100 && value < 0x100) + std::snprintf(vToS_buf, 5, "%3d", Int16(value)); else - std::snprintf(vToS_buf, 6, "%5d", value & 0xffff); + std::snprintf(vToS_buf, 6, "%5d", value); break; case Base::F_10_02: // base 10: 2 digits (with leading zero)