finished high scores definitions saving conversion to JSON

src/common/jsonDefinitions.hxx

@@ -207,6 +207,7 @@ NLOHMANN_JSON_SERIALIZE_ENUM(Event::Type, {
   {Event::StartPauseMode, "StartPauseMode"},
   {Event::OptionsMenuMode, "OptionsMenuMode"},
   {Event::CmdMenuMode, "CmdMenuMode"},
+  {Event::HighScoresMenuMode, "HighScoresMenuMode"},
   {Event::DebuggerMode, "DebuggerMode"},
   {Event::ExitMode, "ExitMode"},
   {Event::TakeSnapshot, "TakeSnapshot"},

src/emucore/Props.cxx

@@ -60,8 +60,6 @@ void Properties::set(PropType key, const string& value)
       case PropType::Controller_MouseAxis:
       case PropType::Display_Format:
       case PropType::Display_Phosphor:
-      case PropType::Cart_Formats:
-      case PropType::Cart_Addresses:
       {
         BSPF::toUpperCase(myProperties[pos]);
         break;
@@ -268,9 +266,6 @@ void Properties::print() const
        << get(PropType::Display_VCenter)        << "|"
        << get(PropType::Display_Phosphor)       << "|"
        << get(PropType::Display_PPBlend)        << "|"
-       << get(PropType::Cart_Variations)        << "|"
-       << get(PropType::Cart_Formats)           << "|"
-       << get(PropType::Cart_Addresses)         << "|"
        << get(PropType::Cart_Highscore)
        << endl;
 }
@@ -331,9 +326,6 @@ void Properties::printHeader()
        << "Display_VCenter|"
        << "Display_Phosphor|"
        << "Display_PPBlend|"
-       << "Cart_Variations|"
-       << "Cart_Formats|"
-       << "Cart_Addresses|"
        << "Cart_Highscore"
        << endl;
 }
@@ -368,9 +360,6 @@ std::array<string, Properties::NUM_PROPS> Properties::ourDefaultProperties =
   "0",      // Display.VCenter
   "NO",     // Display.Phosphor
   "0",      // Display.PPBlend
-  "1",      // Cart.Variations
-  "",       // Cart.Formats,
-  "",       // Cart.Addresses
   ""        // Cart.Highscore
 };
 
@@ -404,8 +393,5 @@ std::array<string, Properties::NUM_PROPS> Properties::ourPropertyNames =
   "Display.VCenter",
   "Display.Phosphor",
   "Display.PPBlend",
-  "Cart.Variations",
-  "Cart.Formats",
-  "Cart.Addresses",
   "Cart.Highscore"
 };

src/emucore/Props.hxx

@@ -48,9 +48,6 @@ enum class PropType : uInt8 {
   Display_VCenter,
   Display_Phosphor,
   Display_PPBlend,
-  Cart_Variations,
-  Cart_Formats,
-  Cart_Addresses,
   Cart_Highscore,
   NumTypes
 };

src/gui/GameInfoDialog.cxx

@@ -1022,9 +1022,7 @@ void GameInfoDialog::saveHighScoresProperties()
   }
   else
   {
-    myGameProperties.reset(PropType::Cart_Variations);
-    myGameProperties.reset(PropType::Cart_Formats);
-    myGameProperties.reset(PropType::Cart_Addresses);
+    myGameProperties.reset(PropType::Cart_Highscore);
   }
 }