Fix Unix build; minor formatting fixes.

src/debugger/gui/CartELFStateWidget.cxx

@@ -66,11 +66,13 @@ namespace {
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-CartridgeELFStateWidget::CartridgeELFStateWidget(GuiObject* boss, const GUI::Font& lfont,
+CartridgeELFStateWidget::CartridgeELFStateWidget(GuiObject* boss,
-                       const GUI::Font& nfont,
+                       const GUI::Font& lfont, const GUI::Font& nfont,
                        int x, int y, int w, int h,
                        CartridgeELF& cart)
-  : CartDebugWidget(boss, lfont, nfont, x, y, w, h), myCart(cart), myFlagValues(4)
+  : CartDebugWidget(boss, lfont, nfont, x, y, w, h),
+    myCart{cart},
+    myFlagValues(4)
 {
   initialize();
 }
@@ -124,6 +126,7 @@ void CartridgeELFStateWidget::initialize()
   myNextTransaction = new StaticTextWidget(_boss, _font, x0, y, describeTransaction(0xffff, 0xffff, ~0ll));
 }
 
+// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 void CartridgeELFStateWidget::loadConfig()
 {
   for (uInt8 i = 0; i < 16; i++)

src/debugger/gui/CartELFWidget.cxx

@@ -32,11 +32,12 @@ namespace {
 }  // namespace
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-CartridgeELFWidget::CartridgeELFWidget(GuiObject* boss, const GUI::Font& lfont,
+CartridgeELFWidget::CartridgeELFWidget(GuiObject* boss,
-                       const GUI::Font& nfont,
+                       const GUI::Font& lfont, const GUI::Font& nfont,
                        int x, int y, int w, int h,
                        CartridgeELF& cart)
-  : CartDebugWidget(boss, lfont, nfont, x, y, w, h), myCart(cart)
+  : CartDebugWidget(boss, lfont, nfont, x, y, w, h),
+    myCart{cart}
 {
   initialize();
 }

src/debugger/gui/module.mk

@@ -32,6 +32,8 @@ MODULE_OBJS := \
         src/debugger/gui/CartDPCPlusWidget.o \
         src/debugger/gui/CartDPCWidget.o \
         src/debugger/gui/CartE0Widget.o \
+        src/debugger/gui/CartELFStateWidget.o \
+        src/debugger/gui/CartELFWidget.o \
         src/debugger/gui/CartEnhancedWidget.o \
         src/debugger/gui/CartE7Widget.o \
         src/debugger/gui/CartEFSCWidget.o \
@@ -48,8 +50,6 @@ MODULE_OBJS := \
         src/debugger/gui/CartFCWidget.o \
         src/debugger/gui/CartFEWidget.o \
         src/debugger/gui/CartGLWidget.o \
-        src/debugger/gui/CartELFWidget.o \
-        src/debugger/gui/CartELFStateWidget.o \
         src/debugger/gui/CartJANEWidget.o \
         src/debugger/gui/CartMDMWidget.o \
         src/debugger/gui/CartRamWidget.o \

src/emucore/CartELF.cxx

@@ -221,8 +221,10 @@ namespace {
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeELF::CartridgeELF(const ByteBuffer& image, size_t size, string_view md5,
                            const Settings& settings)
-  : Cartridge(settings, md5), myImageSize(size), myTransactionQueue(TRANSACTION_QUEUE_CAPACITY),
+  : Cartridge(settings, md5),
-    myVcsLib(myTransactionQueue)
+    myImageSize{size},
+    myTransactionQueue{TRANSACTION_QUEUE_CAPACITY},
+    myVcsLib{myTransactionQueue}
 {
   myImage = make_unique<uInt8[]>(size);
   std::memcpy(myImage.get(), image.get(), size);
@@ -236,9 +238,6 @@ CartridgeELF::CartridgeELF(const ByteBuffer& image, size_t size, string_view md5
   allocationSections();
 }
 
-// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-CartridgeELF::~CartridgeELF() = default;
-
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 void CartridgeELF::reset()
 {
@@ -376,7 +375,6 @@ uInt8 CartridgeELF::overdrivePoke(uInt16 address, uInt8 value)
 }
 
 #ifdef DEBUGGER_SUPPORT
-
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartDebugWidget* CartridgeELF::debugWidget(
   GuiObject* boss, const GUI::Font& lfont, const GUI::Font& nfont, int x, int y, int w, int h
@@ -425,21 +423,8 @@ std::pair<unique_ptr<uInt8[]>, size_t> CartridgeELF::getArmImage() const
 
   return {std::move(image), imageSize};
 }
-
 #endif
 
-// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-inline uInt64 CartridgeELF::getArmCycles() const
-{
-  return myCortexEmu.getCycles() + myArmCyclesOffset;
-}
-
-// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-uInt64 CartridgeELF::getVcsCyclesArm() const
-{
-  return mySystem->cycles() * myArmCyclesPer6502Cycle;
-}
-
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 inline uInt8 CartridgeELF::driveBus(uInt16 address, uInt8 value)
 {

src/emucore/CartELF.hxx

@@ -25,6 +25,7 @@
 #include "ElfParser.hxx"
 #include "BusTransactionQueue.hxx"
 #include "VcsLib.hxx"
+#include "System.hxx"
 
 class ElfLinker;
 
@@ -47,7 +48,7 @@ class CartridgeELF: public Cartridge {
   public:
     CartridgeELF(const ByteBuffer& image, size_t size, string_view md5,
                  const Settings& settings);
-    ~CartridgeELF() override;
+    ~CartridgeELF() override = default;
 
   // Methods from Device
   public:
@@ -127,8 +128,12 @@ class CartridgeELF: public Cartridge {
     void setupConfig();
     void resetWithConfig();
 
-    uInt64 getArmCycles() const;
+    uInt64 getArmCycles() const {
-    uInt64 getVcsCyclesArm() const;
+      return myCortexEmu.getCycles() + myArmCyclesOffset;
+    }
+    uInt64 getVcsCyclesArm() const {
+      return mySystem->cycles() * myArmCyclesPer6502Cycle;
+    }
 
     uInt8 driveBus(uInt16 address, uInt8 value);
     void syncArmTime(uInt64 armCycles);

src/emucore/elf/ElfLinker.cxx

@@ -23,7 +23,6 @@
 #include "ElfLinker.hxx"
 
 namespace {
-  // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
   optional<ElfLinker::SegmentType> determineSegmentType(const ElfFile::Section& section)
   {
     switch (section.type) {
@@ -42,7 +41,6 @@ namespace {
     }
   }
 
-  // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
   constexpr bool checkSegmentOverlap(uInt32 segmentBase1, uInt32 segmentSize1, uInt32 segmentBase2, uInt32 segmentSize2) {
     return !(segmentBase1 + segmentSize1 <= segmentBase2 || segmentBase2 + segmentSize2 <= segmentBase1);
   }
@@ -51,7 +49,10 @@ namespace {
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 ElfLinker::ElfLinker(uInt32 textBase, uInt32 dataBase, uInt32 rodataBase,
                      const ElfFile& elf)
-  : myTextBase{textBase}, myDataBase{dataBase}, myRodataBase{rodataBase}, myElf{elf}
+  : myTextBase{textBase},
+    myDataBase{dataBase},
+    myRodataBase{rodataBase},
+    myElf{elf}
 {
 }
 

src/emucore/module.mk

@@ -36,6 +36,7 @@ MODULE_OBJS := \
 	src/emucore/CartBFSC.o \
 	src/emucore/CartDF.o \
 	src/emucore/CartDFSC.o \
+	src/emucore/CartELF.o \
 	src/emucore/CartF0.o \
 	src/emucore/CartF4.o \
 	src/emucore/CartF4SC.o \
@@ -57,7 +58,6 @@ MODULE_OBJS := \
 	src/emucore/CartWD.o \
 	src/emucore/CartWF8.o \
 	src/emucore/CartX07.o \
-	src/emucore/CartELF.o \
 	src/emucore/CompuMate.o \
 	src/emucore/Console.o \
 	src/emucore/Control.o \