Fixes for warnings from Coverity.

This commit is contained in:
Stephen Anthony 2018-08-28 22:13:02 -02:30
parent 0f8dc1f2bb
commit 46b07d14b5
5 changed files with 19 additions and 5 deletions

View File

@ -40,7 +40,10 @@ SoundSDL2::SoundSDL2(OSystem& osystem, AudioSettings& audioSettings)
myIsInitializedFlag(false), myIsInitializedFlag(false),
myVolume(100), myVolume(100),
myVolumeFactor(0xffff), myVolumeFactor(0xffff),
myDevice(0),
myEmulationTiming(nullptr),
myCurrentFragment(nullptr), myCurrentFragment(nullptr),
myUnderrun(false),
myAudioSettings(audioSettings) myAudioSettings(audioSettings)
{ {
myOSystem.logMessage("SoundSDL2::SoundSDL2 started ...", 2); myOSystem.logMessage("SoundSDL2::SoundSDL2 started ...", 2);

View File

@ -24,7 +24,15 @@
using namespace std::chrono; using namespace std::chrono;
// - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
EmulationWorker::EmulationWorker() : myPendingSignal(Signal::none), myState(State::initializing) EmulationWorker::EmulationWorker()
: myPendingSignal(Signal::none),
myState(State::initializing),
myTia(nullptr),
myCyclesPerSecond(0),
myMaxCycles(0),
myMinCycles(0),
myDispatchResult(nullptr),
myTotalCycles(0)
{ {
std::mutex mutex; std::mutex mutex;
std::unique_lock<std::mutex> lock(mutex); std::unique_lock<std::mutex> lock(mutex);

View File

@ -59,6 +59,7 @@ M6502::M6502(const Settings& settings)
icycles(0), icycles(0),
myNumberOfDistinctAccesses(0), myNumberOfDistinctAccesses(0),
myLastAddress(0), myLastAddress(0),
myLastBreakCycle(ULLONG_MAX),
myLastPeekAddress(0), myLastPeekAddress(0),
myLastPokeAddress(0), myLastPokeAddress(0),
myLastPeekBaseAddress(0), myLastPeekBaseAddress(0),

View File

@ -144,7 +144,7 @@ void TIA::reset()
myHstate = HState::blank; myHstate = HState::blank;
myCollisionMask = 0; myCollisionMask = 0;
myLinesSinceChange = 0; myLinesSinceChange = 0;
myCollisionUpdateRequired = false; myCollisionUpdateRequired = myCollisionUpdateScheduled = false;
myColorLossEnabled = myColorLossActive = false; myColorLossEnabled = myColorLossActive = false;
myColorHBlank = 0; myColorHBlank = 0;
myLastCycle = 0; myLastCycle = 0;

View File

@ -746,6 +746,11 @@ class TIA : public Device
*/ */
bool myCollisionUpdateRequired; bool myCollisionUpdateRequired;
/**
* Force schedule a collision update
*/
bool myCollisionUpdateScheduled;
/** /**
* The collision latches are represented by 15 bits in a bitfield. * The collision latches are represented by 15 bits in a bitfield.
*/ */
@ -829,9 +834,6 @@ class TIA : public Device
bool myEnableJitter; bool myEnableJitter;
uInt8 myJitterFactor; uInt8 myJitterFactor;
// Force schedule a collision update
bool myCollisionUpdateScheduled;
#ifdef DEBUGGER_SUPPORT #ifdef DEBUGGER_SUPPORT
// The arrays containing information about every byte of TIA // The arrays containing information about every byte of TIA
// indicating whether and how (RW) it is used. // indicating whether and how (RW) it is used.