ShuriZma
/
stella
mirror of https://github.com/stella-emu/stella.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

A few more fixes for suggestions from clang static analyzer.

This commit is contained in:
Stephen Anthony 2020-11-09 18:20:50 -03:30
parent 424eb6d718
commit 3c5c81df0d
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/emucore/CartEnhanced.cxx
View File

@ -93,7 +93,7 @@ void CartridgeEnhanced::install(System& system)
// Set the page accessing method for the RAM writing pages
// Note: Writes are mapped to poke() (NOT using direcPokeBase) to check for read from write port (RWP)
access.type = System::PageAccessType::WRITE;
for(uInt16 addr = ROM_OFFSET + myWriteOffset; addr < ROM_OFFSET + myWriteOffset + myRamSize; addr += System::PAGE_SIZE)
for(size_t addr = ROM_OFFSET + myWriteOffset; addr < ROM_OFFSET + myWriteOffset + myRamSize; addr += System::PAGE_SIZE)
{
const uInt16 offset = addr & myRamMask;
@ -105,7 +105,7 @@ void CartridgeEnhanced::install(System& system)
// Set the page accessing method for the RAM reading pages
access.type = System::PageAccessType::READ;
for(uInt16 addr = ROM_OFFSET + myReadOffset; addr < ROM_OFFSET + myReadOffset + myRamSize; addr += System::PAGE_SIZE)
for(size_t addr = ROM_OFFSET + myReadOffset; addr < ROM_OFFSET + myReadOffset + myRamSize; addr += System::PAGE_SIZE)
{
const uInt16 offset = addr & myRamMask;

3
src/gui/InputDialog.cxx
View File

@ -672,7 +672,8 @@ void InputDialog::handleCommand(CommandSender* sender, int cmd,
break;
case kPSpeedChanged:
myPaddleSpeed->setValueLabel(Paddles::setAnalogSensitivity(myPaddleSpeed->getValue()) * 100.F + 0.5F);
myPaddleSpeed->setValueLabel(std::round(Paddles::setAnalogSensitivity(
myPaddleSpeed->getValue()) * 100.F));
break;
case kDejitterAvChanged:

2
src/gui/VideoAudioDialog.cxx
View File

@ -631,7 +631,7 @@ void VideoAudioDialog::loadConfig()
myVolumeSlider->setValue(audioSettings.volume());
// Device
uInt32 deviceId = BSPF::clamp(audioSettings.device(), 0u,
uInt32 deviceId = BSPF::clamp(audioSettings.device(), 0U,
uInt32(instance().sound().supportedDevices().size() - 1));
myDevicePopup->setSelected(deviceId);