Minor updates for suggestions from clang.

Changes.txt

@@ -63,6 +63,10 @@
 
   * Fixed bug in autodetecting Genesis controllers.
 
+  * Fixed bug with 'thumb.trapfatal' commandline argument; sometimes Stella
+    would lock up when encountering a fatal error instead of entering the
+    debugger and displaying a message.
+
   * Fixed bug in reading from settings file with entries that were empty;
     the parsing was failing.  This affected the 'cpurandom' argument; when
     all options in it were turned off, they were all turned on again during

src/common/ThreadDebugging.cxx

@@ -20,7 +20,8 @@
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 ThreadDebuggingHelper::ThreadDebuggingHelper()
   : myMainThreadIdConfigured(false)
-{}
+{
+}
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 ThreadDebuggingHelper& ThreadDebuggingHelper::instance()

src/common/ThreadDebugging.hxx

@@ -46,7 +46,7 @@ class ThreadDebuggingHelper {
 
   private:
 
-    void fail(const string& message);
+    [[noreturn]] void fail(const string& message);
 
     ThreadDebuggingHelper();
 

src/emucore/CartCTY.cxx

@@ -312,7 +312,6 @@ bool CartridgeCTY::save(Serializer& out) const
     out.putIntArray(myMusicCounters, 3);
     out.putIntArray(myMusicFrequencies, 3);
     out.putLong(myFrequencyImage - myTuneData);
-
   }
   catch(...)
   {

src/emucore/EventHandler.cxx

@@ -1225,7 +1225,8 @@ void EventHandler::setState(EventHandlerState state)
   // after a state change, which should be supressed
   mySkipMouseMotion = true;
 
-  // Erase and pending events
+  // Erase any previously set events, since a state change implies
+  // that old events are now invalid
   myEvent.clear();
 }
 

src/emucore/exception/FatalEmulationError.cxx

@@ -20,10 +20,11 @@
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 FatalEmulationError::FatalEmulationError(const string& message)
   : myMessage(message)
-{}
+{
+}
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-const char* FatalEmulationError::what() const throw()
+const char* FatalEmulationError::what() const noexcept
 {
   return myMessage.c_str();
 }

src/emucore/exception/FatalEmulationError.hxx

@@ -26,9 +26,9 @@ class FatalEmulationError: public std::exception {
 
     FatalEmulationError(const string& message);
 
-    virtual const char* what() const throw();
+    virtual const char* what() const noexcept;
 
-    static void raise(const string& message);
+    [[noreturn]] static void raise(const string& message);
 
   private: