Yet more conversion of 'const string&' to 'string_view'.

src/common/HighScoresManager.cxx

@@ -480,28 +480,28 @@ Int32 HighScoresManager::convert(Int32 val, uInt32 maxVal, bool isBCD,
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-bool HighScoresManager::getPropBool(const json& jprops, const string& key,
+bool HighScoresManager::getPropBool(const json& jprops, string_view key,
                                     bool defVal)
 {
   return jprops.contains(key) ? jprops.at(key).get<bool>() : defVal;
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-uInt32 HighScoresManager::getPropInt(const json& jprops, const string& key,
+uInt32 HighScoresManager::getPropInt(const json& jprops, string_view key,
                                      uInt32 defVal)
 {
   return jprops.contains(key) ? jprops.at(key).get<uInt32>() : defVal;
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-string HighScoresManager::getPropStr(const json& jprops, const string& key,
+string HighScoresManager::getPropStr(const json& jprops, string_view key,
-                                     const string& defVal)
+                                     string_view defVal)
 {
-  return jprops.contains(key) ? jprops.at(key).get<string>() : defVal;
+  return jprops.contains(key) ? jprops.at(key).get<string>() : string{defVal};
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-uInt16 HighScoresManager::getPropAddr(const json& jprops, const string& key,
+uInt16 HighScoresManager::getPropAddr(const json& jprops, string_view key,
                                       uInt16 defVal)
 {
   const string str = getPropStr(jprops, key);

src/common/HighScoresManager.hxx

@@ -222,13 +222,13 @@ class HighScoresManager
     json properties(json& jprops) const;
 
     // Get value from highscore properties for given key
-    static bool getPropBool(const json& jprops, const string& key,
+    static bool getPropBool(const json& jprops, string_view key,
                             bool defVal = false);
-    static uInt32 getPropInt(const json& jprops, const string& key,
+    static uInt32 getPropInt(const json& jprops, string_view key,
                              uInt32 defVal = 0);
-    static string getPropStr(const json& jprops, const string& key,
+    static string getPropStr(const json& jprops, string_view key,
-                             const string& defVal = "");
+                             string_view defVal = "");
-    static uInt16 getPropAddr(const json& jprops, const string& key,
+    static uInt16 getPropAddr(const json& jprops, string_view key,
                               uInt16 defVal = 0);
     static HSM::ScoreAddresses getPropScoreAddr(const json& jprops);
 

src/common/KeyMap.cxx

@@ -286,12 +286,13 @@ int KeyMap::loadMapping(const json& mappings, const EventMode mode) {
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-json KeyMap::convertLegacyMapping(string list)
+json KeyMap::convertLegacyMapping(string_view lm)
 {
   json convertedMapping = json::array();
 
   // Since istringstream swallows whitespace, we have to make the
   // delimiters be spaces
+  string list{lm};
   std::replace(list.begin(), list.end(), '|', ' ');
   std::replace(list.begin(), list.end(), ':', ' ');
   std::replace(list.begin(), list.end(), ',', ' ');

src/common/KeyMap.hxx

@@ -90,7 +90,7 @@ class KeyMap
     nlohmann::json saveMapping(const EventMode mode) const;
     int loadMapping(const nlohmann::json& mapping, const EventMode mode);
 
-    static nlohmann::json convertLegacyMapping(string list);
+    static nlohmann::json convertLegacyMapping(string_view list);
 
     /** Erase all mappings for given mode */
     void eraseMode(const EventMode mode);

src/common/PJoystickHandler.cxx

@@ -47,7 +47,7 @@ PhysicalJoystickHandler::PhysicalJoystickHandler(
   }
 
   json mappings;
-  const string& serializedMapping = myOSystem.settings().getString("joymap");
+  string_view serializedMapping = myOSystem.settings().getString("joymap");
 
   try {
     mappings = json::parse(serializedMapping);
@@ -68,11 +68,11 @@ PhysicalJoystickHandler::PhysicalJoystickHandler(
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-json PhysicalJoystickHandler::convertLegacyMapping(const string& mapping)
+json PhysicalJoystickHandler::convertLegacyMapping(string_view mapping)
 {
   constexpr char CTRL_DELIM = '^';
 
-  istringstream buf(mapping);
+  istringstream buf(string{mapping});  // TODO: fixed in C++20
   string joymap, joyname;
 
   getline(buf, joymap, CTRL_DELIM); // event list size, ignore

src/common/PJoystickHandler.hxx

@@ -68,7 +68,7 @@ class PhysicalJoystickHandler
   public:
     PhysicalJoystickHandler(OSystem& system, EventHandler& handler, Event& event);
 
-    static nlohmann::json convertLegacyMapping(const string& mapping);
+    static nlohmann::json convertLegacyMapping(string_view mapping);
 
     /** Return stick ID on success, -1 on failure. */
     int add(const PhysicalJoystickPtr& stick);

src/common/PKeyboardHandler.cxx

@@ -73,7 +73,8 @@ PhysicalKeyboardHandler::PhysicalKeyboardHandler(OSystem& system, EventHandler&
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-void PhysicalKeyboardHandler::loadSerializedMappings(const string& serializedMapping, EventMode mode)
+void PhysicalKeyboardHandler::loadSerializedMappings(
+    string_view serializedMapping, EventMode mode)
 {
   json mapping;
 

src/common/PKeyboardHandler.hxx

@@ -46,7 +46,7 @@ class PhysicalKeyboardHandler
 
     PhysicalKeyboardHandler(OSystem& system, EventHandler& handler);
 
-    void loadSerializedMappings(const string& serializedMappings, EventMode mode);
+    void loadSerializedMappings(string_view serializedMappings, EventMode mode);
 
     void setDefaultMapping(Event::Type event, EventMode mode,
                            bool updateDefaults = false);

src/common/PhysicalJoystick.cxx

@@ -32,7 +32,7 @@ namespace {
     return json(eventMode).get<string>();
   }
 
-  EventMode eventModeFromJsonName(const string& name) {
+  EventMode eventModeFromJsonName(string_view name) {
     EventMode result{};
 
     from_json(json(name), result);
@@ -42,7 +42,7 @@ namespace {
 } // namespace
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-void PhysicalJoystick::initialize(int index, const string& desc,
+void PhysicalJoystick::initialize(int index, string_view desc,
             int axes, int buttons, int hats, int /*balls*/)
 {
   ID = index;
@@ -108,9 +108,9 @@ bool PhysicalJoystick::setMap(const json& map)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-json PhysicalJoystick::convertLegacyMapping(const string& mapping, const string& name)
+json PhysicalJoystick::convertLegacyMapping(string_view mapping, string_view name)
 {
-  istringstream buf(mapping);
+  istringstream buf(string{mapping});  // TODO: fixed in C++20
   json convertedMapping = json::object();
   string map;
 
@@ -152,10 +152,10 @@ void PhysicalJoystick::eraseEvent(Event::Type event, EventMode mode)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-void PhysicalJoystick::getValues(const string& list, IntArray& map)
+void PhysicalJoystick::getValues(string_view list, IntArray& map)
 {
   map.clear();
-  istringstream buf(list);
+  istringstream buf(string{list});  // TODO: fixed in C++20
 
   int value{0};
   buf >> value;  // we don't need to know the # of items at this point

src/common/PhysicalJoystick.hxx

@@ -48,14 +48,15 @@ class PhysicalJoystick
     nlohmann::json getMap() const;
     bool setMap(const nlohmann::json& map);
 
-    static nlohmann::json convertLegacyMapping(const string& mapping, const string& name);
+    static nlohmann::json convertLegacyMapping(string_view mapping,
+                                               string_view name);
 
     void eraseMap(EventMode mode);
     void eraseEvent(Event::Type event, EventMode mode);
     string about() const;
 
   protected:
-    void initialize(int index, const string& desc,
+    void initialize(int index, string_view desc,
                     int axes, int buttons, int hats, int balls);
 
   private:
@@ -76,7 +77,7 @@ class PhysicalJoystick
     JoyMap joyMap;
 
   private:
-    static void getValues(const string& list, IntArray& map);
+    static void getValues(string_view list, IntArray& map);
 
     friend ostream& operator<<(ostream& os, const PhysicalJoystick& s) {
       os << "  ID: " << s.ID << ", name: " << s.name << ", numaxis: " << s.numAxes

src/common/StringParser.hxx

@@ -50,9 +50,9 @@ class StringParser
       @param str    The string to split
       @param maxlen The maximum length of string to generate
     */
-    StringParser(const string& str, uInt32 maxlen)
+    StringParser(string_view str, uInt32 maxlen)
     {
-      istringstream buf(str);
+      istringstream buf(string{str});  // TODO: fixed in C++20
       string line;
 
       while(std::getline(buf, line, '\n'))

src/common/VideoModeHandler.cxx

@@ -95,7 +95,7 @@ VideoModeHandler::buildMode(const Settings& settings, bool inTIAMode)
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 VideoModeHandler::Mode::Mode(uInt32 iw, uInt32 ih, Stretch smode,
-                             Int32 fsindex, const string& desc,
+                             Int32 fsindex, string_view desc,
                              float zoomLevel)
   : Mode(iw, ih, iw, ih, smode, fsindex, desc, zoomLevel)
 {
@@ -103,13 +103,13 @@ VideoModeHandler::Mode::Mode(uInt32 iw, uInt32 ih, Stretch smode,
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 VideoModeHandler::Mode::Mode(uInt32 iw, uInt32 ih, uInt32 sw, uInt32 sh,
-                             Stretch smode, Int32 fsindex, const string& desc,
+                             Stretch smode, Int32 fsindex, string_view desc,
                              float zoomLevel, float overscan)
-  : screenS(sw, sh),
+  : screenS{sw, sh},
-    stretch(smode),
+    stretch{smode},
-    description(desc),
+    description{desc},
-    zoom(zoomLevel),
+    zoom{zoomLevel},
-    fsIndex(fsindex)
+    fsIndex{fsindex}
 {
   // Now resize based on windowed/fullscreen mode and stretch factor
   if(fsIndex != -1)  // fullscreen mode

src/common/VideoModeHandler.hxx

@@ -49,10 +49,10 @@ class VideoModeHandler
 
       Mode() = default;
       Mode(uInt32 iw, uInt32 ih, uInt32 sw, uInt32 sh, Stretch smode,
-           Int32 fsindex = -1, const string& desc = "",
+           Int32 fsindex = -1, string_view desc = "",
            float zoomLevel = 1.F, float overscan = 1.F);
       Mode(uInt32 iw, uInt32 ih, Stretch smode, Int32 fsindex = -1,
-           const string& desc = "", float zoomLevel = 1.F);
+           string_view desc = "", float zoomLevel = 1.F);
 
       friend ostream& operator<<(ostream& os, const Mode& vm)
       {

src/common/repository/sqlite/SqliteError.hxx

@@ -24,7 +24,7 @@
 class SqliteError : public std::exception
 {
   public:
-    explicit SqliteError(const string& message) : myMessage{message} { }
+    explicit SqliteError(string_view message) : myMessage{message} { }
     explicit SqliteError(sqlite3* handle) : myMessage{sqlite3_errmsg(handle)} { }
 
     const char* what() const noexcept override { return myMessage.c_str(); }

src/debugger/gui/CartDebugWidget.cxx

@@ -38,8 +38,8 @@ CartDebugWidget::CartDebugWidget(GuiObject* boss, const GUI::Font& lfont,
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-int CartDebugWidget::addBaseInformation(size_t bytes, const string& manufacturer,
+int CartDebugWidget::addBaseInformation(size_t bytes, string_view manufacturer,
-        const string& desc, const uInt16 maxlines)
+        string_view desc, const uInt16 maxlines)
 {
   const int lwidth = _font.getStringWidth("Manufacturer "),
             fwidth = _w - lwidth - 12;

src/debugger/gui/CartDebugWidget.hxx

@@ -38,8 +38,8 @@ class CartDebugWidget : public Widget, public CommandSender
     ~CartDebugWidget() override = default;
 
   public:
-    int addBaseInformation(size_t bytes, const string& manufacturer,
+    int addBaseInformation(size_t bytes, string_view manufacturer,
-        const string& desc, const uInt16 maxlines = 10);
+        string_view desc, const uInt16 maxlines = 10);
 
     // Inform the ROM Widget that the underlying cart has somehow changed
     void invalidate();

src/debugger/gui/RomWidget.cxx

@@ -231,7 +231,7 @@ void RomWidget::disassemble(int disasm_line)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-void RomWidget::patchROM(int disasm_line, const string& bytes,
+void RomWidget::patchROM(int disasm_line, string_view bytes,
                          Common::Base::Fmt base)
 {
   const uInt16 address = getAddress(disasm_line);

src/debugger/gui/RomWidget.hxx

@@ -53,8 +53,7 @@ class RomWidget : public Widget, public CommandSender
     void runtoPC(int disasm_line);
     void setTimer(int disasm_line);
     void disassemble(int disasm_line);
-    void patchROM(int disasm_line, const string& bytes,
+    void patchROM(int disasm_line, string_view bytes, Common::Base::Fmt base);
-                  Common::Base::Fmt base);
     uInt16 getAddress(int disasm_line);
 
   private:

src/debugger/gui/TiaOutputWidget.cxx

@@ -63,7 +63,7 @@ void TiaOutputWidget::loadConfig()
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-void TiaOutputWidget::saveSnapshot(int execDepth, const string& execPrefix,
+void TiaOutputWidget::saveSnapshot(int execDepth, string_view execPrefix,
                                    bool mark)
 {
 #ifdef IMAGE_SUPPORT

src/debugger/gui/TiaOutputWidget.hxx

@@ -36,7 +36,7 @@ class TiaOutputWidget : public Widget, public CommandSender
     void loadConfig() override;
     void setZoomWidget(TiaZoomWidget* w) { myZoom = w; }
 
-    void saveSnapshot(int execDepth = 0, const string& execPrefix = EmptyString,
+    void saveSnapshot(int execDepth = 0, string_view execPrefix = EmptyString,
                       bool mark = true);
 
 // Eventually, these methods will enable access to the onscreen TIA image

src/emucore/Bankswitch.cxx

@@ -24,8 +24,9 @@ string Bankswitch::typeToName(Bankswitch::Type type)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-Bankswitch::Type Bankswitch::nameToType(const string& name)
+Bankswitch::Type Bankswitch::nameToType(string_view n)  // FIXME: name
 {
+  string name{n};
   const auto it = ourNameToTypes.find(name);
   if(it != ourNameToTypes.end())
     return it->second;

src/emucore/Bankswitch.hxx

@@ -75,7 +75,7 @@ class Bankswitch
     static string typeToName(Bankswitch::Type type);
 
     // Convert string to BSType enum
-    static Bankswitch::Type nameToType(const string& name);
+    static Bankswitch::Type nameToType(string_view name);
 
     // Convert BSType enum to description string
     static string typeToDesc(Bankswitch::Type type);

src/emucore/Cart0840.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge0840::Cartridge0840(const ByteBuffer& image, size_t size,
-                             const string& md5, const Settings& settings,
+                             string_view md5, const Settings& settings,
                              size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/Cart0840.hxx

@@ -46,7 +46,7 @@ class Cartridge0840 : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    Cartridge0840(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge0840(const ByteBuffer& image, size_t size, string_view md5,
                   const Settings& settings, size_t bsSize = 8_KB);
     ~Cartridge0840() override = default;
 

src/emucore/Cart0FA0.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge0FA0::Cartridge0FA0(const ByteBuffer& image, size_t size,
-    const string& md5, const Settings& settings)
+    string_view md5, const Settings& settings)
   : CartridgeEnhanced(image, size, md5, settings, 8_KB)
 {
 }

src/emucore/Cart0FA0.hxx

@@ -47,7 +47,7 @@ class Cartridge0FA0 : public CartridgeEnhanced
       @param md5           The md5sum of the ROM image
       @param settings      A reference to the various settings (read-only)
     */
-    Cartridge0FA0(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge0FA0(const ByteBuffer& image, size_t size, string_view md5,
       const Settings& settings);
     ~Cartridge0FA0() override = default;
 

src/emucore/Cart2K.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge2K::Cartridge2K(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/Cart2K.hxx

@@ -49,7 +49,7 @@ class Cartridge2K : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    Cartridge2K(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge2K(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 2_KB);
     ~Cartridge2K() override = default;
 

src/emucore/Cart3E.cxx

@@ -21,7 +21,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge3E::Cartridge3E(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings,
                       bsSize == 0 ? BSPF::nextMultipleOf(size, 2_KB) : bsSize)

src/emucore/Cart3E.hxx

@@ -74,7 +74,7 @@ class Cartridge3E : public CartridgeEnhanced
       @param bsSize    The size specified by the bankswitching scheme
                        (where 0 means variable-sized ROM)
     */
-    Cartridge3E(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge3E(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 0);
     ~Cartridge3E() override = default;
 

src/emucore/Cart3EPlus.cxx

@@ -21,7 +21,7 @@
 
 //  - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge3EPlus::Cartridge3EPlus(const ByteBuffer& image, size_t size,
-                                 const string& md5, const Settings& settings,
+                                 string_view md5, const Settings& settings,
                                  size_t bsSize)
   : Cartridge3E(image, size, md5, settings,
                 bsSize == 0 ? BSPF::nextMultipleOf(size, 1_KB) : bsSize)

src/emucore/Cart3EPlus.hxx

@@ -97,7 +97,7 @@ class Cartridge3EPlus: public Cartridge3E
       @param bsSize    The size specified by the bankswitching scheme
                        (where 0 means variable-sized ROM)
     */
-    Cartridge3EPlus(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge3EPlus(const ByteBuffer& image, size_t size, string_view md5,
                     const Settings& settings, size_t bsSize = 0);
     ~Cartridge3EPlus() override = default;
 

src/emucore/Cart3EX.cxx

@@ -19,7 +19,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge3EX::Cartridge3EX(const ByteBuffer& image, size_t size,
-                           const string& md5, const Settings& settings)
+                           string_view md5, const Settings& settings)
   : Cartridge3E(image, size, md5, settings)
 {
   // 0xFFFA contains RAM bank count - 1;

src/emucore/Cart3EX.hxx

@@ -41,7 +41,7 @@ class Cartridge3EX : public Cartridge3E
       @param md5       The md5sum of the ROM image
       @param settings  A reference to the various settings (read-only)
     */
-    Cartridge3EX(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge3EX(const ByteBuffer& image, size_t size, string_view md5,
                  const Settings& settings);
     ~Cartridge3EX() override = default;
 

src/emucore/Cart3F.cxx

@@ -21,7 +21,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge3F::Cartridge3F(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings,
                       bsSize == 0 ? BSPF::nextPowerOfTwo(size) : bsSize)

src/emucore/Cart3F.hxx

@@ -53,7 +53,7 @@ class Cartridge3F : public CartridgeEnhanced
       @param bsSize    The size specified by the bankswitching scheme
                        (where 0 means variable-sized ROM)
     */
-    Cartridge3F(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge3F(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 0);
     ~Cartridge3F() override = default;
 

src/emucore/Cart4A50.cxx

@@ -22,7 +22,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge4A50::Cartridge4A50(const ByteBuffer& image, size_t size,
-                             const string& md5, const Settings& settings)
+                             string_view md5, const Settings& settings)
   : Cartridge(settings, md5),
     myImage{make_unique<uInt8[]>(128_KB)},
     mySize{size}

src/emucore/Cart4A50.hxx

@@ -65,7 +65,7 @@ class Cartridge4A50 : public Cartridge
       @param md5       The md5sum of the ROM image
       @param settings  A reference to the various settings (read-only)
     */
-    Cartridge4A50(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge4A50(const ByteBuffer& image, size_t size, string_view md5,
                   const Settings& settings);
     ~Cartridge4A50() override = default;
 

src/emucore/Cart4K.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge4K::Cartridge4K(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/Cart4K.hxx

@@ -46,7 +46,7 @@ class Cartridge4K : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    Cartridge4K(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge4K(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 4_KB);
     ~Cartridge4K() override = default;
 

src/emucore/Cart4KSC.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 Cartridge4KSC::Cartridge4KSC(const ByteBuffer& image, size_t size,
-                             const string& md5, const Settings& settings,
+                             string_view md5, const Settings& settings,
                              size_t bsSize)
   : Cartridge4K(image, size, md5, settings, bsSize)
 {

src/emucore/Cart4KSC.hxx

@@ -47,7 +47,7 @@ class Cartridge4KSC : public Cartridge4K
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    Cartridge4KSC(const ByteBuffer& image, size_t size, const string& md5,
+    Cartridge4KSC(const ByteBuffer& image, size_t size, string_view md5,
                   const Settings& settings, size_t bsSize = 4_KB);
     ~Cartridge4KSC() override = default;
 

src/emucore/CartAR.cxx

@@ -22,7 +22,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeAR::CartridgeAR(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings)
+                         string_view md5, const Settings& settings)
   : Cartridge(settings, md5),
     mySize{std::max(size, LOAD_SIZE)}
 {

src/emucore/CartAR.hxx

@@ -57,7 +57,7 @@ class CartridgeAR : public Cartridge
       @param md5       The md5sum of the ROM image
       @param settings  A reference to the various settings (read-only)
     */
-    CartridgeAR(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeAR(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings);
     ~CartridgeAR() override = default;
 

src/emucore/CartBF.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeBF::CartridgeBF(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartBF.hxx

@@ -47,7 +47,7 @@ class CartridgeBF : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeBF(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeBF(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 256_KB);
     ~CartridgeBF() override = default;
 

src/emucore/CartBFSC.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeBFSC::CartridgeBFSC(const ByteBuffer& image, size_t size,
-                             const string& md5, const Settings& settings,
+                             string_view md5, const Settings& settings,
                              size_t bsSize)
   : CartridgeBF(image, size, md5, settings, bsSize)
 {

src/emucore/CartBFSC.hxx

@@ -47,7 +47,7 @@ class CartridgeBFSC : public CartridgeBF
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeBFSC(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeBFSC(const ByteBuffer& image, size_t size, string_view md5,
                   const Settings& settings, size_t bsSize = 256_KB);
     ~CartridgeBFSC() override = default;
 

src/emucore/CartCM.cxx

@@ -22,7 +22,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeCM::CartridgeCM(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings)
+                         string_view md5, const Settings& settings)
   : Cartridge(settings, md5),
     myImage{make_unique<uInt8[]>(16_KB)}
 {

src/emucore/CartCM.hxx

@@ -120,7 +120,7 @@ class CartridgeCM : public Cartridge
       @param md5       The md5sum of the ROM image
       @param settings  A reference to the various settings (read-only)
     */
-    CartridgeCM(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeCM(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings);
     ~CartridgeCM() override = default;
 

src/emucore/CartCTY.cxx

@@ -23,7 +23,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeCTY::CartridgeCTY(const ByteBuffer& image, size_t size,
-                           const string& md5, const Settings& settings)
+                           string_view md5, const Settings& settings)
   : Cartridge(settings, md5),
     myImage{make_unique<uInt8[]>(32_KB)}
 {

src/emucore/CartCTY.hxx

@@ -118,7 +118,7 @@ class CartridgeCTY : public Cartridge
       @param md5       The md5sum of the ROM image
       @param settings  A reference to the settings object
     */
-    CartridgeCTY(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeCTY(const ByteBuffer& image, size_t size, string_view md5,
                  const Settings& settings);
     ~CartridgeCTY() override = default;
 

src/emucore/CartCV.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeCV::CartridgeCV(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartCV.hxx

@@ -49,7 +49,7 @@ class CartridgeCV : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeCV(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeCV(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 2_KB);
     ~CartridgeCV() override = default;
 

src/emucore/CartCreator.cxx

@@ -72,7 +72,7 @@
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 unique_ptr<Cartridge> CartCreator::create(const FSNode& file,
     const ByteBuffer& image, size_t size, string& md5,
-    const string& dtype, Settings& settings)
+    string_view dtype, Settings& settings)
 {
   unique_ptr<Cartridge> cartridge;
   Bankswitch::Type type = Bankswitch::nameToType(dtype),
@@ -224,8 +224,9 @@ CartCreator::createFromMultiCart(const ByteBuffer& image, size_t& size,
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 unique_ptr<Cartridge>
-CartCreator::createFromImage(const ByteBuffer& image, size_t size, Bankswitch::Type type,
+CartCreator::createFromImage(const ByteBuffer& image, size_t size,
-                             const string& md5, Settings& settings)
+                             Bankswitch::Type type, string_view md5,
+                             Settings& settings)
 {
   // We should know the cart's type by now so let's create it
   switch(type)

src/emucore/CartCreator.hxx

@@ -47,7 +47,7 @@ class CartCreator
     */
     static unique_ptr<Cartridge> create(const FSNode& file,
                  const ByteBuffer& image, size_t size, string& md5,
-                 const string& dtype, Settings& settings);
+                 string_view dtype, Settings& settings);
 
   private:
     /**
@@ -82,7 +82,7 @@ class CartCreator
     */
     static unique_ptr<Cartridge>
       createFromImage(const ByteBuffer& image, size_t size, Bankswitch::Type type,
-                      const string& md5, Settings& settings);
+                      string_view md5, Settings& settings);
 
   private:
     // Following constructors and assignment operators not supported

src/emucore/CartDF.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeDF::CartridgeDF(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartDF.hxx

@@ -47,7 +47,7 @@ class CartridgeDF : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeDF(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeDF(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 128_KB);
     ~CartridgeDF() override = default;
 

src/emucore/CartDFSC.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeDFSC::CartridgeDFSC(const ByteBuffer& image, size_t size,
-                             const string& md5, const Settings& settings,
+                             string_view md5, const Settings& settings,
                              size_t bsSize)
   : CartridgeDF(image, size, md5, settings, bsSize)
 {

src/emucore/CartDFSC.hxx

@@ -47,7 +47,7 @@ class CartridgeDFSC : public CartridgeDF
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeDFSC(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeDFSC(const ByteBuffer& image, size_t size, string_view md5,
                   const Settings& settings, size_t bsSize = 128_KB);
     ~CartridgeDFSC() override = default;
 

src/emucore/CartDPC.cxx

@@ -22,7 +22,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeDPC::CartridgeDPC(const ByteBuffer& image, size_t size,
-                           const string& md5, const Settings& settings,
+                           string_view md5, const Settings& settings,
                            size_t bsSize)
   : CartridgeF8(image, size, md5, settings, bsSize)
 {

src/emucore/CartDPC.hxx

@@ -48,7 +48,7 @@ class CartridgeDPC : public CartridgeF8
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeDPC(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeDPC(const ByteBuffer& image, size_t size, string_view md5,
                  const Settings& settings, size_t bsSize = 10_KB);
     ~CartridgeDPC() override = default;
 

src/emucore/CartE0.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeE0::CartridgeE0(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartE0.hxx

@@ -55,7 +55,7 @@ class CartridgeE0 : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeE0(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeE0(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 8_KB);
     ~CartridgeE0() override = default;
 

src/emucore/CartE7.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeE7::CartridgeE7(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings)
+                         string_view md5, const Settings& settings)
   : Cartridge(settings, md5),
     mySize{size}
 {

src/emucore/CartE7.hxx

@@ -75,7 +75,7 @@ class CartridgeE7 : public Cartridge
       @param md5       The md5sum of the ROM image
       @param settings  A reference to the various settings (read-only)
     */
-    CartridgeE7(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeE7(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings);
     ~CartridgeE7() override = default;
 

src/emucore/CartEF.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeEF::CartridgeEF(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartEF.hxx

@@ -47,7 +47,7 @@ class CartridgeEF : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeEF(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeEF(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 64_KB);
     ~CartridgeEF() override = default;
 

src/emucore/CartEFSC.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeEFSC::CartridgeEFSC(const ByteBuffer& image, size_t size,
-                             const string& md5, const Settings& settings,
+                             string_view md5, const Settings& settings,
                              size_t bsSize)
   : CartridgeEF(image, size, md5, settings, bsSize)
 {

src/emucore/CartEFSC.hxx

@@ -48,7 +48,7 @@ class CartridgeEFSC : public CartridgeEF
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeEFSC(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeEFSC(const ByteBuffer& image, size_t size, string_view md5,
                   const Settings& settings, size_t bsSize = 64_KB);
     ~CartridgeEFSC() override = default;
 

src/emucore/CartEnhanced.cxx

@@ -22,7 +22,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeEnhanced::CartridgeEnhanced(const ByteBuffer& image, size_t size,
-                                     const string& md5, const Settings& settings,
+                                     string_view md5, const Settings& settings,
                                      size_t bsSize)
   : Cartridge(settings, md5)
 {

src/emucore/CartEnhanced.hxx

@@ -47,7 +47,7 @@ class CartridgeEnhanced : public Cartridge
       @param bsSize    The size specified by the bankswitching scheme
     */
     CartridgeEnhanced(const ByteBuffer& image, size_t size,
-                      const string& md5, const Settings& settings,
+                      string_view md5, const Settings& settings,
                       size_t bsSize);
     ~CartridgeEnhanced() override = default;
 

src/emucore/CartF0.cxx

@@ -19,7 +19,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeF0::CartridgeF0(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartF0.hxx

@@ -44,7 +44,7 @@ class CartridgeF0 : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeF0(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeF0(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 64_KB);
     ~CartridgeF0() override = default;
 

src/emucore/CartF4.cxx

@@ -19,7 +19,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeF4::CartridgeF4(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartF4.hxx

@@ -43,7 +43,7 @@ class CartridgeF4 : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeF4(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeF4(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 32_KB);
     ~CartridgeF4() override = default;
 

src/emucore/CartF4SC.cxx

@@ -19,7 +19,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeF4SC::CartridgeF4SC(const ByteBuffer& image, size_t size,
-                             const string& md5, const Settings& settings,
+                             string_view md5, const Settings& settings,
                              size_t bsSize)
   : CartridgeF4(image, size, md5, settings, bsSize)
 {

src/emucore/CartF4SC.hxx

@@ -44,7 +44,7 @@ class CartridgeF4SC : public CartridgeF4
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeF4SC(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeF4SC(const ByteBuffer& image, size_t size, string_view md5,
                   const Settings& settings, size_t bsSize = 32_KB);
     ~CartridgeF4SC() override = default;
 

src/emucore/CartF6.cxx

@@ -19,7 +19,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeF6::CartridgeF6(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartF6.hxx

@@ -43,7 +43,7 @@ class CartridgeF6 : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeF6(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeF6(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 16_KB);
     ~CartridgeF6() override = default;
 

src/emucore/CartF6SC.cxx

@@ -19,7 +19,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeF6SC::CartridgeF6SC(const ByteBuffer& image, size_t size,
-                             const string& md5, const Settings& settings,
+                             string_view md5, const Settings& settings,
                              size_t bsSize)
   : CartridgeF6(image, size, md5, settings, bsSize)
 {

src/emucore/CartF6SC.hxx

@@ -44,7 +44,7 @@ class CartridgeF6SC : public CartridgeF6
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeF6SC(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeF6SC(const ByteBuffer& image, size_t size, string_view md5,
                   const Settings& settings, size_t bsSize = 16_KB);
     ~CartridgeF6SC() override = default;
 

src/emucore/CartF8.cxx

@@ -19,7 +19,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeF8::CartridgeF8(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartF8.hxx

@@ -43,7 +43,7 @@ class CartridgeF8 : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeF8(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeF8(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 8_KB);
     ~CartridgeF8() override = default;
 

src/emucore/CartF8SC.cxx

@@ -19,7 +19,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeF8SC::CartridgeF8SC(const ByteBuffer& image, size_t size,
-                             const string& md5, const Settings& settings,
+                             string_view md5, const Settings& settings,
                              size_t bsSize)
   : CartridgeF8(image, size, md5, settings, bsSize)
 {

src/emucore/CartF8SC.hxx

@@ -44,7 +44,7 @@ class CartridgeF8SC : public CartridgeF8
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeF8SC(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeF8SC(const ByteBuffer& image, size_t size, string_view md5,
                   const Settings& settings, size_t bsSize = 8_KB);
     ~CartridgeF8SC() override = default;
 

src/emucore/CartFA.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeFA::CartridgeFA(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartFA.hxx

@@ -47,7 +47,7 @@ class CartridgeFA : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeFA(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeFA(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 12_KB);
     ~CartridgeFA() override = default;
 

src/emucore/CartFA2.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeFA2::CartridgeFA2(const ByteBuffer& image, size_t size,
-                           const string& md5, const Settings& settings,
+                           string_view md5, const Settings& settings,
                            size_t bsSize)
   : CartridgeFA(image, size, md5, settings, bsSize)
 {

src/emucore/CartFA2.hxx

@@ -59,7 +59,7 @@ class CartridgeFA2 : public CartridgeFA
       @param settings  A reference to the settings object
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeFA2(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeFA2(const ByteBuffer& image, size_t size, string_view md5,
                  const Settings& settings, size_t bsSize = 28_KB);
     ~CartridgeFA2() override = default;
 

src/emucore/CartFC.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeFC::CartridgeFC(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings,
                       bsSize == 0 ? BSPF::nextPowerOfTwo(size) : bsSize)

src/emucore/CartFC.hxx

@@ -50,7 +50,7 @@ class CartridgeFC : public CartridgeEnhanced
       @param bsSize    The size specified by the bankswitching scheme
                        (where 0 means variable-sized ROM)
     */
-    CartridgeFC(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeFC(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 0);
     ~CartridgeFC() override = default;
 

src/emucore/CartFE.cxx

@@ -21,7 +21,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeFE::CartridgeFE(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings, bsSize)
 {

src/emucore/CartFE.hxx

@@ -90,7 +90,7 @@ class CartridgeFE : public CartridgeEnhanced
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeFE(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeFE(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 8_KB);
     ~CartridgeFE() override = default;
 

src/emucore/CartMDM.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeMDM::CartridgeMDM(const ByteBuffer& image, size_t size,
-                           const string& md5, const Settings& settings,
+                           string_view md5, const Settings& settings,
                            size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings,
                       bsSize == 0 ? BSPF::nextPowerOfTwo(size) : bsSize)

src/emucore/CartMDM.hxx

@@ -59,7 +59,7 @@ class CartridgeMDM : public CartridgeEnhanced
       @param bsSize    The size specified by the bankswitching scheme
                        (where 0 means variable-sized ROM)
     */
-    CartridgeMDM(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeMDM(const ByteBuffer& image, size_t size, string_view md5,
                  const Settings& settings, size_t bsSize = 0);
     ~CartridgeMDM() override = default;
 

src/emucore/CartMVC.cxx

@@ -1557,8 +1557,8 @@ bool MovieCart::load(Serializer& in)
 }
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
-CartridgeMVC::CartridgeMVC(const string& path, size_t size,
+CartridgeMVC::CartridgeMVC(string_view path, size_t size,
-                           const string& md5, const Settings& settings,
+                           string_view md5, const Settings& settings,
                            size_t bsSize)
   : Cartridge(settings, md5),
     myImage{make_unique<uInt8[]>(bsSize)},  // not used

src/emucore/CartMVC.hxx

@@ -50,7 +50,7 @@ class CartridgeMVC : public Cartridge
       @param settings  A reference to the various settings (read-only)
       @param bsSize    The size specified by the bankswitching scheme
     */
-    CartridgeMVC(const string& path, size_t size, const string& md5,
+    CartridgeMVC(string_view path, size_t size, string_view md5,
                  const Settings& settings, size_t bsSize = 8_KB);
     ~CartridgeMVC() override;
 

src/emucore/CartSB.cxx

@@ -20,7 +20,7 @@
 
 // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 CartridgeSB::CartridgeSB(const ByteBuffer& image, size_t size,
-                         const string& md5, const Settings& settings,
+                         string_view md5, const Settings& settings,
                          size_t bsSize)
   : CartridgeEnhanced(image, size, md5, settings,
                       bsSize == 0 ? BSPF::nextPowerOfTwo(size) : bsSize)

src/emucore/CartSB.hxx

@@ -48,7 +48,7 @@ class CartridgeSB : public CartridgeEnhanced
       @param bsSize    The size specified by the bankswitching scheme
                        (where 0 means variable-sized ROM)
     */
-    CartridgeSB(const ByteBuffer& image, size_t size, const string& md5,
+    CartridgeSB(const ByteBuffer& image, size_t size, string_view md5,
                 const Settings& settings, size_t bsSize = 0);
     ~CartridgeSB() override = default;