ShuriZma
/
rpcs3
mirror of https://github.com/RPCS3/rpcs3.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

small improvement (#7288) 

* small improvement

* comments addressed

Co-authored-by: kd-11 <15904127+kd-11@users.noreply.github.com>
This commit is contained in:
Maksim Derbasov 2020-01-22 15:28:48 +03:00 committed by Ani
parent adcc3e9c4b
commit 1abdee242a
7 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
rpcs3/Emu/Cell/Modules/cellCamera.cpp
View File

@ -273,7 +273,6 @@ static error_code check_camera_info(const CellCameraInfoEx& info)
std::pair<u32, u32> get_video_resolution(const CellCameraInfoEx& info)
{
std::pair<u32, u32> res;
switch (info.resolution)
{
case CELL_CAMERA_VGA: return{ 640, 480 };

2
rpcs3/Emu/Cell/Modules/cellSsl.cpp
View File

@ -75,7 +75,7 @@ s32 cellSslGetMemoryInfo()
return CELL_OK;
}
std::string getCert(const std::string certPath, const int certID, const bool isNormalCert)
std::string getCert(const std::string& certPath, const int certID, const bool isNormalCert)
{
int newID = certID;

1
rpcs3/Emu/GDB.cpp
View File

@ -423,7 +423,6 @@ bool gdb_thread::select_thread(u64 id)
std::string gdb_thread::get_reg(ppu_thread* thread, u32 rid)
{
std::string result;
//ids from gdb/features/rs6000/powerpc-64.c
//pc
switch (rid) {

3
rpcs3/Emu/RSX/Common/surface_store.h
View File

@ -271,8 +271,9 @@ namespace rsx
}
else
{
const auto reserve = list1.size() + list2.size();
surface_info = std::move(list1);
surface_info.reserve(list1.size() + list2.size());
surface_info.reserve(reserve);
for (const auto& e : list2) surface_info.push_back(e);
}

2
rpcs3/Emu/RSX/GL/GLFragmentProgram.cpp
View File

@ -50,8 +50,6 @@ void GLFragmentDecompilerThread::insertHeader(std::stringstream & OS)
void GLFragmentDecompilerThread::insertInputs(std::stringstream & OS)
{
std::vector<std::string> inputs_to_declare;
for (const ParamType& PT : m_parr.params[PF_PARAM_IN])
{
for (const ParamItem& PI : PT.items)

4
rpcs3/Emu/RSX/VK/VKDMA.cpp
View File

@ -49,7 +49,7 @@ namespace vk
allocated_memory = std::make_unique<vk::buffer>(dev, size,
dev.get_memory_mapping().host_visible_coherent, VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
VK_BUFFER_USAGE_TRANSFER_DST_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT, 0);
VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT, 0);
page_info.resize(size / s_bytes_per_entry, ~0ull);
}
@ -210,7 +210,7 @@ namespace vk
auto new_allocation = std::make_unique<vk::buffer>(dev, new_size,
dev.get_memory_mapping().host_visible_coherent, VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
VK_BUFFER_USAGE_TRANSFER_DST_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT, 0);
VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT, 0);
VkBufferCopy copy{};
copy.size = allocated_memory->size();

1
rpcs3/Input/evdev_joystick_handler.cpp
View File

@ -697,7 +697,6 @@ PadHandlerBase::connection evdev_joystick_handler::update_connection(const std::
void evdev_joystick_handler::get_mapping(const std::shared_ptr<PadDevice>& device, const std::shared_ptr<Pad>& pad)
{
std::unordered_map<u64, u16> values;
m_dev = std::static_pointer_cast<EvdevDevice>(device);
if (!m_dev || !pad)
return;