ShuriZma
/
project64
mirror of https://github.com/project64/project64.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update X86.c 

Fix typos, capitalization, punctuation, add TODO, fix abbreviations, and change multi line comments into single line comments
This commit is contained in:
Derek "Turtle" Roe 2021-03-19 01:23:11 -05:00
parent 0ed9f0b5f7
commit efd8a3721d
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Source/RSP/X86.c
View File

@ -8,7 +8,7 @@
#include "log.h" #include "log.h"
#include "Types.h" #include "Types.h"
#pragma warning(disable : 4152) // nonstandard extension, function/data pointer conversion in expression #pragma warning(disable : 4152) // Non-standard extension, function/data pointer conversion in expression
#define PUTDST8(dest,value) (*((BYTE *)(dest))=(BYTE)(value)); dest += 1; #define PUTDST8(dest,value) (*((BYTE *)(dest))=(BYTE)(value)); dest += 1;
#define PUTDST16(dest,value) (*((WORD *)(dest))=(WORD)(value)); dest += 2; #define PUTDST16(dest,value) (*((WORD *)(dest))=(WORD)(value)); dest += 2;
@ -136,7 +136,7 @@ void AddConstToX86Reg(int x86Reg, size_t Const)
const size_t sign_extension_mask = ~(zero_extension_mask); const size_t sign_extension_mask = ~(zero_extension_mask);
const size_t extension_from_8bit = Const & sign_extension_mask; const size_t extension_from_8bit = Const & sign_extension_mask;
/* To do: if 64-bit x86, then what if `Const' upper DWORD set? */ // TODO: If 64-bit x86, then what if `Const' upper DWORD set?
CPU_Message(" add %s, %Xh",x86_Name(x86Reg),Const); CPU_Message(" add %s, %Xh",x86_Name(x86Reg),Const);
if (extension_from_8bit != 0 && extension_from_8bit != sign_extension_mask) { if (extension_from_8bit != 0 && extension_from_8bit != sign_extension_mask) {
switch (x86Reg) { switch (x86Reg) {
@ -1084,10 +1084,10 @@ void JsLabel32(char *Label, DWORD Value) {
PUTDST32(RecompPos,Value); PUTDST32(RecompPos,Value);
} }
/* // TODO: Rewrite this?
** NOTE: this op can get really complex with muls // NOTE: This op can get really complex with muls
** if we need this rewrite it into 1 function // If we need this, rewrite it into 1 function
**/
void LeaSourceAndOffset(int x86DestReg, int x86SourceReg, size_t offset) { void LeaSourceAndOffset(int x86DestReg, int x86SourceReg, size_t offset) {
WORD x86Command = 0; WORD x86Command = 0;
@ -1118,7 +1118,7 @@ void LeaSourceAndOffset(int x86DestReg, int x86SourceReg, size_t offset) {
DisplayError("LeaSourceAndOffset\nUnknown x86 Register"); DisplayError("LeaSourceAndOffset\nUnknown x86 Register");
} }
// To do: Check high DWORD of offset for 64-bit x86. // TODO: Check high DWORD of offset for 64-bit x86
if ((offset & 0x00000000FFFFFF80) != 0 && (offset & ~0x7F) != ~0x7F) { if ((offset & 0x00000000FFFFFF80) != 0 && (offset & ~0x7F) != ~0x7F) {
PUTDST16(RecompPos,x86Command); PUTDST16(RecompPos,x86Command);
PUTDST32(RecompPos,offset); PUTDST32(RecompPos,offset);