Update Debugger-ViewMemory.cpp
Fix capitalization, add and fix some TODO comments
This commit is contained in:
parent
85f8eb31a6
commit
d9dbd77533
|
@ -567,11 +567,11 @@ LRESULT CDebugMemoryView::OnHxCtrlKeyPressed(LPNMHDR lpNMHDR)
|
||||||
m_Breakpoints->ClearMemLocks();
|
m_Breakpoints->ClearMemLocks();
|
||||||
break;
|
break;
|
||||||
case 'F':
|
case 'F':
|
||||||
// todo put selection in the textbox
|
// TODO: put selection in the textbox
|
||||||
m_Debugger->OpenMemorySearch();
|
m_Debugger->OpenMemorySearch();
|
||||||
break;
|
break;
|
||||||
case 'S':
|
case 'S':
|
||||||
// todo set start and end addrs to selection
|
// TODO: set start and end address to selection
|
||||||
m_Debugger->OpenMemoryDump();
|
m_Debugger->OpenMemoryDump();
|
||||||
break;
|
break;
|
||||||
case 'T':
|
case 'T':
|
||||||
|
@ -786,8 +786,8 @@ LRESULT CDebugMemoryView::OnHxGetByteInfo(LPNMHDR lpNMHDR)
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
// always use virtual addresses for breakpoint & symbol info
|
// Always use virtual addresses for breakpoint and symbol info
|
||||||
// todo should be the other way around
|
// TODO: should be the other way around
|
||||||
uint32_t vaddress = m_bVirtualMemory ? address : address + 0x80000000;
|
uint32_t vaddress = m_bVirtualMemory ? address : address + 0x80000000;
|
||||||
|
|
||||||
CSymbol symbol;
|
CSymbol symbol;
|
||||||
|
@ -938,7 +938,7 @@ LRESULT CDebugMemoryView::OnHxHotAddrChanged(LPNMHDR /*lpNMHDR*/)
|
||||||
|
|
||||||
LRESULT CDebugMemoryView::OnHxBaseAddrChanged(LPNMHDR /*lpNMHDR*/)
|
LRESULT CDebugMemoryView::OnHxBaseAddrChanged(LPNMHDR /*lpNMHDR*/)
|
||||||
{
|
{
|
||||||
// address was updated from the control
|
// Address was updated from the control
|
||||||
uint32_t address = m_HexEditCtrl.GetBaseAddress();
|
uint32_t address = m_HexEditCtrl.GetBaseAddress();
|
||||||
m_bIgnoreAddressInput = true;
|
m_bIgnoreAddressInput = true;
|
||||||
m_MemAddr.SetValue(address, DisplayMode::ZeroExtend);
|
m_MemAddr.SetValue(address, DisplayMode::ZeroExtend);
|
||||||
|
@ -973,7 +973,7 @@ LRESULT CDebugMemoryView::OnHxPaste(LPNMHDR lpNMHDR)
|
||||||
if (nmp->column == HX_COL_HEXDATA)
|
if (nmp->column == HX_COL_HEXDATA)
|
||||||
{
|
{
|
||||||
char* data = NULL;
|
char* data = NULL;
|
||||||
// todo move this function to some utility class
|
// TODO: move this function to some utility class
|
||||||
int length = CMemoryScanner::ParseHexString(NULL, text);
|
int length = CMemoryScanner::ParseHexString(NULL, text);
|
||||||
|
|
||||||
if (length != 0)
|
if (length != 0)
|
||||||
|
@ -1143,7 +1143,7 @@ void CDebugMemoryView::CloseTab(int nItem)
|
||||||
{
|
{
|
||||||
if (nItem == m_TabCtrl.GetItemCount() - 1)
|
if (nItem == m_TabCtrl.GetItemCount() - 1)
|
||||||
{
|
{
|
||||||
// last tab
|
// Last tab
|
||||||
m_TabCtrl.SetCurSel(nItem - 1);
|
m_TabCtrl.SetCurSel(nItem - 1);
|
||||||
}
|
}
|
||||||
else if (nItem == nSelItem)
|
else if (nItem == nSelItem)
|
||||||
|
|
Loading…
Reference in New Issue