Merge pull request #1910 from flagrama/fix-manual-start-emulation

Fix Start Emulation by only skipping StartEmulation when AutoStart is disabled
This commit is contained in:
zilmar 2021-02-20 15:15:51 +10:30 committed by GitHub
commit c1ed471fc1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 16 deletions

View File

@ -516,11 +516,7 @@ bool CN64System::RunFileImage(const char * FileLoc)
g_Settings->SaveString(File_DiskIPLTOOLPath, FileLoc); g_Settings->SaveString(File_DiskIPLTOOLPath, FileLoc);
} }
if (g_Settings->LoadBool(Setting_AutoStart) != 0) RunLoadedImage();
{
WriteTrace(TraceN64System, TraceDebug, "Automattically starting rom");
RunLoadedImage();
}
return true; return true;
} }
@ -538,11 +534,7 @@ bool CN64System::RunDiskImage(const char * FileLoc)
} }
g_Settings->SaveBool(Setting_EnableDisk, true); g_Settings->SaveBool(Setting_EnableDisk, true);
if (g_Settings->LoadBool(Setting_AutoStart) != 0) RunLoadedImage();
{
WriteTrace(TraceN64System, TraceDebug, "Automattically starting rom");
RunLoadedImage();
}
return true; return true;
} }
@ -564,11 +556,7 @@ bool CN64System::RunDiskComboImage(const char * FileLoc, const char * FileLocDis
} }
g_Settings->SaveBool(Setting_EnableDisk, true); g_Settings->SaveBool(Setting_EnableDisk, true);
if (g_Settings->LoadBool(Setting_AutoStart) != 0) RunLoadedImage();
{
WriteTrace(TraceN64System, TraceDebug, "Automattically starting rom");
RunLoadedImage();
}
return true; return true;
} }
@ -578,7 +566,11 @@ void CN64System::RunLoadedImage(void)
g_BaseSystem = new CN64System(g_Plugins, (uint32_t)time(NULL), false, false); g_BaseSystem = new CN64System(g_Plugins, (uint32_t)time(NULL), false, false);
if (g_BaseSystem) if (g_BaseSystem)
{ {
g_BaseSystem->StartEmulation(true); if (g_Settings->LoadBool(Setting_AutoStart) != 0)
{
WriteTrace(TraceN64System, TraceDebug, "Automattically starting rom");
g_BaseSystem->StartEmulation(true);
}
} }
else else
{ {

View File

@ -302,6 +302,10 @@ bool CMainMenu::ProcessMessage(HWND hWnd, DWORD /*FromAccelerator*/, DWORD MenuI
//Now we have created again, we can start up emulation //Now we have created again, we can start up emulation
if (g_BaseSystem) if (g_BaseSystem)
{ {
if (g_Settings->LoadBool(Setting_AutoStart) == 0)
{
WriteTrace(TraceN64System, TraceDebug, "Manually starting rom");
}
g_BaseSystem->StartEmulation(true); g_BaseSystem->StartEmulation(true);
} }
else else