From dcef4902d3c8a92366158ef54ec32b0fdd742aaf Mon Sep 17 00:00:00 2001 From: "Derek \"Turtle\" Roe" Date: Thu, 11 Mar 2021 02:00:30 -0600 Subject: [PATCH 1/6] Add new line to the end of UpdateVersion.cpp --- Source/UpdateVersion/UpdateVersion.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/UpdateVersion/UpdateVersion.cpp b/Source/UpdateVersion/UpdateVersion.cpp index 90d5bcba9..f951aae50 100644 --- a/Source/UpdateVersion/UpdateVersion.cpp +++ b/Source/UpdateVersion/UpdateVersion.cpp @@ -70,4 +70,4 @@ int main() } } return 0; -} \ No newline at end of file +} From 4b240ad0ba5581f6fc9a3867226e98d993b5dced Mon Sep 17 00:00:00 2001 From: "Derek \"Turtle\" Roe" Date: Thu, 11 Mar 2021 02:00:59 -0600 Subject: [PATCH 2/6] Re-word a comment to be more general and make more sense --- Source/SortRdb/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/SortRdb/main.cpp b/Source/SortRdb/main.cpp index 2fe50297a..b6304d63d 100644 --- a/Source/SortRdb/main.cpp +++ b/Source/SortRdb/main.cpp @@ -326,7 +326,7 @@ int main (int argc, char *argv[]) if (PDNameSections.size() > 0) { fprintf(fp,"//================ PD ================\n"); - fprintf(fp,"//\n// ROMs below are PD/Intros/Emus and other Non Commercial\n\n"); + fprintf(fp,"//\n// ROMs below are public domain/homebrew and other non-commercial releases\n\n"); for (strmap::iterator itr = PDNameSections.begin(); itr != PDNameSections.end(); itr++) { std::string GoodName = itr->first; From f4032a4e643fd16a20e00995831eb26d2f9f7a69 Mon Sep 17 00:00:00 2001 From: "Derek \"Turtle\" Roe" Date: Thu, 11 Mar 2021 02:01:39 -0600 Subject: [PATCH 3/6] Add last newline and adjust 2 comments --- Source/Settings/Settings.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Settings/Settings.cpp b/Source/Settings/Settings.cpp index 843b206a8..c9f81e5d2 100644 --- a/Source/Settings/Settings.cpp +++ b/Source/Settings/Settings.cpp @@ -185,7 +185,7 @@ void RegisterSetting(short SettingID, SETTING_DATA_TYPE Type, const char * Name, case Data_DWORD_RDB_Setting: if (DefaultDW != 0) { - //create default + // Create default DefaultID = SettingID + g_PluginSettings.DefaultStartRange; g_PluginSettings.RegisterSetting(g_PluginSettings.handle, DefaultID, g_PluginSettings.NoDefault, Data_DWORD, SettingType_ConstValue, g_PluginSettingName, "", DefaultDW); @@ -200,7 +200,7 @@ void RegisterSetting(short SettingID, SETTING_DATA_TYPE Type, const char * Name, case Data_String_RDB_Setting: if (DefaultStr != NULL && strlen(DefaultStr) > 0) { - //create default + // Create default DefaultID = SettingID + g_PluginSettings.DefaultStartRange; g_PluginSettings.RegisterSetting(g_PluginSettings.handle, DefaultID, g_PluginSettings.NoDefault, Data_String, SettingType_ConstString, g_PluginSettingName, DefaultStr, 0); @@ -384,4 +384,4 @@ void CNotification::BreakPoint(const char * FileName, int LineNumber) { g_PluginNotification.BreakPoint(FileName, LineNumber); } -} \ No newline at end of file +} From 74c1389e756ecbc41321c59e62615823f9d41fcf Mon Sep 17 00:00:00 2001 From: "Derek \"Turtle\" Roe" Date: Thu, 11 Mar 2021 02:02:21 -0600 Subject: [PATCH 4/6] Eliminate some title case, and improve wording and typos --- Source/Settings/Settings.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/Source/Settings/Settings.h b/Source/Settings/Settings.h index 3040f693e..46fb41a1c 100644 --- a/Source/Settings/Settings.h +++ b/Source/Settings/Settings.h @@ -4,11 +4,11 @@ extern "C" { #endif - // Get Plugin Settings, take a setting id + // Get plugin settings, take a setting ID unsigned int GetSetting(short SettingID); const char * GetSettingSz(short SettingID, char * Buffer, int BufferLen); - // Get System Settings, take a setting returned by FindSystemSettingId + // Get system settings, take a setting returned by FindSystemSettingId unsigned int GetSystemSetting(short SettingID); const char * GetSystemSettingSz(short SettingID, char * Buffer, int BufferLen); @@ -19,20 +19,20 @@ extern "C" { void SetSystemSetting(short SettingID, unsigned int Value); void SetSystemSettingSz(short SettingID, const char * Value); - // enum's + // Enums enum SETTING_DATA_TYPE { - Data_DWORD_General = 0, // A unsigned int setting used anywhere + Data_DWORD_General = 0, // An unsigned int setting used anywhere Data_String_General = 1, // A string setting used anywhere - Data_DWORD_Game = 2, // A unsigned int associated with the current game + Data_DWORD_Game = 2, // An unsigned int associated with the current game Data_String_Game = 3, // A string associated with the current game - Data_DWORD_RDB = 4, // A unsigned int associated with the current game in the rom database - Data_String_RDB = 5, // A string associated with the current game in the rom database - Data_DWORD_RDB_Setting = 6, // A unsigned int read from the rom database, with config file - Data_String_RDB_Setting = 7, // A string read from the rom database, with config file + Data_DWORD_RDB = 4, // An unsigned int associated with the current game in the ROM database + Data_String_RDB = 5, // A string associated with the current game in the ROM database + Data_DWORD_RDB_Setting = 6, // An unsigned int read from the ROM database, with config file + Data_String_RDB_Setting = 7, // A string read from the ROM database, with config file }; - // set other information about different settings + // Set other information about various settings int SettingsInitilized(void); void SetModuleName(const char * Name); void RegisterSetting(short SettingID, SETTING_DATA_TYPE Type, const char * Name, const char * Category, @@ -41,7 +41,7 @@ extern "C" { short FindSystemSettingId(const char * Name); void FlushSettings(void); - // this must be implemented to be notified when a setting is used but has not been set up + // This must be implemented to be notified when a setting is used but has not been set up void UseUnregisteredSetting(int SettingID); typedef void(*SettingChangedFunc)(void *); From 5bb120e7a3cd051a974c5343b08661369b3f5911 Mon Sep 17 00:00:00 2001 From: "Derek \"Turtle\" Roe" Date: Thu, 11 Mar 2021 02:06:37 -0600 Subject: [PATCH 5/6] Eliminate some title case and adjust wording --- Source/JoinSettings/main.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/JoinSettings/main.cpp b/Source/JoinSettings/main.cpp index 6e558228f..3d509d377 100644 --- a/Source/JoinSettings/main.cpp +++ b/Source/JoinSettings/main.cpp @@ -123,7 +123,7 @@ typedef std::map Files; void RegionSection(CFile &TargetIniFile, Files &files, const char * Region, const char * RegionCode) { - stdstr_f LineData = stdstr_f("//--------------- %s Region Cheat Codes ---------------\r\n\r\n", Region); + stdstr_f LineData = stdstr_f("//--------------- %s Region cheat codes ---------------\r\n\r\n", Region); TargetIniFile.Write(LineData.c_str(), (int)LineData.length()); bool first = true; @@ -226,9 +226,9 @@ void JoinFile(const char * Directory, const char * Target) } if (strcmp(CPath(Target).GetExtension().c_str(), "cht") == 0) { - stdstr_f LineData = stdstr_f("// Project64 Official Cheats Database\r\n"); + stdstr_f LineData = stdstr_f("// Project64 official cheat database\r\n"); TargetIniFile.Write(LineData.c_str(), (int)LineData.length()); - LineData = stdstr_f("// Not for use with PJ64 v1.6 or previous\r\n"); + LineData = stdstr_f("// Not for use with Project64 v1.6 or lower\r\n"); TargetIniFile.Write(LineData.c_str(), (int)LineData.length()); LineData = stdstr_f("// ----------------------------------------------------\r\n\r\n"); TargetIniFile.Write(LineData.c_str(), (int)LineData.length()); From 02bd9eedcfd32dc8b833c61e4b39f734eeec3ce3 Mon Sep 17 00:00:00 2001 From: "Derek \"Turtle\" Roe" Date: Thu, 11 Mar 2021 02:30:25 -0600 Subject: [PATCH 6/6] Add a newline to the example API JavaScript file --- Scripts/example.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Scripts/example.js b/Scripts/example.js index fb730c308..d0fbf715e 100644 --- a/Scripts/example.js +++ b/Scripts/example.js @@ -1 +1 @@ -console.log("Hello world! See apidoc.htm for documentation."); \ No newline at end of file +console.log("Hello world! See apidoc.htm for documentation.");