ShuriZma
/
project64
mirror of https://github.com/project64/project64.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Glide64] NULL MessageBox title instead of "Error" 

According to MSDN, a MessageBox whose title param is a null pointer defaults to the text "Error".
So instead of allocating extra bytes to pass a pointer to the string `"Error"`, why not pass NULL?

Actually the real reason why I made this PR was me having OCD against a cosmetic spacing inconsistency introduced in this commit:  aefe8e603c .  So if you prefer "Error" over NULL I'll just undo that part of this PR and keep the line break change in instead. :P
This commit is contained in:
cxd4 2016-01-25 15:31:04 -05:00
parent 96903f729e
commit a10200cbce
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Glide64/rdp.cpp
View File

@ -336,9 +336,9 @@ void microcheck()
ReleaseGfx();
#ifdef _WIN32
MessageBox(gfx.hWnd, stdstr_f("Error: uCode crc not found in INI, using currently selected uCode\n\n%08lx", uc_crc).c_str(), "Error", MB_OK | MB_ICONEXCLAMATION);
MessageBox(gfx.hWnd, stdstr_f("Error: uCode crc not found in INI, using currently selected uCode\n\n%08lx", uc_crc).c_str(), NULL, MB_OK | MB_ICONEXCLAMATION);
#endif
ucode_error_report = FALSE; // don't report any more ucode errors from this game
}
else if (uc == -1 && ucode_error_report)
@ -347,7 +347,7 @@ void microcheck()
ReleaseGfx();
#ifdef _WIN32
MessageBox(gfx.hWnd, stdstr_f("Error: Unsupported uCode!\n\ncrc: %08lx", uc_crc).c_str(), "Error", MB_OK | MB_ICONEXCLAMATION);
MessageBox(gfx.hWnd, stdstr_f("Error: Unsupported uCode!\n\ncrc: %08lx", uc_crc).c_str(), NULL, MB_OK | MB_ICONEXCLAMATION);
#endif
ucode_error_report = FALSE; // don't report any more ucode errors from this game
@ -4174,4 +4174,4 @@ void CALL ProcessRDPList(void)
dp_status &= ~0x0002;
//}
}
}