#549 changed switch/case table to cascaded range checks

This commit is contained in:
jmarlin 2015-07-28 17:41:53 -04:00
parent 9f52cfd348
commit 8e75ec2ce7
1 changed files with 27 additions and 35 deletions

View File

@ -12,7 +12,7 @@
DWORD CMemoryLabel::AsciiToHex (char * HexValue) DWORD CMemoryLabel::AsciiToHex (char * HexValue)
{ {
DWORD Count, Finish, Value = 0; DWORD Count, Finish, Current, Value = 0;
Finish = strlen(HexValue); Finish = strlen(HexValue);
if (Finish > 8 ) if (Finish > 8 )
@ -23,33 +23,25 @@ DWORD CMemoryLabel::AsciiToHex (char * HexValue)
for (Count = 0; Count < Finish; Count++) for (Count = 0; Count < Finish; Count++)
{ {
Value = (Value << 4); Value = (Value << 4);
switch ( HexValue[Count] ) Current = HexValue[Count];
if(Current >= '0' && Current <= '9')
{ {
case '0': break; Value += Current - '0';
case '1': Value += 1; break; }
case '2': Value += 2; break; else
case '3': Value += 3; break; {
case '4': Value += 4; break; if(Current < 'A')
case '5': Value += 5; break; Current += 'A'
case '6': Value += 6; break;
case '7': Value += 7; break; if (Current >= 'A' && Current <= 'F')
case '8': Value += 8; break; {
case '9': Value += 9; break; Value += Current + 10 - 'A';
case 'A': Value += 10; break; }
case 'a': Value += 10; break; else
case 'B': Value += 11; break; {
case 'b': Value += 11; break; Value = (Value >> 4);
case 'C': Value += 12; break; Count = Finish;
case 'c': Value += 12; break; }
case 'D': Value += 13; break;
case 'd': Value += 13; break;
case 'E': Value += 14; break;
case 'e': Value += 14; break;
case 'F': Value += 15; break;
case 'f': Value += 15; break;
default:
Value = (Value >> 4);
Count = Finish;
} }
} }
return Value; return Value;
@ -80,9 +72,9 @@ stdstr CMemoryLabel::LabelName ( DWORD Address ) const
//{ //{
// return (*theIterator).second; // return (*theIterator).second;
//} //}
char strLabelName[100]; char strLabelName[100];
sprintf(strLabelName,"0x%08X",Address); sprintf(strLabelName,"0x%08X",Address);
return stdstr(strLabelName); return stdstr(strLabelName);
} }
@ -109,7 +101,7 @@ void CMemoryLabel::LoadLabelList ( char * file )
} }
SetFilePointer(hFile,0,NULL,FILE_BEGIN); SetFilePointer(hFile,0,NULL,FILE_BEGIN);
DWORD FileSize = GetFileSize(hFile,NULL); DWORD FileSize = GetFileSize(hFile,NULL);
void * FileContents = VirtualAlloc(NULL,FileSize,MEM_COMMIT,PAGE_READWRITE ); void * FileContents = VirtualAlloc(NULL,FileSize,MEM_COMMIT,PAGE_READWRITE );
@ -128,7 +120,7 @@ void CMemoryLabel::LoadLabelList ( char * file )
ProcessCODFile((BYTE *)FileContents, FileSize); ProcessCODFile((BYTE *)FileContents, FileSize);
} }
VirtualFree(FileContents, 0, MEM_RELEASE); VirtualFree(FileContents, 0, MEM_RELEASE);
CloseHandle(hFile); CloseHandle(hFile);
m_NewLabels = 0; m_NewLabels = 0;
@ -152,7 +144,7 @@ void CMemoryLabel::SaveLabelList()
HANDLE hFile = CreateFile(CurrentLabelFile.c_str(),GENERIC_WRITE, FILE_SHARE_READ|FILE_SHARE_WRITE,NULL, HANDLE hFile = CreateFile(CurrentLabelFile.c_str(),GENERIC_WRITE, FILE_SHARE_READ|FILE_SHARE_WRITE,NULL,
CREATE_ALWAYS,FILE_ATTRIBUTE_NORMAL | FILE_FLAG_SEQUENTIAL_SCAN, NULL); CREATE_ALWAYS,FILE_ATTRIBUTE_NORMAL | FILE_FLAG_SEQUENTIAL_SCAN, NULL);
SetFilePointer(hFile,0,NULL,FILE_BEGIN); SetFilePointer(hFile,0,NULL,FILE_BEGIN);
for (StringMap::iterator Item = m_LabelList.begin(); Item != m_LabelList.end(); Item++) for (StringMap::iterator Item = m_LabelList.begin(); Item != m_LabelList.end(); Item++)
{ {
char Text[300]; char Text[300];
@ -160,9 +152,9 @@ void CMemoryLabel::SaveLabelList()
sprintf(Text, "0x%08X,%s\r\n",(*Item).first,((*Item).second).c_str()); sprintf(Text, "0x%08X,%s\r\n",(*Item).first,((*Item).second).c_str());
WriteFile( hFile,Text,strlen(Text),&dwWritten,NULL ); WriteFile( hFile,Text,strlen(Text),&dwWritten,NULL );
} }
CloseHandle(hFile); CloseHandle(hFile);
} }
@ -186,7 +178,7 @@ void CMemoryLabel::ProcessCODFile(BYTE * File, DWORD FileLen)
return; return;
} }
CurrentPos += 1; CurrentPos += 1;
if (strchr(CurrentPos,',') - CurrentPos != 8) if (strchr(CurrentPos,',') - CurrentPos != 8)
{ {
return; return;